--- Begin Message ---
Hi
Please welcome the very first bug report (which comes from one of PyMVPA
people ;)). Should I forward them to the mailing list next time
Cheers
----- Forwarded message from Michael Hanke <[EMAIL PROTECTED]> -----
Date: Wed, 25 Jun 2008 11:46:30 +0200
From: Michael Hanke <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: Bug#487939: python-mdp: ICA nodes do not pass params to WhiteningNode
X-CRM114-Status: Good ( pR: 22.5030 )
Package: python-mdp
Version: 2.3+svn20080515-2
Severity: normal
Tags: patch
Hi,
This version of MDP does not allow ICANodes to send params to the
WhiteningNode they use internally. Although, both documentation and API
indicate that it is supposed to work.
The reason is, that the ICANode constructor ignores its own argument
'white_parm'.
Please find the attached patch, which fixes the problem. It also changes
the default value of this argument to 'None' instead of '{}', as the
former has probably unintended sideeffects:
http://www.python.org/doc/2.1.3/tut/node6.html#SECTION006710000000000000000
(from 'Important warning:' on ;-)
Thanks,
Michael
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages python-mdp depends on:
ii python 2.5.2-1 An interactive high-level object-o
ii python-numpy 1:1.1.0-1 Numerical Python adds a fast array
ii python-support 0.7.6 automated rebuilding support for p
Versions of packages python-mdp recommends:
ii python-symeig 1.4-2 Symmetrical eigenvalue routines fo
-- no debconf information
--
GPG key: 1024D/3144BE0F Michael Hanke
http://apsy.gse.uni-magdeburg.de/hanke
ICQ: 48230050
----- End forwarded message -----
--
Yaroslav Halchenko
Research Assistant, Psychology Department, Rutgers-Newark
Student Ph.D. @ CS Dept. NJIT
Office: (973) 353-5440x263 | FWD: 82823 | Fax: (973) 353-1171
101 Warren Str, Smith Hall, Rm 4-105, Newark NJ 07102
WWW: http://www.linkedin.com/in/yarik
diff -rNu mdp-2.3+svn20080515.orig/mdp/nodes/ica_nodes.py mdp-2.3+svn20080515/mdp/nodes/ica_nodes.py
--- mdp-2.3+svn20080515.orig/mdp/nodes/ica_nodes.py 2008-05-15 20:28:28.000000000 +0200
+++ mdp-2.3+svn20080515/mdp/nodes/ica_nodes.py 2008-06-25 11:37:43.000000000 +0200
@@ -42,7 +42,7 @@
"""
def __init__(self, limit = 0.001, telescope = False, verbose = False,
- whitened = False, white_comp = None, white_parm = {},
+ whitened = False, white_comp = None, white_parm = None,
input_dim = None, dtype = None):
"""
Input arguments:
@@ -72,7 +72,10 @@
self.limit = limit
self.whitened = whitened
self.white_comp = white_comp
- self.white_parm = {}
+ if not white_parm is None:
+ self.white_parm = white_parm
+ else:
+ self.white_parm = {}
super(ICANode, self).__init__(input_dim, None, dtype)
@@ -325,7 +328,7 @@
sample_size = 1, fine_tanh = 1, fine_gaus = 1,
max_it = 1000, max_it_fine = 100,
failures = 5, limit = 0.001, verbose = False,
- whitened = False, white_comp = None, white_parm = {},
+ whitened = False, white_comp = None, white_parm = None,
input_dim = None, dtype=None):
"""
Input arguments:
@@ -935,7 +938,7 @@
"""
def __init__(self, lags=1, limit = 0.00001, max_iter=10000,
verbose = False, whitened = False, white_comp = None,
- white_parm = {}, input_dim = None, dtype = None):
+ white_parm = None, input_dim = None, dtype = None):
"""
Input arguments:
@@ -966,7 +969,7 @@
super(TDSEPNode, self).__init__(lags=lags, sfa_ica_coeff=[0.,1.],
icaweights=None, sfaweights=None,
whitened=whitened,white_comp=white_comp,
- white_parm = {},
+ white_parm = None,
eps_contrast=limit,
max_iter=max_iter, RP=None,
verbose=verbose,
signature.asc
Description: Digital signature
--- End Message ---
