Your message dated Thu, 22 Jan 2009 00:28:21 +0000
with message-id <[email protected]>
has caused the report #512584,
regarding git.Repo.commits_between always returns None
to be marked as having been forwarded to the upstream software
author(s) [email protected]
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
512584: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512584
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Hello all,
Attached is an email regarding a bug in git.Repo.commits_between. Also
attached is a patch fixing the issue.
Regards,
Dan
--- Begin Message ---
Package: python-git
Version: 0.1.5-1
Severity: normal
Tags: patch
Hi.
git.Repo.commits_between always returns None because it looks like
this:
return Commit.find_all(self, "%s..%s" % (frm, to)).reverse()
list.reverse reverses in place and returns None.
I attach a patch to fix this.
Thanks,
--
Jonny Lamb, UK
[email protected]
signature.asc
Description: Digital signature
--- End Message ---
diff -Nruad -Nruad python-git-0.1.5.orig/lib/git/repo.py python-git-0.1.5/lib/git/repo.py
--- python-git-0.1.5.orig/lib/git/repo.py 2009-01-21 23:59:24.000000000 +0000
+++ python-git-0.1.5/lib/git/repo.py 2009-01-22 00:00:11.000000000 +0000
@@ -135,7 +135,7 @@
Returns
``git.Commit[]``
"""
- return Commit.find_all(self, "%s..%s" % (frm, to)).reverse()
+ return reversed(Commit.find_all(self, "%s..%s" % (frm, to)))
def commits_since(self, start = 'master', since = '1970-01-01'):
"""
--- End Message ---
