Hello Tristan, as far as i understand it, taint checking is always on, and I'm not using mod_perl.
when I do a http://sven/cgi-bin/twiki/rdiff/Main/WebHome?rev1=1.20&rev2=1.19 I get no entries in /var/log/apache2/error.log file can you see if you get the problem using the distributed topics? Is there anything else you cna think of ? (I'm loath to make changes until I know what's causing it, and why its different from my system) mind you, I don't know what the errors that I had were, i'm not getting them this time, so it may well be topic data related :( Cheers Sven On Mon, 2005-05-09 at 18:31 -0400, [EMAIL PROTECTED] wrote: > Hello Sven > > Thank you for the response. When I click "Diffs" on any topic I > open a link that looks like: > > https://twiki/cgi-bin/twiki/rdiff/Systems/SystemData?rev1=1.29&rev2=1.24 > > Assuming you have taint checking turned on, this sort of link will > always produce the error with the original RDiff.pm, although I > suppose it might be dependant upon the version of perl or mod_perl. > > What errors did you get in your log? Did you make the change for > both rev1 and rev2? > > A diff of the original and fixed files: > > [EMAIL PROTECTED]:/usr/share/perl5/TWiki/UI# diff RDiff.pm.orig > RDiff.pm.works > 410,411c410,411 > < $rev1 =~ s/r?1\.//go; # cut 'r' and major > < $rev2 =~ s/r?1\.//go; # cut 'r' and major > --- > > ($rev1) = $rev1 =~ /r?1\.(\d*)/; # cut 'r' and major > > ($rev2) = $rev2 =~ /r?1\.(\d*)/; # cut 'r' and major > > Tristan > > > > On Sat, May 07, 2005 at 07:15:29PM +1000, Sven Dowideit wrote: > > I'm sorry, but I cannot re-produce this. and when testing your suggested > > change, I get other errors in my log. > > > > is there any more information you can give me? > > > > (what topics, what kind of changes, which particular diffs link) > > > > Sven > > -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
