also sprach Erik van Konijnenburg <[EMAIL PROTECTED]> [2005.05.21.1917 +0200]:
> > -       echo "Starting raid devices: "
> > +      if [ -d /dev/.udevdb -a ! -e /dev/md0 -a ! -e /dev/md/0 ]; then
> > +        echo -n "Creating raid device nodes: "
> > +        cd /dev && WRITE_ON_UDEV=1 ./MAKEDEV md
> > +        echo "done."
> > +      fi
> > +      echo -n "Starting raid devices: "
> 
> I suspect this will not work if /dev/md0 is activated by the initrd,
> and the user wants to mount /dev/md7 which is not touched by initrd.
> At the moment, I can't test suspicion, so please feel free to ignore the
> following ramblings if testers are happy.

What makes you suspicious? Whether the initrd has created device
nodes or not, the above should just create all the missing ones
for minors 0 through 15.

> The attached patch changes this, so that --auto works regardless of command
> line settings, like so:

This is of course a much nicer solution. I am indifferent as to
which one is preferable, given the closeness to the release.

I do want to note that your patch could be improved further, but we
need some discussion about how to do this:

> -                             mdfd = open_mddev(devlist->devname, 
> array_ident->autof);
> +                             mdfd = open_mddev(devlist->devname, (autof ? 
> autof : array_ident->autof));

so if auto=mdp appears in the config, and --auto=md is passed, which
one should take priority? Right now, the command line option does
so.

Isn't --auto=yes intended to enable this but read the actual setting
from the configuration file? I am not sure that your patch still
allows this.

-- 
 .''`.     martin f. krafft <[EMAIL PROTECTED]>
: :'  :    proud Debian developer, admin, user, and author
`. `'`
  `-  Debian - when you have better things to do than fixing a system
 
Invalid/expired PGP subkeys? Use subkeys.pgp.net as keyserver!
 
"anyone who is capable of getting themselves made president
 should on no account be allowed to do the job"
                                                      -- douglas adams

Attachment: signature.asc
Description: Digital signature

Reply via email to