tags 475971 + patch
thanks
Hi,
Attached is the diff for my player 2.0.4-3.2 NMU.
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
Debugging is twice as hard as writing the code in the first place. Therefore,
if you write the code as cleverly as possible, you are, by definition, not
smart enough to debug it.
-- Brian W. Kernighan
diff -u player-2.0.4/client_libs/libplayerc/bindings/python/Makefile.in player-2.0.4/client_libs/libplayerc/bindings/python/Makefile.in
--- player-2.0.4/client_libs/libplayerc/bindings/python/Makefile.in
+++ player-2.0.4/client_libs/libplayerc/bindings/python/Makefile.in
@@ -744,9 +744,12 @@
echo "builddir = '$(builddir)'" >> $(top_builddir)/client_libs/libplayerc/bindings/python/srcbuilddirs.py
echo "top_builddir = '$(top_builddir)'" >> $(top_builddir)/client_libs/libplayerc/bindings/python/srcbuilddirs.py
+COMMA = ,
+
# Use distutils to build module
pythonbuild: playerc_oo.i ../../playerc.h srcbuilddirs.py
if test ! -s $(top_builddir)/client_libs/libplayerc/bindings/python/setup.py; then cp $(srcdir)/setup.py $(top_builddir)/client_libs/libplayerc/bindings/python/setup.py; fi
+ env LDFLAGS=$(filter-out -Wl$(COMMA)-z$(COMMA)defs,$(LDFLAGS)) \
python $(top_builddir)/client_libs/libplayerc/bindings/python/setup.py build
# For distcheck builds, clean up the files we created in the build tree
diff -u player-2.0.4/debian/changelog player-2.0.4/debian/changelog
--- player-2.0.4/debian/changelog
+++ player-2.0.4/debian/changelog
@@ -1,3 +1,12 @@
+player (2.0.4-3.2) unstable; urgency=high
+
+ * Non-maintainer upload.
+ * $(filter-out) -Wl,-z,defs from LDFLAGS when building the Python extension
+ in client_libs/libplayerc/bindings/python/Makefile.{am,in} -- fixes FTBFS
+ and closes: #475971.
+
+ -- Adeodato Simó <[EMAIL PROTECTED]> Mon, 21 Apr 2008 21:30:12 +0200
+
player (2.0.4-3.1) unstable; urgency=low
* Non-maintainer upload.
only in patch2:
unchanged:
--- player-2.0.4.orig/client_libs/libplayerc/bindings/python/Makefile.am
+++ player-2.0.4/client_libs/libplayerc/bindings/python/Makefile.am
@@ -30,9 +30,12 @@
echo "builddir = '$(builddir)'" >> $(top_builddir)/client_libs/libplayerc/bindings/python/srcbuilddirs.py
echo "top_builddir = '$(top_builddir)'" >> $(top_builddir)/client_libs/libplayerc/bindings/python/srcbuilddirs.py
+COMMA = ,
+
# Use distutils to build module
pythonbuild: playerc_oo.i ../../playerc.h srcbuilddirs.py
if test ! -s $(top_builddir)/client_libs/libplayerc/bindings/python/setup.py; then cp $(srcdir)/setup.py $(top_builddir)/client_libs/libplayerc/bindings/python/setup.py; fi
+ env LDFLAGS=$(filter-out -Wl$(COMMA)-z$(COMMA)defs,$(LDFLAGS)) \
python $(top_builddir)/client_libs/libplayerc/bindings/python/setup.py build
# For distcheck builds, clean up the files we created in the build tree