-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Thomas,
Thomas Bushnell BSG wrote: > The logic expressed in the #gnucash discussion is bogus. Errors like > ENLNK or EMLNK would also prevent link but not prevent copying. There > is no harm in at least trying copying if EROFS comes in, and the code > shouldn't assume that every error on link will be an error on copying. I totally agree, especially on not assuming errors without even giving it a try. But in the end it's upstream who decides what the code looks like and which patch makes it into SVN. Without the patch the code was even more broken because (!err_ret) with (err_ret = ENOSYS > 0) equals FALSE, thus gnc_int_link_or_make_backup() previously did (awfully broken) *not* return FALSE in this case. So at least the patch (the part related to copy_success) will result in gnc_int_link_or_make_backup() returning FALSE in case *both* link() and copy_file() didn't succeed. Hence the change is definitely enough gain to fix this bug. Regards Micha -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFItwlmWN0/4pnhQbQRAgDpAKCAc+CwV2r1fjjw7Xn5sMkeOhvqqgCdEX4P KOzOdJvhhiZ5R9+UxDzbdRI= =pAVz -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
