Michael writes:
> I beg to disagree because this bug seems to hit only some systems but not all.
> Of course I agree that this is bad if your system is hit, but with a lot of
> systm not being hit I do not consider this release critical. 

> Aynway, the best solution is to fix this, if it is fixable on the chrony
> side at all.

I'm working on a fix (or at least a workaround) in the initscript.  I'm
putting a subshell containing "sleep 5; kill `pidof chronyc'" in the
background just before launching chronyc.  This should prevent hangs due to
chronyc being unable to contact chronyd.  I intend to do likewise with the
netstat call as it has been reported to hang for minutes (unreproducible
here).

The new, as yet untested initscript is attached:

#! /bin/sh
#
# Written by Miquel van Smoorenburg <[EMAIL PROTECTED]>.
# Modified for Debian GNU/Linux by Ian Murdock <[EMAIL PROTECTED]>.
# Modified for Debian by Christoph Lameter <[EMAIL PROTECTED]>
# Modified for chrony by John Hasler <[EMAIL PROTECTED]> 1998-2008

### BEGIN INIT INFO
# Provides:          time-daemon
# Required-Start:    $local_fs
# Required-Stop:     $local_fs
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
# Short-Description:  Controls chronyd NTP time daemon
# Description:       Chronyd is the NTP time daemon in the Chrony package
#              
### END INIT INFO


PATH=/bin:/usr/bin:/sbin:/usr/sbin
DAEMON=/usr/sbin/chronyd
FLAGS="defaults"
NAME="chronyd"
DESC="time daemon"

putonline ()
{ # Do we have a default route?  If so put chronyd online.
    (sleep 5; kill `pidof netstat` 2> /dev/null) &
    if netstat -rn 2>/dev/null | grep UG | cut -f 1 -d ' ' | grep -q '0\.0\.0\.0'
    then
	KEY=$(awk '$1 ~ /^commandkey$/ { print $2; exit}' /etc/chrony/chrony.conf)
	PASSWORD=`awk '$1 ~ /^'$KEY'$/ {print $2; exit}' /etc/chrony/chrony.keys`
	# Make sure chronyc can't hang us up.
	(sleep 5; kill `pidof chronyc` 2> /dev/null) &
	/usr/bin/chronyc << EOF
password $PASSWORD
online
burst 5/10
quit
EOF
	touch /var/run/chrony-ppp-up
    fi
}

test -f $DAEMON || exit 0

case "$1" in
    start)
	start-stop-daemon --start --verbose --exec $DAEMON
	/bin/pidof $DAEMON > /dev/null || sleep 1  # Chronyd can take a few milliseconds to start.
	/bin/pidof $DAEMON > /dev/null || echo "$DAEMON failed to start." && exit 1
	putonline
	;;
    stop)
	start-stop-daemon --stop --verbose --oknodo --exec $DAEMON
	rm -f /var/run/chrony-ppp-up
	;;
    restart|force-reload)
	echo -n "Restarting $DESC: "
	start-stop-daemon --stop --quiet --exec $DAEMON
	sleep 1
	start-stop-daemon --start --quiet --exec $DAEMON -- -r
	/bin/pidof $DAEMON > /dev/null || sleep 1  # Chronyd can take a few milliseconds to start.
	/bin/pidof $DAEMON > /dev/null || echo "$DAEMON failed to restart." && exit 1
	putonline
	echo "$NAME."
	;;
    *)
	echo "Usage: /etc/init.d/chrony {start|stop|restart|force-reload}"
	exit 1
	;;
esac

exit 0
-- 
John Hasler 
[EMAIL PROTECTED]
Elmwood, WI USA

Reply via email to