Hi, On Wed, 2008-10-22 at 09:51:05 +0300, Guillem Jover wrote: > <http://git.hadrons.org/?p=debian/dpkg.git>
> The correct approach is the one in ood-abort, implementing what I > guess was meant to be done with onerr_abort. What's missing is > untangling onerr_abort being activated by the archives/packages > processing loop when too many errors happen. I've done that now and updated pu/ood-abort, and overall, the relevant changes from the branch are not that much code 6 files changed, 30 insertions(+), 7 deletions(-) from which 10 of the inserted lines are comments or blank lines. The main issue is the new string for translation. This code though should be way more robust against unrecoverable error conditions. I still need to review once more all onerr_abort uses, and test when onerr_abort is being activated due to too many processing errors. > The ood-unwind branch might imply less behaviour changes, but it's > not the correct solution long term, and some side effects might be > still there as the execution continues when it should not. I guess this branch can be reduced to just the cb1bdc7d commit (even also removing the fseek call), as the rest are just papering over the real problems and will not cover all situations anyway. On unrecoverable errors, it becomes a mess as the code tries to continue running even if it's not expecting to, but that's the behaviour that has been present since forever and people have been living with it, so it would be a slight improvement, which should at least fix the reported problem of the bogus update file. regards, guillem -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
