Your message dated Mon, 10 Nov 2008 12:17:07 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#505164: fixed in vorbisgain 0.36-3.1
has caused the Debian Bug report #505164,
regarding vorbisgain: Multiple vorbisgain processes may overwrite each other's
temporary files, causing data loss.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)
--
505164: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505164
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: vorbisgain
Version: 0.36-3
Severity: grave
Tags: patch
Vorbisgain writes updated tags to an Ogg file by first creating a
temporary file, "vorbisgain.tmp" in the same directory as the Ogg file,
writing the updated metadata to it, deleting the Ogg file, and renaming
"vorbisgain.tmp" to the the Ogg file's name.
When two or more vorbisgain processes operate on different files in the
same directory, this means that they try to use the same temporary file,
and do not "discover" this until they have deleted the Ogg files,
causing them to be lost.
For example, executing the following (with "DON'T_RUN" removed), to
achieve a speed-up on an SMP system, in a directory with many Ogg files,
will cause some of them to be lost and others to be renamed, even though
each vorbisgain run gets a different file on which to work:
$ find -iname '*.ogg' -print0 | xaDON'T_RUNrgs -0 -P 4 -n 1 vorbisgain -s -c
The attached patch to vorbis.c changes the temporary file naming scheme
to use the name of the Ogg file with ".vgain.tmp" appended.
-- System Information:
Debian Release: lenny/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)
Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages vorbisgain depends on:
ii libc6 2.7-15 GNU C Library: Shared
libraries
ii libogg0 1.1.3-4 Ogg Bitstream Library
ii libvorbis0a 1.2.0.dfsg-3.1 The Vorbis General Audio
Compressi
ii libvorbisfile3 1.2.0.dfsg-3.1 The Vorbis General Audio
Compressi
vorbisgain recommends no packages.
vorbisgain suggests no packages.
-- no debconf information
59c59
< #define TEMP_NAME "vorbisgain.tmp"
---
> #define TEMP_EXT ".vgain.tmp"
687,689c687,688
< /* Make sure temp is in same folder as file. And yes, the malloc is larger
< * than necessary (and not always needed). Lets keep it simple though (at
< * the expense of a few bytes)...
---
> /* Construct a temporary file name by appending TEMP_EXT to
> * the name of the file being modified.
691c690
< temp_name = malloc(strlen(filename) + sizeof(TEMP_NAME));
---
> temp_name = malloc(strlen(filename) + sizeof(TEMP_EXT));
700c699
< strcpy((char *) last_path(temp_name), TEMP_NAME);
---
> strcat(temp_name, TEMP_EXT);
810c809
< if (remove(TEMP_NAME) != 0)
---
> if (remove(temp_name) != 0)
813c812
< TEMP_NAME);
---
> temp_name);
--- End Message ---
--- Begin Message ---
Source: vorbisgain
Source-Version: 0.36-3.1
We believe that the bug you reported is fixed in the latest version of
vorbisgain, which is due to be installed in the Debian FTP archive:
vorbisgain_0.36-3.1.diff.gz
to pool/main/v/vorbisgain/vorbisgain_0.36-3.1.diff.gz
vorbisgain_0.36-3.1.dsc
to pool/main/v/vorbisgain/vorbisgain_0.36-3.1.dsc
vorbisgain_0.36-3.1_i386.deb
to pool/main/v/vorbisgain/vorbisgain_0.36-3.1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Patrick Schoenfeld <[EMAIL PROTECTED]> (supplier of updated vorbisgain package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 10 Nov 2008 12:55:38 +0100
Source: vorbisgain
Binary: vorbisgain
Architecture: source i386
Version: 0.36-3.1
Distribution: unstable
Urgency: low
Maintainer: Joe Wreschnig <[EMAIL PROTECTED]>
Changed-By: Patrick Schoenfeld <[EMAIL PROTECTED]>
Description:
vorbisgain - add Replay Gain volume tags to Ogg Vorbis files
Closes: 505164
Changes:
vorbisgain (0.36-3.1) unstable; urgency=low
.
* Non-maintainer upload.
* Apply patch from Pavel N. Krivitsky to use temp files, which are dependent
on the file which is beeing processed, instead always using the same
filename, which can result to data loss in scenarios where two or more
vorbis processes are running parallel.
(Closes: #505164)
Checksums-Sha1:
f3b21d6467c4358492608ec6a19644a5c891596f 1000 vorbisgain_0.36-3.1.dsc
97aa8051ce8c1fbf51a4de0a4b3246eed0a61914 26919 vorbisgain_0.36-3.1.diff.gz
e5e80af925df95f11ceffd11028cbccbbff3680c 26404 vorbisgain_0.36-3.1_i386.deb
Checksums-Sha256:
5383fd64bfab2349637008e31debecb7965d1613911ae2f6d65db3854ba94610 1000
vorbisgain_0.36-3.1.dsc
f5ce182d7ae3b0ff2e122aca3a636466b9acb9cf7be1dd87fddbb59c644339de 26919
vorbisgain_0.36-3.1.diff.gz
b95b09393eb9d6fa71e6c7c90f23d30486b770305b74cd20739537ffc4bc4bbc 26404
vorbisgain_0.36-3.1_i386.deb
Files:
595028b89a4758fcb42e47086c58650e 1000 sound optional vorbisgain_0.36-3.1.dsc
d61c105578b13931ef45184aa0a7b8ae 26919 sound optional
vorbisgain_0.36-3.1.diff.gz
0a978d7b145c180c389eed6f0863bb4e 26404 sound optional
vorbisgain_0.36-3.1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkkYIlgACgkQbdB4RPTVespn/ACfbj0naq5NHcBTgfxMHnI9ZWJP
vV8Anjxe7qFfQ60c/h/5lfwwmSkzwBwP
=Sz8c
-----END PGP SIGNATURE-----
--- End Message ---
