Bug#509288: gnomad2: diff for NMU version 2.9.1-1.1

[Stefano Zacchiroli]

Dear maintainer,

I've prepared an NMU for gnomad2 (versioned as 2.9.1-1.1) and uploaded
it to unstable without any delay. Rationale: it fixes an RC bug
relevant for the Lenny release.

The main change is the application of Steve's patch to fix a segfault
due to a double free. Other trivial changes fix outstanding lintian
errors / warning.

Regards.

-- 
Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7
z...@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/
Dietro un grande uomo c'è ..|  .  |. Et ne m'en veux pas si je te tutoie
sempre uno zaino ...........| ..: |.... Je dis tu à tous ceux que j'aime

diff -u gnomad2-2.9.1/debian/control gnomad2-2.9.1/debian/control
--- gnomad2-2.9.1/debian/control
+++ gnomad2-2.9.1/debian/control
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Manuel Garcia <mann...@gmail.com>
 Build-Depends: libgnomeui-dev, libnjb-dev (>> 2.2), libid3tag0-dev, libxml-parser-perl, debhelper (>= 4), libmtp-dev (>= 0.2.2), libtagc0-dev, libtag1-dev
-Standards-Version: 3.7.2
+Standards-Version: 3.8.0
 
 Package: gnomad2
 Architecture: any
diff -u gnomad2-2.9.1/debian/changelog gnomad2-2.9.1/debian/changelog
--- gnomad2-2.9.1/debian/changelog
+++ gnomad2-2.9.1/debian/changelog
@@ -1,3 +1,15 @@
+gnomad2 (2.9.1-1.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * fix segfault due to missing Vorbis comment headers (double free).
+    Thanks to Steve Kemp for the patch (Closes: #509288)
+  * debian/changelog: fix syntax error ("urgiency" typo in past entry)
+  * gnomad2.desktop{,.in}: get rid of deprecated "Encoding" key
+    (file is UTF-8 safe)
+  * debian/control: bump Standards-Version, no changes needed
+
+ -- Stefano Zacchiroli <z...@debian.org>  Fri, 26 Dec 2008 09:53:11 +0100
+
 gnomad2 (2.9.1-1) unstable; urgency=low
 
   * New upstream release. Closes: #446812.
@@ -37,7 +49,7 @@
  
  -- Manuel Garcia <mann...@gmail.com>  Thu, 15 Feb 2007 13:35:56 -0400
 
-gnomad2 (2.8.8-1.1) unstable; uirgency=medium
+gnomad2 (2.8.8-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
   * Use $(CURDIR) instead of $(PWD) in debian/rules (closes: #390390).
only in patch2:
unchanged:
--- gnomad2-2.9.1.orig/gnomad2.desktop
+++ gnomad2-2.9.1/gnomad2.desktop
@@ -38,4 +38,3 @@
 Type=Application
 Icon=gnomad2-logo.png
 Categories=Application;AudioVideo;
-Encoding=UTF-8
only in patch2:
unchanged:
--- gnomad2-2.9.1.orig/gnomad2.desktop.in
+++ gnomad2-2.9.1/gnomad2.desktop.in
@@ -7,4 +7,3 @@
 Type=Application
 Icon=gnomad2-logo.png
 Categories=Application;AudioVideo;
-Encoding=UTF-8
only in patch2:
unchanged:
--- gnomad2-2.9.1.orig/src/tagfile.c
+++ gnomad2-2.9.1/src/tagfile.c
@@ -59,9 +59,15 @@
     g_free(tmppath);
     return;      
   }
-  g_free(tmppath);
   
   tag = taglib_file_tag(file);
+  if ( tag == NULL ) {
+    g_printf("tags were null in file %s", tmppath);
+    g_free(tmppath);
+    return;
+  }
+  g_free(tmppath);
+
   properties = taglib_file_audioproperties(file);
   
   gchar* artist = taglib_tag_artist(tag);