On Mon, Dec 08, 2008 at 06:41:51PM -0500, Michael Gilbert wrote: > > This is not a patch that I'll accept, stylistically and in terms of intent. > > I'm working on fixing this in the way I earlier indicated it should be > > fixed.
> just trying to help. it works, and its automatic. but yes, it does > leave the screen unlocked during all of the upgrade (although, this > could probably be addressed by having xscreensaver communicate via > tempfiles that its upgrade is done). and it doesn't address the fact > that the user could manually lock the screen anyway. and it doesn't > address xlockmore or gnome-screensaver. so, i understand your choice, > but its an alternative approach that does work. > btw, what can i do to improve the style? - the release of the dpkg lock does not guarantee that the upgrade completed; any number of other packages could cause dpkg to exit before all of libpam-runtime's deps have been unpacked, leading to the same problem when the upgrade is continued. (this is an issue in https://bugs.launchpad.net/ubuntu/+source/pam/+bug/256238, a failure that involves dependencies on new symbols in libc6 rather than libpam0g - while that particular problem hasn't been reported in Debian yet, AFAICS it also applies to etch->lenny upgrades - calling set +e is ugly, and stylistically unnecessary; that block is equivalent to: while ! xscreensaver-command -restart; do : done - I have no idea why this loop is here, anyway. Why would the -restart command ever fail? - spawning persistent subshells from a maintainer script that are left running until the postinst is *very* ugly; I'm not sure if this works at all, really, but if it does it probably has subtle and nasty side-effects. - The script, as written, also doesn't take into account the need to check for multiple instances of xscreensaver running on multiple displays. - Also, the -deactivate command will not unlock a screen that has been locked; so any screen that manages to be locked (perhaps by a direct user action) would still end up locking the user out. But as I said, I don't think this is the way we should solve this anyway. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org -- To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
