Your message dated Fri, 15 Jul 2005 06:32:21 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#287960: fixed in putty 0.58-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 31 Dec 2004 08:13:49 +0000
>From [EMAIL PROTECTED] Fri Dec 31 00:13:49 2004
Return-path: <[EMAIL PROTECTED]>
Received: from c187183.adsl.hansenet.de (localhost.localdomain)
[213.39.187.183]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CkHur-0007T4-00; Fri, 31 Dec 2004 00:13:46 -0800
Received: from aj by localhost.localdomain with local (Exim 4.34)
id 1CkHzr-0007TS-UK; Fri, 31 Dec 2004 09:18:55 +0100
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
From: Andreas Jochens <[EMAIL PROTECTED]>
Subject: putty: FTBFS (amd64/gcc-4.0): pointer targets in passing argument 2 of
'hmacmd5_key' differ in signedness
Message-Id: <[EMAIL PROTECTED]>
Date: Fri, 31 Dec 2004 09:18:55 +0100
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Package: putty
Severity: normal
Tags: patch
When building 'putty' on amd64 with gcc-4.0,
I get the following error:
cc -O2 -Wall -Werror -g -I.././ -I../charset/ -I../unix/ -I../mac/
`gtk-config --cflags` -c .././cproxy.c
cc1: warnings being treated as errors
.././cproxy.c: In function 'hmacmd5_chap':
.././cproxy.c:32: warning: pointer targets in passing argument 2 of
'hmacmd5_key' differ in signedness
.././cproxy.c: In function 'proxy_socks5_handlechap':
.././cproxy.c:134: warning: pointer targets in passing argument 2 of
'(*p->sub_socket)->write' differ in signedness
make[1]: *** [cproxy.o] Error 1
make[1]: Leaving directory `/putty-0.56/unix'
make: *** [build] Error 2
The attached patch fixes the 'signedness' warnings for gcc-4.0.
Regards
Andreas Jochens
diff -urN ../tmp-orig/putty-0.56/cmdgen.c ./cmdgen.c
--- ../tmp-orig/putty-0.56/cmdgen.c 2004-08-01 14:07:11.000000000 +0200
+++ ./cmdgen.c 2004-12-31 09:02:55.318900624 +0100
@@ -232,7 +232,7 @@
int i;
MD5Init(&md5c);
- MD5Update(&md5c, blob, bloblen);
+ MD5Update(&md5c, (unsigned char*)blob, bloblen);
MD5Final(digest, &md5c);
sprintf(buffer, "%s ", alg);
@@ -685,11 +685,11 @@
ssh1key = snew(struct RSAKey);
if (!load_encrypted) {
void *vblob;
- char *blob;
+ unsigned char *blob;
int n, l, bloblen;
ret = rsakey_pubblob(&infilename, &vblob, &bloblen, &error);
- blob = (char *)vblob;
+ blob = (unsigned char *)vblob;
n = 4; /* skip modulus bits */
@@ -872,7 +872,7 @@
} else if (outtype == PUBLIC) {
if (!ssh2blob) {
assert(ssh2key);
- ssh2blob = ssh2key->alg->public_blob(ssh2key->data,
+ ssh2blob = (char*) ssh2key->alg->public_blob(ssh2key->data,
&ssh2bloblen);
}
save_ssh2_pubkey(outfile, ssh2key ? ssh2key->comment : origcomment,
@@ -884,7 +884,7 @@
if (!ssh2blob) {
assert(ssh2key);
- ssh2blob = ssh2key->alg->public_blob(ssh2key->data,
+ ssh2blob = (char*) ssh2key->alg->public_blob(ssh2key->data,
&ssh2bloblen);
}
if (!ssh2alg) {
@@ -905,7 +905,7 @@
i = 0;
while (i < ssh2bloblen) {
int n = (ssh2bloblen - i < 3 ? ssh2bloblen - i : 3);
- base64_encode_atom(ssh2blob + i, n, p);
+ base64_encode_atom((unsigned char*)ssh2blob + i, n, p);
i += n;
p += 4;
}
diff -urN ../tmp-orig/putty-0.56/cproxy.c ./cproxy.c
--- ../tmp-orig/putty-0.56/cproxy.c 2004-08-30 15:11:17.000000000 +0200
+++ ./cproxy.c 2004-12-31 08:42:02.515355712 +0100
@@ -29,7 +29,7 @@
MD5Simple(passwd, pwlen, md5buf);
hmacmd5_key(hmacmd5_ctx, md5buf, 16);
} else {
- hmacmd5_key(hmacmd5_ctx, passwd, pwlen);
+ hmacmd5_key(hmacmd5_ctx, (const unsigned char*)passwd, pwlen);
}
hmacmd5_do_hmac(hmacmd5_ctx, challenge, challen, response);
@@ -131,7 +131,7 @@
outbuf[3] = 0x10; /* Length */
hmacmd5_chap(data, p->chap_current_datalen,
p->cfg.proxy_password, &outbuf[4]);
- sk_write(p->sub_socket, outbuf, 20);
+ sk_write(p->sub_socket, (char*)outbuf, 20);
break;
case 0x11:
/* Chose a protocol */
diff -urN ../tmp-orig/putty-0.56/unix/gtkdlg.c ./unix/gtkdlg.c
--- ../tmp-orig/putty-0.56/unix/gtkdlg.c 2004-08-30 15:23:23.000000000
+0200
+++ ./unix/gtkdlg.c 2004-12-31 08:54:35.909822344 +0100
@@ -2605,7 +2605,7 @@
struct eventlog_stuff *es = (struct eventlog_stuff *)data;
gtk_selection_data_set(seldata, seldata->target, 8,
- es->seldata, es->sellen);
+ (unsigned char*)es->seldata, es->sellen);
}
gint eventlog_selection_clear(GtkWidget *widget, GdkEventSelection *seldata,
diff -urN ../tmp-orig/putty-0.56/unix/pterm.c ./unix/pterm.c
--- ../tmp-orig/putty-0.56/unix/pterm.c 2004-10-24 15:31:55.000000000 +0200
+++ ./unix/pterm.c 2004-12-31 08:59:16.862111104 +0100
@@ -1357,21 +1357,21 @@
void init_cutbuffers()
{
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER0, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER0, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER1, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER1, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER2, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER2, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER3, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER3, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER4, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER4, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER5, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER5, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER6, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER6, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
XChangeProperty(GDK_DISPLAY(), GDK_ROOT_WINDOW(),
- XA_CUT_BUFFER7, XA_STRING, 8, PropModeAppend, "", 0);
+ XA_CUT_BUFFER7, XA_STRING, 8, PropModeAppend, (unsigned
char*)"", 0);
}
/* Store the data in a cut-buffer. */
@@ -1491,15 +1491,15 @@
struct gui_data *inst = (struct gui_data *)data;
if (seldata->target == utf8_string_atom)
gtk_selection_data_set(seldata, seldata->target, 8,
- inst->pasteout_data_utf8,
+ (unsigned char*)inst->pasteout_data_utf8,
inst->pasteout_data_utf8_len);
else if (seldata->target == compound_text_atom)
gtk_selection_data_set(seldata, seldata->target, 8,
- inst->pasteout_data_ctext,
+ (unsigned char*)inst->pasteout_data_ctext,
inst->pasteout_data_ctext_len);
else
gtk_selection_data_set(seldata, seldata->target, 8,
- inst->pasteout_data, inst->pasteout_data_len);
+ (unsigned char*)inst->pasteout_data,
inst->pasteout_data_len);
}
gint selection_clear(GtkWidget *widget, GdkEventSelection *seldata,
@@ -2353,7 +2353,8 @@
cfg->line_codepage[sizeof(cfg->line_codepage)-1] = '\0';
} else if (!strcmp(p, "-geometry")) {
- int flags, x, y, w, h;
+ int flags, x, y;
+ unsigned w, h;
EXPECTS_ARG;
SECOND_PASS_ONLY;
---------------------------------------
Received: (at 287960-close) by bugs.debian.org; 15 Jul 2005 10:41:31 +0000
>From [EMAIL PROTECTED] Fri Jul 15 03:41:31 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DtNdL-000827-00; Fri, 15 Jul 2005 03:41:31 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DtNUT-0001A8-00; Fri, 15 Jul 2005 06:32:21 -0400
From: Colin Watson <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#287960: fixed in putty 0.58-2
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Fri, 15 Jul 2005 06:32:21 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: putty
Source-Version: 0.58-2
We believe that the bug you reported is fixed in the latest version of
putty, which is due to be installed in the Debian FTP archive:
pterm_0.58-2_powerpc.deb
to pool/main/p/putty/pterm_0.58-2_powerpc.deb
putty-tools_0.58-2_powerpc.deb
to pool/main/p/putty/putty-tools_0.58-2_powerpc.deb
putty_0.58-2.diff.gz
to pool/main/p/putty/putty_0.58-2.diff.gz
putty_0.58-2.dsc
to pool/main/p/putty/putty_0.58-2.dsc
putty_0.58-2_powerpc.deb
to pool/main/p/putty/putty_0.58-2_powerpc.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Colin Watson <[EMAIL PROTECTED]> (supplier of updated putty package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 15 Jul 2005 11:08:53 +0100
Source: putty
Binary: pterm putty-tools putty
Architecture: source powerpc
Version: 0.58-2
Distribution: unstable
Urgency: low
Maintainer: Colin Watson <[EMAIL PROTECTED]>
Changed-By: Colin Watson <[EMAIL PROTECTED]>
Description:
pterm - PuTTY terminal emulator
putty - Telnet/SSH client for X
putty-tools - command-line tools for SSH, SCP, and SFTP
Closes: 287960
Changes:
putty (0.58-2) unstable; urgency=low
.
* Fix warnings with gcc-4.0 (closes: #287960).
* Upgrade to debhelper compatibility level 4; level 2 is deprecated.
Files:
95c37949fa909da97cef37052992e1c5 602 net optional putty_0.58-2.dsc
eaa54d5ad239473c0b23f43742657cb8 9371 net optional putty_0.58-2.diff.gz
657495f03e97c65da0932eda2e03e92c 178612 x11 optional pterm_0.58-2_powerpc.deb
71680eb74b362f3b8e84efd423f5d674 297890 net optional putty_0.58-2_powerpc.deb
6cf8ff8a20a907cc73476920e82200ee 728498 net optional
putty-tools_0.58-2_powerpc.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFC14v89t0zAhD6TNERAo/zAJ4/aZOAxRxxLY2JJawrjEg7SO+TOACeNDDN
6fXcupD65jDwR17F6GcMYno=
=MyN6
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
