Your message dated Sun, 09 Aug 2009 18:17:39 +0000
with message-id <e1macxf-00027e...@ries.debian.org>
and subject line Bug#476339: fixed in libmikmod 3.1.11-6.1
has caused the Debian Bug report #476339,
regarding libmikmod2: segfaults when loading XM files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
476339: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=476339
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libmikmod2
Version: 3.1.11-a-6
Severity: important
Tags: patch
This patch avoids the segfault when a loading error happens and fixes
the loading of XM files.
diff -ur libmikmod-3.1.11.orig/loaders/load_xm.c libmikmod-3.1.11/loaders/load_xm.c
--- libmikmod-3.1.11.orig/loaders/load_xm.c 2004-01-21 18:43:53.000000000 +0100
+++ libmikmod-3.1.11/loaders/load_xm.c 2008-04-16 04:30:45.000000000 +0200
@@ -622,7 +622,8 @@
/* read the remainder of the header */
for(u=headend-_mm_ftell(modreader);u;u--) _mm_read_UBYTE(modreader);
- if(_mm_eof(modreader)) {
+ /* last instrument is at the end of file in version 0x0104 */
+ if(_mm_eof(modreader) && (mh->version<0x0104 || t<of.numins-1)) {
free(nextwav);free(wh);
nextwav=NULL;wh=NULL;
_mm_errno = MMERR_LOADING_SAMPLEINFO;
diff -ur libmikmod-3.1.11.orig/playercode/mloader.c libmikmod-3.1.11/playercode/mloader.c
--- libmikmod-3.1.11.orig/playercode/mloader.c 2004-01-21 18:43:53.000000000 +0100
+++ libmikmod-3.1.11/playercode/mloader.c 2008-04-16 04:30:45.000000000 +0200
@@ -450,10 +450,12 @@
if (!l->Init || l->Init()) {
_mm_rewind(modreader);
ok = l->Load(curious);
- /* propagate inflags=flags for in-module samples */
- for (t = 0; t < of.numsmp; t++)
- if (of.samples[t].inflags == 0)
- of.samples[t].inflags = of.samples[t].flags;
+ if (ok) {
+ /* propagate inflags=flags for in-module samples */
+ for (t = 0; t < of.numsmp; t++)
+ if (of.samples[t].inflags == 0)
+ of.samples[t].inflags = of.samples[t].flags;
+ }
} else
ok = 0;
--- End Message ---
--- Begin Message ---
Source: libmikmod
Source-Version: 3.1.11-6.1
We believe that the bug you reported is fixed in the latest version of
libmikmod, which is due to be installed in the Debian FTP archive:
libmikmod2-dev_3.1.11-a-6.1_amd64.deb
to pool/main/libm/libmikmod/libmikmod2-dev_3.1.11-a-6.1_amd64.deb
libmikmod2_3.1.11-a-6.1_amd64.deb
to pool/main/libm/libmikmod/libmikmod2_3.1.11-a-6.1_amd64.deb
libmikmod_3.1.11-6.1.diff.gz
to pool/main/libm/libmikmod/libmikmod_3.1.11-6.1.diff.gz
libmikmod_3.1.11-6.1.dsc
to pool/main/libm/libmikmod/libmikmod_3.1.11-6.1.dsc
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 476...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Giuseppe Iuculano <giuse...@iuculano.it> (supplier of updated libmikmod package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 05 Aug 2009 11:50:25 +0200
Source: libmikmod
Binary: libmikmod2-dev libmikmod2
Architecture: source amd64
Version: 3.1.11-6.1
Distribution: unstable
Urgency: high
Maintainer: Ingo Saitz <i...@debian.org>
Changed-By: Giuseppe Iuculano <giuse...@iuculano.it>
Description:
libmikmod2 - A portable sound library
libmikmod2-dev - A portable sound library - development files
Closes: 461519 476339
Changes:
libmikmod (3.1.11-6.1) unstable; urgency=high
.
* Non-maintainer upload.
* debian/patches/CVE-2007-6720.patch: Fixed application crash or abort when
loading/playing multiple music files with varying number of channels.
(CVE-2007-6720) (Closes: #461519)
* debian/patches/CVE-2009-0179.patch: Fixed application crash when loading XM
files. (CVE-2009-0179) (Closes: #476339)
Checksums-Sha1:
ddbc4e2401988174c0779bf921a2ed6f1baf74ff 1017 libmikmod_3.1.11-6.1.dsc
d15b768244d3bbbcbd6340e6d29877ea8a4afab1 336868 libmikmod_3.1.11-6.1.diff.gz
4cce0e6491ca5123c747e3edd38cbe0005caf034 262980
libmikmod2-dev_3.1.11-a-6.1_amd64.deb
afb266ec91821cffd37ad227f8c94bd03240c530 154574
libmikmod2_3.1.11-a-6.1_amd64.deb
Checksums-Sha256:
9321127347bd2ebf9429700cabe5945d7ecd77fc5cfdaf95f72c0fcb6d4d4eca 1017
libmikmod_3.1.11-6.1.dsc
440bd0ba9f53e3c24cec2038213d8a96f6636cb0f7be83f81de2ac024ee8cb10 336868
libmikmod_3.1.11-6.1.diff.gz
3eba29c2aa5aad6beb2ec1937c9c8aaadc9aa6cd8d47e234541d9d9d1cb8363b 262980
libmikmod2-dev_3.1.11-a-6.1_amd64.deb
b09a83d776ddea303ea244c22efb93aaab42f69aec6177b5d62676c129f8c9fc 154574
libmikmod2_3.1.11-a-6.1_amd64.deb
Files:
7a30b862ae1283c62ff156020679806d 1017 libs optional libmikmod_3.1.11-6.1.dsc
24558c996f0da36bc87c3ea565599059 336868 libs optional
libmikmod_3.1.11-6.1.diff.gz
94c9473e9fa05bef5988826bd1afeb9b 262980 libdevel optional
libmikmod2-dev_3.1.11-a-6.1_amd64.deb
849fa2f5fd54a012a2c00c2dc97c3c43 154574 libs optional
libmikmod2_3.1.11-a-6.1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkp/DZkACgkQHYflSXNkfP/HdACdF1/VP1BUGXzIwVP6VJIwh66H
MKUAn0nPyqUfZ9i7N7ULoEqNQ1xbLMD9
=Iu4S
-----END PGP SIGNATURE-----
--- End Message ---
