Your message dated Wed, 24 Feb 2010 16:47:36 +0000 with message-id <[email protected]> and subject line Bug#549929: fixed in netpbm-free 2:10.0-12.1 has caused the Debian Bug report #549929, regarding netpbm-free: getline conflicts with POSIX:2008 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 549929: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549929 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: netpbm-free Version: 2:10.0-12 Severity: important Tags: patch User: [email protected] Usertags: origin-ubuntu ubuntu-patch karmic The getline function used in a couple of places in netpbm-free is also defined by POSIX:2008, and so netpbm-free fails to build with newer versions of (e)glibc. Here's a patch to rename it. * Rename getline functions to get_line to avoid conflict with POSIX:2008. --- netpbm-free-10.0.orig/ppm/xvminitoppm.c +++ netpbm-free-10.0/ppm/xvminitoppm.c @@ -14,7 +14,7 @@ #include "ppm.h" #define BUFSIZE 256 -static void getline ARGS((FILE *fp, char *buf)); +static void get_line ARGS((FILE *fp, char *buf)); int main(argc, argv) @@ -48,18 +48,18 @@ i++; } - getline(ifp, buf); + get_line(ifp, buf); if( strncmp(buf, "P7 332", 6) != 0 ) pm_error("bad magic number - not a XV thumbnail picture"); while(1) { - getline(ifp, buf); + get_line(ifp, buf); if( strncmp(buf, "#END_OF_COMMENTS", 16)==0 ) break; if( strncmp(buf, "#BUILTIN", 8)==0 ) pm_error("cannot convert builtin XV thumbnail pictures"); } - getline(ifp, buf); + get_line(ifp, buf); if( sscanf(buf, "%d %d %d", &cols, &rows, &maxval) != 3 ) pm_error("error parsing dimension info"); if( maxval != 255 ) @@ -85,7 +85,7 @@ static void -getline(fp, buf) +get_line(fp, buf) FILE *fp; char *buf; { --- netpbm-free-10.0.orig/ppm/xpmtoppm.c +++ netpbm-free-10.0/ppm/xpmtoppm.c @@ -114,7 +114,7 @@ static void -getline(char * const line, int const size, FILE * const stream) { +get_line(char * const line, int const size, FILE * const stream) { /*---------------------------------------------------------------------------- Read the next line from the input file 'stream', through the one-line buffer lastInputLine[]. @@ -130,7 +130,7 @@ Exit program if the line doesn't fit in the buffer. -----------------------------------------------------------------------------*/ if (size > MAX_LINE+1) - pm_error("INTERNAL ERROR: getline() received 'size' parameter " + pm_error("INTERNAL ERROR: get_line() received 'size' parameter " "which is out of bounds"); if (backup) { @@ -346,7 +346,7 @@ int * const transparentP) { /*---------------------------------------------------------------------------- Read the header of the XPM file on stream 'stream'. Assume the - getline() stream is presently positioned to the beginning of the + get_line() stream is presently positioned to the beginning of the file and it is a Version 3 XPM file. Leave the stream positioned after the header. @@ -377,25 +377,25 @@ *widthP = *heightP = *ncolorsP = *chars_per_pixelP = -1; /* Read the XPM signature comment */ - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); if (strncmp(line, xpm3_signature, strlen(xpm3_signature)) != 0) pm_error("Apparent XPM 3 file does not start with '/* XPM */'. " "First line is '%s'", xpm3_signature); /* Read the assignment line */ - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); if (strncmp(line, "static char", 11) != 0) pm_error("Cannot find data structure declaration. Expected a " "line starting with 'static char', but found the line " "'%s'.", line); /* Read the hints line */ - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); /* skip the comment line if any */ if (!strncmp(line, "/*", 2)) { while (!strstr(line, "*/")) - getline(line, sizeof(line), stream); - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); } if (sscanf(line, "\"%d %d %d %d\",", widthP, heightP, ncolorsP, chars_per_pixelP) != 4) @@ -427,10 +427,10 @@ *transparentP = -1; /* initial value */ for (seqNum = 0; seqNum < *ncolorsP; seqNum++) { - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); /* skip the comment line if any */ if (!strncmp(line, "/*", 2)) - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); interpretXpm3ColorTableLine(line, seqNum, *chars_per_pixelP, *colorsP, *ptabP, transparentP); @@ -445,7 +445,7 @@ pixel ** const colorsP, int ** const ptabP) { /*---------------------------------------------------------------------------- Read the header of the XPM file on stream 'stream'. Assume the - getline() stream is presently positioned to the beginning of the + get_line() stream is presently positioned to the beginning of the file and it is a Version 1 XPM file. Leave the stream positioned after the header. @@ -464,7 +464,7 @@ /* Read the initial defines. */ processedStaticChar = FALSE; while (!processedStaticChar) { - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); if (sscanf(line, "#define %s %d", str1, &v) == 2) { char *t1; @@ -512,7 +512,7 @@ /* If there's a monochrome color table, skip it. */ if (!strncmp(t1, "mono", 4)) { for (;;) { - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); if (!strncmp(line, "static char", 11)) break; } @@ -533,7 +533,7 @@ /* Read color table. */ for (i = 0; i < *ncolorsP; ++i) { - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); if ((t1 = strchr(line, '"')) == NULL) pm_error("D error scanning color table"); @@ -569,7 +569,7 @@ "static char ..."). */ for (;;) { - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); if (strncmp(line, "static char", 11) == 0) break; } @@ -660,7 +660,7 @@ backup = FALSE; /* Read the header line */ - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); backup = TRUE; /* back up so next read reads this line again */ rc = sscanf(line, "/* %s */", str1); @@ -681,7 +681,7 @@ pm_error("Could not get %d bytes of memory for image", totalpixels); cursor = *dataP; maxcursor = *dataP + totalpixels - 1; - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); /* read next line (first line may not always start with comment) */ while (cursor <= maxcursor) { if (strncmp(line, "/*", 2) == 0) { @@ -691,7 +691,7 @@ ncolors, ptab, &cursor, maxcursor); } if (cursor <= maxcursor) - getline(line, sizeof(line), stream); + get_line(line, sizeof(line), stream); } if (ptab) free(ptab); } Thanks, -- Colin Watson [[email protected]]
--- End Message ---
--- Begin Message ---Source: netpbm-free Source-Version: 2:10.0-12.1 We believe that the bug you reported is fixed in the latest version of netpbm-free, which is due to be installed in the Debian FTP archive: libnetpbm10-dev_10.0-12.1_i386.deb to main/n/netpbm-free/libnetpbm10-dev_10.0-12.1_i386.deb libnetpbm10_10.0-12.1_i386.deb to main/n/netpbm-free/libnetpbm10_10.0-12.1_i386.deb libnetpbm9-dev_10.0-12.1_i386.deb to main/n/netpbm-free/libnetpbm9-dev_10.0-12.1_i386.deb libnetpbm9_10.0-12.1_i386.deb to main/n/netpbm-free/libnetpbm9_10.0-12.1_i386.deb netpbm-free_10.0-12.1.diff.gz to main/n/netpbm-free/netpbm-free_10.0-12.1.diff.gz netpbm-free_10.0-12.1.dsc to main/n/netpbm-free/netpbm-free_10.0-12.1.dsc netpbm_10.0-12.1_i386.deb to main/n/netpbm-free/netpbm_10.0-12.1_i386.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Jari Aalto <[email protected]> (supplier of updated netpbm-free package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Sat, 20 Feb 2010 19:47:46 +0200 Source: netpbm-free Binary: netpbm libnetpbm10 libnetpbm10-dev libnetpbm9 libnetpbm9-dev Architecture: source i386 Version: 2:10.0-12.1 Distribution: unstable Urgency: low Maintainer: Andreas Barth <[email protected]> Changed-By: Jari Aalto <[email protected]> Description: libnetpbm10 - Graphics conversion tools shared libraries libnetpbm10-dev - Graphics conversion tools development libraries and header files libnetpbm9 - Shared libraries for netpbm (v9) libnetpbm9-dev - Development libraries and header files (v9) netpbm - Graphics conversion tools between image formats Closes: 549929 Changes: netpbm-free (2:10.0-12.1) unstable; urgency=low . [Jari Aalto] * Non-maintainer upload. * debian/compat - update to 7. * debian/control + top level - (Standards-Version): update from 3.6.1.0 to 3.8.4 (W: lintian). - (Homepage): Move here (P: lintian). - (Vcs-*): Add new fields. + netpbm - (Build-Depends): update to debhelper 7 (W: lintian). - (Depends): change obsolete gs, gs-aladdin to ghostscript (E: lintian). Add ${misc:Depends} for debhelper (W: lintian). Use newer tag ${source:Version} (W: lintian). - (Section): Remove inherited field (I: lintian). + libnetpbm9 - Depends): Add ${misc:Depends} for debhelper (W: lintian). - (Description): Add 'v9' to make line unique (I: lintian). + libnetpbm9-dev - (Depends): Add ${misc:Depends} for debhelper' (W: lintian). Add ${binary:Version} (E: lintian). - (Description): Add 'v9' to make line unique (I: lintian). + libnetpbm10 - (Description): Improve first line (I: lintian). - (Depends): Add ${misc:Depends} for debhelper (W: lintian). Add ${binary:Version} (E: lintian). + libnetpbm10-dev - (Description): Improve first line (I: lintian). - (Depends): Add ${misc:Depends} for debhelper (W: lintian). * debian/copyright - Change to UTF-8 (W: lintian). * ppm/{xpmtoppm.c,xvminitoppm.c} - Fix Gcc 4.4 error: conflicting types for getline (FTBFS serious; Closes: #549929). Patch thanks to Colin Watson <[email protected]>. * ppm/ppmquantall - Change 'set' to 'declare' to fix "line 58: syntax error" (E: lintian; shell-script-fails-syntax-check). * debian/rules - (binary-arch): change dh_clean to dh_prep (E: lintian). Checksums-Sha1: 438e08806753c244abc70f849fe2b78f2bb1274c 1323 netpbm-free_10.0-12.1.dsc cedafde33234123f87244f4d2678fc06361fb084 53735 netpbm-free_10.0-12.1.diff.gz 69914561b355cb9c2192873d2422ca7bdc59c216 1237654 netpbm_10.0-12.1_i386.deb 6178cacf74cbb08b31c9621c0038d4222c031e90 66680 libnetpbm10_10.0-12.1_i386.deb 9651169edba12490a0f0c01b1293d9aff2c48adc 112756 libnetpbm10-dev_10.0-12.1_i386.deb 27bfa79b9394943342201dc1d2fe8c42356193ae 71992 libnetpbm9_10.0-12.1_i386.deb e68b8811b7a742510c4e30c4ceb61bca9be29972 112822 libnetpbm9-dev_10.0-12.1_i386.deb Checksums-Sha256: 27a33902b4da63d938308d60ee3c701cf55bd144d1e94a7857af3adf1dc9898f 1323 netpbm-free_10.0-12.1.dsc afa11deb35fb81855a1edf927af9d9571f4ecd071d7edbd9e807dd862661c1a4 53735 netpbm-free_10.0-12.1.diff.gz 6e2139cee3a2eccc27dd9aefa449f7cb08f584ac93bc690f125ff2184169b8f7 1237654 netpbm_10.0-12.1_i386.deb a6446c1022cbec42d754f8bcd5e201b911c22bdfc0a617c31b1e01f3e8968b41 66680 libnetpbm10_10.0-12.1_i386.deb fdff18d0394f4b23d1482f6f0ed185b3e515c9dbb57d84f7495d154c239df0f0 112756 libnetpbm10-dev_10.0-12.1_i386.deb 9a488b12d1ffa10964e832bf746ab24ce3e152ee3d5f40fa093269e548c64fcb 71992 libnetpbm9_10.0-12.1_i386.deb 91962882a2fd6f268e4bb0f3ea9de647a0c025558d72bf7bb7d2a5f0a0f5dff2 112822 libnetpbm9-dev_10.0-12.1_i386.deb Files: ece979d80497b05163419710224ae8ef 1323 graphics optional netpbm-free_10.0-12.1.dsc e166553c2e8acc1f3c2b60b5d75f39a5 53735 graphics optional netpbm-free_10.0-12.1.diff.gz 3a5c6b3a94d29a71e50c43b8fe274fe3 1237654 graphics optional netpbm_10.0-12.1_i386.deb 6e7a81923c5c0a9829d454eb9034978e 66680 libs optional libnetpbm10_10.0-12.1_i386.deb ee50888f0f7dc9d10ef24b79bf081322 112756 libdevel optional libnetpbm10-dev_10.0-12.1_i386.deb e01ed47ad8af47572be067407c0e51f6 71992 libs optional libnetpbm9_10.0-12.1_i386.deb 64d42d816f3ee8c99e5dc96d3a8b5657 112822 libdevel optional libnetpbm9-dev_10.0-12.1_i386.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkuBX88ACgkQpdwBkPlyvgMSxACfRy/GDPNkvUdO4FtpclsheXwp jJcAnjRuL+LPdaLO+66ap2Q93LP6nSPn =3iJ6 -----END PGP SIGNATURE-----
--- End Message ---
