Evgeni Golov <evg...@debian.org> writes:

> You are using dpatch without having dpatch as build-depend.
> When you have dpatch as b-d, why not use /usr/share/dpatch/dpatch.make 
> and it's magic targets?

Ah, I didn't know that.  Thanks for the tip.

> *However* I'd not use dpatch at all here.
> Maintainer already has direct changes to files in his .diff.gz 
> (lib/diakonos.rb and lib/diakonos/help.rb) and I think forcing him to 
> some patch system he is not (yet) using is the wrong way *here* (don't 
> understand me wrong, I'm all for patch systems [even if I prefer quilt 
> over dpatch] but here we are not the maintainer and should adapt his 
> workflow).

Yes, I used dpatch just to make it clear that the shebang change is
Debian specific.  I have no strong opinion on whether/which patch
systems are used here.

> PS: if you want, i can upload the patch/NMU after you fixed the point(s) 
> above :)

Thanks, but not really for now.  I also think that it would be
definitely better for the bug to be fixed by the maintainer :-)

Regards,
-- 
Daiki Ueno



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to