Hi Gregor,
I reviewed your patch and I think it does not solve completely the
problem.

When you are in a chroot environment, /proc/mounts show all mounts on
all chroot, so you cannot know for sure if the one you found (and you
may found more than one) is yours.

Just to make and example, when I use schroot to get into a chroot
environment, I have /home mounted inside the chroot. If I look for /home
in /proc/mounts, I get:

giuse...@scarafaggio:~$ sudo schroot -c lenny-backports
scarafaggio:/home/giuseppe# grep home /proc/mounts
/dev/mapper/VG500G-homelv /home ext4 
rw,nosuid,nodev,relatime,user_xattr,acl,commit=600,barrier=1,data=ordered 0 0
/dev/mapper/VG500G-homelv /home ext4 
rw,nosuid,nodev,relatime,user_xattr,acl,commit=600,barrier=1,data=ordered 0 0
scarafaggio:/home/giuseppe# logout
giuse...@scarafaggio:~$ grep home /proc/mounts
/dev/mapper/VG500G-homelv /home ext4 
rw,nosuid,nodev,relatime,user_xattr,acl,commit=600,barrier=1,data=ordered 0 0

and I cannot find what is my current /home. I cannot even know *if* I
have /home as a mounted file system.

/etc/mtab only contains mounted volumes in current system (or chroot),
so using it does solve the problem.

Back to fixing this bug. Probably, I would suggest, when /etc/mtab is
missing, to assume that $SPOOL/etc is not mounted with bind option.

What is your opinion about this?

Thanks,
Giuseppe




-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to