Your message dated Tue, 07 Dec 2010 17:02:31 +0000
with message-id <e1pq0vv-0002ei...@franck.debian.org>
and subject line Bug#605939: fixed in schroot 1.4.16-1
has caused the Debian Bug report #605939,
regarding Regression: Chroots with periods in the name no longer work.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
605939: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=605939
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: schroot
Version: 1.4.14-1
Severity: important
Tags: patch


As of schroot commit 8c1c93708397bc08519a9415da96fbdd9e26315e
(released with version 1.4.9), chroots with periods in their name no
longer work.

I personally find chroot names with dots useful, since I keep chroots
around as build/test environments for different versions of various
pieces of software, and I name them after the software version
(x.y.z).

I've attached a patch which adds '.' back in to is_valid_sessionname.

-- System Information:
Debian Release: 5.0.6
  APT prefers stable
  APT policy: (700, 'stable'), (400, 'testing'), (300, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages schroot depends on:
ii  libboost-filesystem1.42.0 1.42.0-4       filesystem operations (portable pa
ii  libboost-program-options1 1.42.0-4       program options library for C++
ii  libboost-regex1.42.0      1.42.0-4       regular expression library for C++
ii  libboost-system1.42.0     1.42.0-4       Operating system (e.g. diagnostics
ii  libc6                     2.7-18lenny6   GNU C Library: Shared libraries
ii  libgcc1                   1:4.3.2-1.1    GCC support library
ii  liblockdev1               1.0.3-1.2+b1   Run-time shared library for lockin
ii  libpam0g                  1.0.1-5+lenny1 Pluggable Authentication Modules l
ii  libstdc++6                4.4.5-4        The GNU Standard C++ Library v3
ii  libuuid1                  2.17.2-3.3     Universally Unique ID library
ii  schroot-common            1.4.14-1       common files for schroot

schroot recommends no packages.

Versions of packages schroot suggests:
ii  aufs-modules- 2.6.26+0+20080719-6+lenny3 Stackable unification filesystem f
pn  btrfs-tools   <none>                     (no description available)
ii  debootstrap   1.0.10lenny1               Bootstrap a basic Debian system
ii  lvm2          2.02.39-8                  The Linux Logical Volume Manager
ii  unzip         5.52-12                    De-archiver for .zip files

-- no debconf information

*** /tmp/0001-Make-is_valid_session_name-accept-names-with-periods.patch
>From ab1d3e2947c1cbda3f7656db3d4b35c1f9a8bd7d Mon Sep 17 00:00:00 2001
From: Nelson Elhage <nelh...@ksplice.com>
Date: Sat, 4 Dec 2010 15:13:40 -0500
Subject: [PATCH] Make is_valid_session_name accept names with periods in them.

In particular, is_valid_filename allows periods in chroot names, and such chroot
names used to work. Update is_valid_session_name so that they continue working.
---
 sbuild/sbuild-util.cc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sbuild/sbuild-util.cc b/sbuild/sbuild-util.cc
index add970c..32e2ec8 100644
--- a/sbuild/sbuild-util.cc
+++ b/sbuild/sbuild-util.cc
@@ -174,7 +174,7 @@ sbuild::is_valid_sessionname (std::string const& name)
 {
   bool match = false;
 
-  static regex file_namespace("^[a-zA-Z0-9][a-zA-Z0-9_-]*$");
+  static regex file_namespace("^[a-zA-Z0-9.][a-zA-Z0-9_.-]*$");
 
   if (regex_search(name, file_namespace)) {
     match = true;
-- 
1.7.1.31.g6297e



--- End Message ---
--- Begin Message ---
Source: schroot
Source-Version: 1.4.16-1

We believe that the bug you reported is fixed in the latest version of
schroot, which is due to be installed in the Debian FTP archive:

dchroot-dsa_1.4.16-1_amd64.deb
  to main/s/schroot/dchroot-dsa_1.4.16-1_amd64.deb
dchroot_1.4.16-1_amd64.deb
  to main/s/schroot/dchroot_1.4.16-1_amd64.deb
libsbuild-dev_1.4.16-1_amd64.deb
  to main/s/schroot/libsbuild-dev_1.4.16-1_amd64.deb
libsbuild-doc_1.4.16-1_all.deb
  to main/s/schroot/libsbuild-doc_1.4.16-1_all.deb
schroot-common_1.4.16-1_all.deb
  to main/s/schroot/schroot-common_1.4.16-1_all.deb
schroot-dbg_1.4.16-1_amd64.deb
  to main/s/schroot/schroot-dbg_1.4.16-1_amd64.deb
schroot_1.4.16-1.debian.tar.gz
  to main/s/schroot/schroot_1.4.16-1.debian.tar.gz
schroot_1.4.16-1.dsc
  to main/s/schroot/schroot_1.4.16-1.dsc
schroot_1.4.16-1_amd64.deb
  to main/s/schroot/schroot_1.4.16-1_amd64.deb
schroot_1.4.16.orig.tar.bz2
  to main/s/schroot/schroot_1.4.16.orig.tar.bz2



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 605...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Roger Leigh <rle...@debian.org> (supplier of updated schroot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

Format: 1.8
Date: Tue, 07 Dec 2010 12:29:25 +0000
Source: schroot
Binary: schroot-common libsbuild-dev schroot-dbg libsbuild-doc schroot dchroot 
dchroot-dsa
Architecture: source all amd64
Version: 1.4.16-1
Distribution: unstable
Urgency: low
Maintainer: Debian buildd-tools Developers 
<buildd-tools-de...@lists.alioth.debian.org>
Changed-By: Roger Leigh <rle...@debian.org>
Description: 
 dchroot    - Execute commands in a chroot environment
 dchroot-dsa - Execute commands in a chroot environment
 libsbuild-dev - development files for the Debian source builder
 libsbuild-doc - development documentation for the Debian source builder
 schroot    - Execute commands in a chroot environment
 schroot-common - common files for schroot
 schroot-dbg - schroot, dchroot and dchroot-dsa debuggging symbols
Closes: 587758 599380 601043 605939 605950 606162
Changes: 
 schroot (1.4.16-1) unstable; urgency=low
 .
   * New upstream stable release.
   * Document schroot -- option delimiter in schroot(1)
     (Closes: #599380).
   * Document security implications of bind-mounting /dev and other
     filesystems in schroot.conf(5) (Closes: #587758).
   * Relax chroot naming restrictions (Closes: #601043, #605939).  The
     name may not contain a leading period (‘.’).  The  characters ‘:’
     (colon), ‘,’ (comma) and ‘/’ (forward slash) are not permitted
     anywhere in the name.  The name may also not contain a trailing
     tilde ('~').  Otherwise any characters are permitted.
   * 10mount: Respect mount options from configuration for all mountable
     chroot types (Closes: #605950).  Thanks to Nelson Elhage for this
     patch.
   * 15killprocs: Improve performance by omitting a readlink call for
     each process running on the system, leading to a significant
     reduction in overhead on busy systems (Closes: #606162).  Thanks
     to Anders Kaseorg for this patch.
Checksums-Sha1: 
 8d3bc19569581f578bd80e18253c1a4abe8761f3 1578 schroot_1.4.16-1.dsc
 652e47d1794dc8f718288793e1deb463c2c1d587 770155 schroot_1.4.16.orig.tar.bz2
 10b82ad5a32c577780f0a3dcc1884e1cb727b274 22556 schroot_1.4.16-1.debian.tar.gz
 b1410607a6bc5f8347196c46bc915fee2962fe2a 247042 schroot-common_1.4.16-1_all.deb
 8aca9182c2cc46c51ba230146b6226d188c4ad8a 7233852 libsbuild-doc_1.4.16-1_all.deb
 f6f1e1e14abbe7a3b1b1b9a462e0456d7e4b97cd 1852242 
libsbuild-dev_1.4.16-1_amd64.deb
 314df7dbeb5f6c7482408a7ecac384e98d39f00a 16470210 
schroot-dbg_1.4.16-1_amd64.deb
 89db22cb2737166597fd18d8f6db67a5ab77f1de 914414 schroot_1.4.16-1_amd64.deb
 f862a78e803e2d4e35f75fb6187383f7a8a47685 402440 dchroot_1.4.16-1_amd64.deb
 f980dbe8a1a26268923176cd8b5a9a0a3f0a16c9 402270 dchroot-dsa_1.4.16-1_amd64.deb
Checksums-Sha256: 
 0eb4e0c7a6723736c170335068dc5436df8bd7d5e7adaa3b8f9a5af23f06c191 1578 
schroot_1.4.16-1.dsc
 76a9971bdf09de90e312dba13f7491c7d67cb06bb9e282509174e56e1064b6b8 770155 
schroot_1.4.16.orig.tar.bz2
 c8fae2bd46ab2d91120048a297dd353b86a2fb79a95151755758f98f7d9264d6 22556 
schroot_1.4.16-1.debian.tar.gz
 c27c388808b4add86121029bb629f3de454f15ee883ba8f0bd5636e7816990b8 247042 
schroot-common_1.4.16-1_all.deb
 9040439c3a40b09c18468c3a47407f2355eb85f20348460f210cf998e8f39283 7233852 
libsbuild-doc_1.4.16-1_all.deb
 927e8f020871c8a18d71c5cde7f7535206deba7cb0824b002c8461ff3515c4b1 1852242 
libsbuild-dev_1.4.16-1_amd64.deb
 82c0588139935361025313ef47a033768c4b0c4014a4d233fe9ebcec1bcb2d69 16470210 
schroot-dbg_1.4.16-1_amd64.deb
 aa280af515a5bfef00f33ebbe656ddf33e22edda5d111d3e027c7aa9f2ac0a9b 914414 
schroot_1.4.16-1_amd64.deb
 af88b9b0f33915faf366066bce58bc0e587a07f1a245b1000fc96f27c0844c4c 402440 
dchroot_1.4.16-1_amd64.deb
 8e5aa314c1b86ca346f27bc68cd55db7d60bb975502c99542128a283708d5005 402270 
dchroot-dsa_1.4.16-1_amd64.deb
Files: 
 8aecd3ea32cc3eb68ee09e1c9f492a68 1578 admin optional schroot_1.4.16-1.dsc
 ec8df081e3cb7c35cb1f33d422cb7c09 770155 admin optional 
schroot_1.4.16.orig.tar.bz2
 aa3f93572f953e98a9b044f06bfeac48 22556 admin optional 
schroot_1.4.16-1.debian.tar.gz
 87020e025f9b78ed3ecd04b9a00a4471 247042 admin optional 
schroot-common_1.4.16-1_all.deb
 16c328ad23c2634101dc94b04b750e56 7233852 doc optional 
libsbuild-doc_1.4.16-1_all.deb
 ed9470ea5c97066d201f92272547676f 1852242 libdevel optional 
libsbuild-dev_1.4.16-1_amd64.deb
 3b3c851db6a9dd25d9985fb73df02a4c 16470210 debug extra 
schroot-dbg_1.4.16-1_amd64.deb
 33074f1fc2d7eb3e0b9601460439e60f 914414 admin optional 
schroot_1.4.16-1_amd64.deb
 f789da2115b68e397b3c5c583dfaef04 402440 admin optional 
dchroot_1.4.16-1_amd64.deb
 252c1cd3e630aa2956fb4b76133daf87 402270 admin optional 
dchroot-dsa_1.4.16-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEAREDAAYFAkz+ZaQACgkQVcFcaSW/uEgZfgCfTm3rDpSQLvfmN5ZCqJ2BzY/b
zJMAoOSHhDrbRJgMENcMN7CCQlZopMHk
=xlXl
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to