On Tue, Dec 21, 2010 at 11:55:34PM +0100, Jakub Wilk wrote:
> * brian m. carlson <sand...@crustytoothpaste.net>, 2010-12-21, 21:39:
> >diff -ur libuninum.old/unicode.h libuninum-2.7/unicode.h
> >--- libuninum.old/unicode.h  2010-12-21 21:35:42.000000000 +0000
> >+++ libuninum-2.7/unicode.h  2010-12-21 21:36:04.000000000 +0000
> >@@ -1,4 +1,4 @@
> >-typedef unsigned long       UTF32;  /* at least 32 bits */
> >+typedef unsigned int        UTF32;  /* at least 32 bits */
> >typedef unsigned short       UTF16;  /* at least 16 bits */
> >typedef unsigned short       UCS2;   /* at least 16 bits */
> >typedef unsigned char        UTF8;   /* 8 bits */
> 
> While I can image that this patch make things better, please note
> that it also breaks ABI (on 64-bit arches).

So it does.  Does libuninum work at all on 64-bit architectures?  If
not, then ABI breakage is not really relevant.  Nevertheless, I'm
looking to see if I can fix the problem without breaking ABI.

Also, when upstream bumps the SONAME, you should probably convince them
to come into the 90s and use <stdint.h>.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187

Attachment: signature.asc
Description: Digital signature

Reply via email to