Your message dated Sat, 12 Feb 2011 14:33:14 +0000
with message-id <[email protected]>
and subject line Bug#612723: fixed in iodine 0.6.0~rc1-5
has caused the Debian Bug report #612723,
regarding iodine overwrites /etc/default/iodine during upgrade with a sourced 
version of that file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
612723: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612723
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: iodine
Version: 0.6.0~rc1-4
Severity: serious

When I upgrade iodine it'll overwrite my changes in
/etc/default/iodine. This appears to be done by this bit in
debian/postinst:

            db_get iodine/start_daemon
            START_IODINED=$RET
            db_get iodine/daemon_options
            IODINED_ARGS=$RET
            db_get iodine/daemon_password
            IODINED_PASSWORD=$RET
            cat <<EOF > /etc/default/iodine
    # Default settings for iodine. This file is sourced from
    # /etc/init.d/iodined
    START_IODINED="$START_IODINED"
    IODINED_ARGS="$IODINED_ARGS"
    IODINED_PASSWORD="$IODINED_PASSWORD"
    EOF

Since it sources the file it'll be changed like this after upgrade:

    $ sudo git diff default/iodine
    diff --git a/default/iodine b/default/iodine
    index 4132933..b9384c4 100644
    --- a/default/iodine
    +++ b/default/iodine
    @@ -2,4 +2,4 @@
     # /etc/init.d/iodined
     START_IODINED="true"
     IODINED_ARGS="-c -p 5252 172.31.255.1/27 MY-HOSTNAME"
    -IODINED_PASSWORD="$(cat /etc/iodine/passwd/iodine)"
    +IODINED_PASSWORD="my seekrt password"

Where "my seekrt password" is the contents of
/etc/iodine/passwd/iodine. There's two things wrong with this:

 * /etc/default/iodine is sourced as a shell file, and due to
   constructs like $() you can't source it and write out the relevant
   variables again without making changes like these.

 * /etc/default/iodine is a configuration file. You should ask before
   modifying it as most Debian packages do (per policy) for their
   configuration files. The iodine package isn't doing this, hence
   marking this bug as "serious".
    
-- System Information:
Debian Release: 6.0
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'unstable'), (700, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages iodine depends on:
ii  adduser                 3.112+nmu2       add and remove users and groups
ii  debconf [debconf-2.0]   1.5.36.1         Debian configuration management sy
ii  libc6                   2.11.2-10        Embedded GNU C Library: Shared lib
ii  makedev                 2.3.1-89         creates device files in /dev
ii  udev                    164-3            /dev/ and hotplug management daemo
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

iodine recommends no packages.

Versions of packages iodine suggests:
ii  dnsutils             1:9.7.2.dfsg.P3-1.1 Clients provided with BIND
pn  fping                <none>              (no description available)
ii  gawk                 1:3.1.7.dfsg-5      GNU awk, a pattern scanning and pr
pn  ipcalc               <none>              (no description available)
ii  iproute              20100519-3          networking and traffic control too

-- debconf information excluded



--- End Message ---
--- Begin Message ---
Source: iodine
Source-Version: 0.6.0~rc1-5

We believe that the bug you reported is fixed in the latest version of
iodine, which is due to be installed in the Debian FTP archive:

iodine_0.6.0~rc1-5.debian.tar.gz
  to main/i/iodine/iodine_0.6.0~rc1-5.debian.tar.gz
iodine_0.6.0~rc1-5.dsc
  to main/i/iodine/iodine_0.6.0~rc1-5.dsc
iodine_0.6.0~rc1-5_i386.deb
  to main/i/iodine/iodine_0.6.0~rc1-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
gregor herrmann <[email protected]> (supplier of updated iodine package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 12 Feb 2011 14:49:06 +0100
Source: iodine
Binary: iodine
Architecture: source i386
Version: 0.6.0~rc1-5
Distribution: unstable
Urgency: low
Maintainer: gregor herrmann <[email protected]>
Changed-By: gregor herrmann <[email protected]>
Description: 
 iodine     - tool for tunneling IPv4 data through a DNS server
Closes: 612721 612723
Changes: 
 iodine (0.6.0~rc1-5) unstable; urgency=low
 .
   * Don't source /etc/default/iodine in config script but read out the values
     with awk. This allows to use shell constructs like $() in the file and
     preserve them during re-configuration (closes: #612723).
     Thanks to "Debian bug at v.nix.is" for the bug report.
   * Add a logcheck filter; thanks to martin f krafft for the bug report and
     the logcheck file (closes: #612721).
   * Add patch armel_ftbfs.patch: Rename struct user to struct _user in the
     code to avoid naming conflict caused by including <sys/user.h> as part of
     the armel build. Taken from Ubuntu; not needed currently in Debian but
     saves Ubuntu from carrying the patch and might be helpful later.
Checksums-Sha1: 
 89f4dbe985c46a93797c35e1de0d4f5e56cc8cc8 1927 iodine_0.6.0~rc1-5.dsc
 8fd281119b215d3c14c680057e6b91078f16e0e6 22857 iodine_0.6.0~rc1-5.debian.tar.gz
 9025820c559211238a574725cbf58a96fd3eb040 101126 iodine_0.6.0~rc1-5_i386.deb
Checksums-Sha256: 
 e9b62673f07d4fb013d2ab8da843b156927478e831fa4e6fb097aea73ee2dbac 1927 
iodine_0.6.0~rc1-5.dsc
 4d3dd667c74376a77f419e19f572003b1b7b3e23c9700a9e95bf87c6d31efd4b 22857 
iodine_0.6.0~rc1-5.debian.tar.gz
 f6a05f8b527545738a2e9d8d1ed69be0b8cfd8ada3a4848736c0a2348b323311 101126 
iodine_0.6.0~rc1-5_i386.deb
Files: 
 f9dc5eb51e42c087f3714c90d31b96cc 1927 net extra iodine_0.6.0~rc1-5.dsc
 c751b86d752f56aca7205d1f91432c4a 22857 net extra 
iodine_0.6.0~rc1-5.debian.tar.gz
 8e7035b6a2f4f9e45c7c61e6a538f77c 101126 net extra iodine_0.6.0~rc1-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJNVpByAAoJELs6aAGGSaoGyUYP/2GjggINUpotPKiIQoLaBPEk
RXxP2UhVkGhhFT7MX6TeWrWYDRldXFIuxGQO336NasRGdx0xQN8R0H03edUaKOg4
cTtf6boXIxXRQ9SQ8xsqun22Yjkv2XJAgIko1pz4mNoRCBsNWkP1ePyI9ilUdCzt
hXTC3ysqkwwJkk5fDZYuUrzjramKYPmnUw8Ey4kc3VghVAxxjQOFL7FGFF9DxA1E
v18TsJQwgX2i6csvXXt2uOm78owXYRjBbfrJPPCpmKbLnSXRx0KmNdaQKNLVzssG
3GKTlGsgqIQYGAwuN7nqyO+wbyArMuJmKw1NyzJx+ZKF+YvfeKvNAdPr3RcG0Oa6
MeTi2Xq5SGwREeJ1DdWnkPELDFVdERNc91/ob8pmqUCRoPgZP2Fefj+Oy9zs0dR6
uZoJsO4WpzOL/ANQ9VL9VJAiqfwLN78z3HQH3/LWYqya9jSIICTy3upXU5HOhTVj
d9qIFfoBQ9tppzsrl3wB7iuMmdKcveprJaKSZe9fg8G1qozD7hyARCundIm54JX6
n7le5p5Wd2Dm+X7Ae8D5yOXdpMRlJBuBAng34d1wZzziBv93Gx7O2zIDtwlt/yKE
FC2WWNwQrEi0Hr7sccAyMPdVYF6zV8TOra0xs18/gAZzkiIi+1Y/746PQ8R1li8u
vX+VBdkrXa9tbqyXpX7Y
=xLT/
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to