tags 646490 +patch
thanks
I have attatched a patch which can simply be added to the quilt series.
However while fixing the format security errors I noticed some other
rather concerning warnings. In particular I noticed
misc.c: In function ‘addUniqueRow’:
misc.c:176:13: warning: implicit declaration of function ‘strcmp’
[-Wimplicit-function-declaration]
misc.c: In function ‘copySettings’:
misc.c:241:5: warning: implicit declaration of function
‘getExtendedRegexMode’ [-Wimplicit-function-declaration]
The first of these is probably trivial to fix but I dunno what to do to
fix the latter.
Index: searchmonkey-0.8.1/src/systemio.c
===================================================================
--- searchmonkey-0.8.1.orig/src/systemio.c 2007-02-05 22:55:51.000000000 +0000
+++ searchmonkey-0.8.1/src/systemio.c 2011-11-10 21:50:27.000000000 +0000
@@ -199,7 +199,7 @@
(GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT),
GTK_MESSAGE_ERROR,
GTK_BUTTONS_OK,
- error->message);
+ "%s",error->message);
gtk_dialog_run(GTK_DIALOG(errMsg));
gtk_widget_destroy(errMsg);
g_free(filename);
@@ -282,7 +282,7 @@
(GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT),
GTK_MESSAGE_ERROR,
GTK_BUTTONS_OK,
- error->message);
+ "%s",error->message);
gtk_dialog_run(GTK_DIALOG(warnDialog));
g_error_free(error);
error = NULL;
@@ -388,7 +388,7 @@
(GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT),
GTK_MESSAGE_ERROR,
GTK_BUTTONS_OK,
- error->message);
+ "%s",error->message);
g_error_free(error);
error = NULL;
gtk_dialog_run(GTK_DIALOG(warnDialog));
Index: searchmonkey-0.8.1/src/misc.c
===================================================================
--- searchmonkey-0.8.1.orig/src/misc.c 2007-02-05 22:55:51.000000000 +0000
+++ searchmonkey-0.8.1/src/misc.c 2011-11-10 21:57:26.000000000 +0000
@@ -424,7 +424,7 @@
GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_ERROR,
GTK_BUTTONS_CLOSE,
- msg);
+ "%s",msg);
gtk_dialog_run (GTK_DIALOG (dialog));
gtk_widget_destroy (dialog);
g_free(errorString);
