On Sat, Dec 03, 2011 at 12:27:41AM +0100, Jakub Wilk wrote:
> * Miguel de Val-Borro <miguel.de...@gmail.com>, 2011-12-02, 23:07:
> >>| $ python -c 'import numexpr'
> >>| Traceback (most recent call last):
> >>|   File "<string>", line 1, in <module>
> >>|   File "/usr/lib/pymodules/python2.6/numexpr/__init__.py", line 28, in 
> >><module>
> >>|     from numexpr.expressions import E
> >>|   File "/usr/lib/pymodules/python2.6/numexpr/expressions.py", line 7, in 
> >><module>
> >>|     import numpy
> >>| ImportError: No module named numpy
> >>
> >>BTW, since your package uses Numpy via a C extension module, you
> >>should use dh_numpy to generate versioned dependency on it.
> >
> >The dependency on numpy is fixed in the attached patch editing
> >debian/control because the package is not using dh,
> 
> Why is that relevant that the package doesn't use dh?

This is how the dependency on numpy is introduced in other packages
that use cdbs for building.

> >+  * Change Standards-Version to 3.9.2 to fix out-of-date-standards-version
> >+    lintian warning
> 
> Cosmetic changes like this are not appropriate for an NMU.

I have removed the fix for the lintian warning in the attached patch.

Miguel
diff -Nru numexpr-1.4.2/debian/changelog numexpr-1.4.2/debian/changelog
--- numexpr-1.4.2/debian/changelog	2011-04-07 04:12:59.000000000 +0200
+++ numexpr-1.4.2/debian/changelog	2011-12-03 10:57:34.000000000 +0100
@@ -1,3 +1,13 @@
+numexpr (1.4.2-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix "missing dependency on python-numpy" by adding missing dependency to
+    control file (Closes: #641794)
+  * Fix lintian error helper-templates-in-copyright replacing Author(s) by
+    Authors
+
+ -- Miguel de Val Borro <miguel.de...@gmail.com>  Fri, 02 Dec 2011 22:09:40 +0100
+
 numexpr (1.4.2-1) unstable; urgency=low
 
   * Update to 1.4.2
diff -Nru numexpr-1.4.2/debian/control numexpr-1.4.2/debian/control
--- numexpr-1.4.2/debian/control	2011-04-07 04:36:01.000000000 +0200
+++ numexpr-1.4.2/debian/control	2011-12-03 10:57:22.000000000 +0100
@@ -15,7 +15,8 @@
 Architecture: any
 Depends: ${python:Depends},
 	 ${shlibs:Depends},
-	 ${misc:Depends}
+	 ${misc:Depends},
+	 python-numpy
 Description: Numexpr package evaluates multiple-operator array expressions
  many times faster than NumPy can. It accepts the expression as a string,
  analyzes it, rewrites it more efficiently, and compiles it to faster Python
diff -Nru numexpr-1.4.2/debian/copyright numexpr-1.4.2/debian/copyright
--- numexpr-1.4.2/debian/copyright	2011-04-07 04:10:59.000000000 +0200
+++ numexpr-1.4.2/debian/copyright	2011-12-02 22:41:59.000000000 +0100
@@ -6,7 +6,7 @@
 
     http://code.google.com/p/numexpr/
 
-Upstream Author(s):
+Upstream Authors:
 
     David M. Cooke <david.m.co...@gmail.com>
     Francesc Alted <fal...@pytables.org>

Reply via email to