Bug#660857: owfs: FTBFS(kfreebsd): libow.so: undefined reference to `w1_bind'

[Vincent Danjean]

[resubmit with a good from: for the OWFS ML]

  Hi Paul,

  There has been a debian bug report ( http://bugs.debian.org/660857 )
about failure during compilation on kfreebsd (see at the end of this
mail).
  I think that the problem is that ow_com_open.c, at lines 53,
calls w1_bind without checking the OW_W1 is set. Can you confirm
my diagnostic? I propose the patch in attachment that revert to
the previous behavior (as in p13) if OW_W1 is not defined, ie
an error with debug message "Unimplemented"

  Regards,
    Vincent

Le 22/02/2012 13:05, Christoph Egger a écrit :
> Package: src:owfs
> Version: 2.8p14-1
> Severity: serious
> Tags: sid wheezy
> User: debian-...@lists.debian.org
> Usertags: kfreebsd
> X-Debbugs-Cc: debian-...@lists.debian.org
> Justification: fails to build from source (but built successfully in the past)
> 
> Hi!
> 
> Your package failed to build on the kfreebsd-* buildds:
> 
> libtool: link: gcc -I../include -I../../../owlib/src/include -fexceptions 
> -Wall -W -Wundef -Wshadow -Wpointer-arith -Wcast-qual -Wcast-align 
> -Wstrict-prototypes -Wredundant-decls -D_FILE_OFFSET_BITS=64 
> -D_XOPEN_SOURCE=500 -D_BSD_SOURCE=1 -D_ISOC99_SOURCE=1 
> -D_POSIX_C_SOURCE=200112L -g -O2 -D_XOPEN_SOURCE=500 -D_BSD_SOURCE=1 
> -D_ISOC99_SOURCE=1 -D_POSIX_C_SOURCE=200112L -o .libs/owhttpd owhttpd.o 
> owhttpd_handler.o owhttpd_present.o owhttpd_write.o owhttpd_read.o 
> owhttpd_dir.o owhttpd_escape.o owhttpd_favicon.o  -L../../../owlib/src/c 
> /build/buildd-owfs_2.8p14-1-kfreebsd-amd64-6a9p4W/owfs-2.8p14/module/owlib/src/c/.libs/libow.so
>  -pthread
> /build/buildd-owfs_2.8p14-1-kfreebsd-amd64-6a9p4W/owfs-2.8p14/module/owlib/src/c/.libs/libow.so:
>  undefined reference to `w1_bind'
> collect2: ld returned 1 exit status
> make[5]: *** [owhttpd] Error 1
> 
> Full build log at
> https://buildd.debian.org/status/fetch.php?pkg=owfs&arch=kfreebsd-i386&ver=2.8p14-1&stamp=1329428876
> 
> Regards
> 
>     Christoph
> 
> If you have further questions please mail debian-...@lists.debian.org
> 
> 
-- 
Vincent Danjean          Adresse: Laboratoire d'Informatique de Grenoble
Téléphone:  +33 4 76 61 20 11            ENSIMAG - antenne de Montbonnot
Fax:        +33 4 76 61 20 99            ZIRST 51, avenue Jean Kuntzmann
Email: vincent.danj...@imag.fr           38330 Montbonnot Saint Martin

diff --git a/module/owlib/src/c/ow_com_open.c b/module/owlib/src/c/ow_com_open.c
index 6dab6dd..220c8aa 100644
--- a/module/owlib/src/c/ow_com_open.c
+++ b/module/owlib/src/c/ow_com_open.c
@@ -50,7 +50,9 @@ GOOD_OR_BAD COM_open(struct connection_in *connection)
                case ct_tcp:
                        return tcp_open( connection ) ;
                case ct_netlink:
+#if OW_W1
                        return w1_bind( connection ) ;
+#endif
                case ct_i2c:
                case ct_usb:
                        LEVEL_DEBUG("Unimplemented");