Your message dated Sun, 23 Oct 2005 00:11:07 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#304300: Should this bug be kept opened?
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 12 Apr 2005 08:52:44 +0000
>From [EMAIL PROTECTED] Tue Apr 12 01:52:44 2005
Return-path: <[EMAIL PROTECTED]>
Received: from cimice0.lam.cz (cimice.yo.cz) [212.71.168.90] 
        by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
        id 1DLH8U-0004O8-00; Tue, 12 Apr 2005 01:52:42 -0700
Received: from bulb by cimice.yo.cz with local (Exim 4.34)
        id 1DLH7y-0008SU-LE; Tue, 12 Apr 2005 10:52:10 +0200
Date: Tue, 12 Apr 2005 10:52:10 +0200
From: Jan Hudec <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: samba: Security update breaks systems
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Reportbug-Version: 1.50
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Package: samba
Version: 2.2.3a-14.2
Severity: grave
Justification: renders package unusable
Tags: woody patch

The postinst script for samba contains this errorneous code:

if [ -d /var/samba/ ]; then
        mv /var/samba/* /var/lib/samba/ 2>/dev/null || true
        rmdir /var/samba/
fi

Without actually checking that the directory contains the stuff that
should be moved to /var/lib/samba. That directory is commonly used for
the shared data (akin to /var/www). This code breaks such system.

The code should really do:

mkdir -p /var/lib/samba
for F in ntdrivers.tdb ntforms.tdb ntprinters.tdb secrets.tdb share_info.tdb 
wins.dat; do
        if [ -f /var/samba/$F ]; then
                mv /var/samba/$F /var/lib/samba
        fi
fi
grep /var/samba /etc/samba/smb.conf || rmdir /var/samba || true

The problem was already there in the previous update and was not fixed.

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux shpek 2.4.26 #2 Thu Apr 29 15:18:53 CEST 2004 i686
Locale: LANG=C, LC_CTYPE=C

Versions of packages samba depends on:
ii  debconf                  1.0.32          Debian configuration management sy
ii  libc6                    2.2.5-11.8      GNU C Library: Shared libraries an
ii  libcupsys2               1.1.14-5woody12 Common UNIX Printing System(tm) - 
ii  libpam0g                 0.72-35         Pluggable Authentication Modules l
ii  logrotate                3.5.9-8         Log rotation utility
ii  netbase                  4.07            Basic TCP/IP networking system
ii  samba-common             2.2.3a-14.2     Samba common files used by both th

---------------------------------------
Received: (at 304300-done) by bugs.debian.org; 23 Oct 2005 07:11:13 +0000
>From [EMAIL PROTECTED] Sun Oct 23 00:11:13 2005
Return-path: <[EMAIL PROTECTED]>
Received: from dsl093-039-086.pdx1.dsl.speakeasy.net (tennyson.dodds.net) 
[66.93.39.86] 
        by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
        id 1ETa0e-00057Z-00; Sun, 23 Oct 2005 00:11:13 -0700
Received: by tennyson.dodds.net (Postfix, from userid 1000)
        id A0FDF7002; Sun, 23 Oct 2005 00:11:07 -0700 (PDT)
Date: Sun, 23 Oct 2005 00:11:07 -0700
From: Steve Langasek <[EMAIL PROTECTED]>
To: Christian Perrier <[EMAIL PROTECTED]>,
        [EMAIL PROTECTED]
Subject: Re: Bug#304300: Should this bug be kept opened?
Message-ID: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="n+lFg1Zro7sl44OB"
Content-Disposition: inline
In-Reply-To: <[EMAIL PROTECTED]>
User-Agent: Mutt/1.5.9i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
        (1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
        autolearn=no version=2.60-bugs.debian.org_2005_01_02


--n+lFg1Zro7sl44OB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Version: 3.0.14a-3

On Fri, Oct 21, 2005 at 06:36:02PM +0200, Christian Perrier wrote:
> The postinst script for samba contains this errorneous code:

> if [ -d /var/samba/ ]; then
>         mv /var/samba/* /var/lib/samba/ 2>/dev/null || true
>         rmdir /var/samba/
> fi

> The code is actually not really useful in post-sarge unless we want to
> support upgrades from woody (I don't even remember whether /var/samba
> was still used in woody...IIRC /var/lib/samba is already there).

> So, I actually propose just dropping this piece of code and hereby
> close this bug report.

Yes, /var/lib/samba was already present in woody; and in the sarge version
(at least), the code has been updated to only use this code when upgrading
=66rom particularly old versions of samba; so the bug can be closed.

I'll also go ahead and remove the old code from the postinst, as soon as
alioth stops being annoying.

Cheers,
--=20
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[EMAIL PROTECTED]                                   http://www.debian.org/

--n+lFg1Zro7sl44OB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDWzeLKN6ufymYLloRAtYmAJ4tpNyAxfSdlv5cmEnMxQ/w6FrHawCfRis5
ZffQIAQTyF2stD7iMYXdEz0=
=ejgq
-----END PGP SIGNATURE-----

--n+lFg1Zro7sl44OB--


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to