Your message dated Thu, 28 Jun 2012 03:32:13 +0000
with message-id <[email protected]>
and subject line Bug#619717: fixed in atris 1.0.7.dfsg.1-8
has caused the Debian Bug report #619717,
regarding atris: bashisms in Makefile
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
619717: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=619717
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: atris
Version: 1.0.7.dfsg.1-7.1
Severity: important
Justification: ftbfs with dash as /bin/sh
Tags: upstream patch
Hi,
atris uses brace expansions (as in {foo,bar,baz}) in its Makefile
but that is not valid POSIX shell syntax (and dash and busybox ash
don't support them). How about this patch?
-- 8< --
Subject: atris: avoid nonportable {foo,bar} expansion in Makefile
Signed-off-by: Jonathan Nieder <[email protected]>
---
debian/changelog | 8 +++
debian/patches/06-atris-1.0.7.brace_expansion.diff | 48 ++++++++++++++++++++
2 files changed, 56 insertions(+), 0 deletions(-)
create mode 100644 debian/patches/06-atris-1.0.7.brace_expansion.diff
diff --git a/debian/changelog b/debian/changelog
index 225cd23..71e3e70 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+atris (1.0.7.dfsg.1-7.1.1) local; urgency=low
+
+ * [debian/patches/06-atris-1.0.7.brace_expansion.diff]:
+ Makefile.am: avoid brace expansions (since dash does not
+ support them).
+
+ -- Jonathan Nieder <[email protected]> Sat, 26 Mar 2011 07:25:35 -0500
+
atris (1.0.7.dfsg.1-7.1) unstable; urgency=low
* Non-maintainer upload.
diff --git a/debian/patches/06-atris-1.0.7.brace_expansion.diff
b/debian/patches/06-atris-1.0.7.brace_expansion.diff
new file mode 100644
index 0000000..d72a368
--- /dev/null
+++ b/debian/patches/06-atris-1.0.7.brace_expansion.diff
@@ -0,0 +1,48 @@
+From: Jonathan Nieder <[email protected]>
+Date: Sat, 26 Mar 2011 07:22:24 -0500
+Subject: avoid unportable brace expansion
+
+dash, FreeBSD ash, and busybox ash do not support 'echo {hello,world}'
+expansion.
+
+Signed-off-by: Jonathan Nieder <[email protected]>
+---
+ Makefile.am | 10 ++++++----
+ 1 files changed, 6 insertions(+), 4 deletions(-)
+
+diff --git Makefile.am Makefile.am
+index cc07f93..561186a 100644
+--- Makefile.am
++++ Makefile.am
+@@ -59,14 +59,14 @@ install_gamedata:
+ cp -rv graphics \
+ styles \
+ $(target)/
+- -rm -f $(target)/{graphics,styles}/Makefile*
++ -rm -f $(target)/graphics/Makefile* $(target)/styles/Makefile*
+
+ sh mkinstalldirs / $(statedir)/
+ cp -rv Atris.Players \
+ Atris.Scores \
+ $(statedir)/
+- chmod 666 $(statedir)/Atris.{Players,Scores}
+- chown .games $(statedir)/Atris.{Players,Scores}
++ chmod 666 $(statedir)/Atris.Players $(statedir)/Atris.Scores
++ chown .games $(statedir)/Atris.Players $(statedir)/Atris.Scores
+
+ install_gamedocs:
+ sh mkinstalldirs $(target)/
+@@ -90,7 +90,9 @@ zip: distdir $(PACKAGE)
+ mv $(PACKAGE) $(PACKAGE)-$(VERSION)/$(PACKAGE).exe
+ mv $(PACKAGE)-$(VERSION) $(PACKAGE)
+ cp ~/*.dll $(PACKAGE)
+- rm $(PACKAGE)/config* $(PACKAGE)/*.[ch] $(PACKAGE)/Make*
$(PACKAGE)/*.m4 $(PACKAGE)/{install-sh,missing,mkinstalldirs,autogen.sh}
++ rm $(PACKAGE)/config* $(PACKAGE)/*.[ch] $(PACKAGE)/Make* $(PACKAGE)/*.m4
++ rm $(PACKAGE)/install-sh $(PACKAGE)/missing $(PACKAGE)/mkinstalldirs
++ rm $(PACKAGE)/autogen.sh
+ rm $(PACKAGE)/*.in -r $(PACKAGE)/.protos
+ zip -r9 $(PACKAGE)-$(VERSION)-win32.zip $(PACKAGE)
+ rm -r $(PACKAGE)
+--
+1.7.4.1
+
--
1.7.4.1
--- End Message ---
--- Begin Message ---
Source: atris
Source-Version: 1.0.7.dfsg.1-8
We believe that the bug you reported is fixed in the latest version of
atris, which is due to be installed in the Debian FTP archive:
atris_1.0.7.dfsg.1-8.debian.tar.gz
to main/a/atris/atris_1.0.7.dfsg.1-8.debian.tar.gz
atris_1.0.7.dfsg.1-8.dsc
to main/a/atris/atris_1.0.7.dfsg.1-8.dsc
atris_1.0.7.dfsg.1-8_amd64.deb
to main/a/atris/atris_1.0.7.dfsg.1-8_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Pascal Giard <[email protected]> (supplier of updated atris package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 27 Jun 2012 22:30:24 -0400
Source: atris
Binary: atris
Architecture: source amd64
Version: 1.0.7.dfsg.1-8
Distribution: unstable
Urgency: low
Maintainer: Pascal Giard <[email protected]>
Changed-By: Pascal Giard <[email protected]>
Description:
atris - tetris-like game with a twist for Unix
Closes: 619714 619717
Changes:
atris (1.0.7.dfsg.1-8) unstable; urgency=low
.
* Finally applied patches fixing R-C bugs, thanks a lot to
Jonathan Nieder <[email protected]>.
.
[ Pascal Giard ]
* [debian/control]:
- Depend on fonts-freefont-ttf instead of ttf-freefont.
- Added homepage field.
* [debian/copyright]:
- Refer to the version of the license the package references in its
license statement i.e. GNU GPL-2.
* [debian/atris.postrm]:
- Added "set -e" to ensure that the script's execution is aborted when
any executed command fails.
.
[ Jonathan Nieder ]
* [debian/patches/01-atris-1.0.7.Makefile.am_pathfix.diff]:
- Avoid brace expansions (closes: #619717).
* [debian/patches, debian/source/format]:
- Use source format 3.0 (quilt) (closes: #619714).
Checksums-Sha1:
b229c0c4e37ae2cc7d2beb23237a60267bdd2f87 1176 atris_1.0.7.dfsg.1-8.dsc
dccea99f1b0e5273a5a11040ceb0f9c12a5c7e7d 8082
atris_1.0.7.dfsg.1-8.debian.tar.gz
e8fe5a4cf0eafd9fd36ecb660cafb49ba67eed5d 325244 atris_1.0.7.dfsg.1-8_amd64.deb
Checksums-Sha256:
62f9395dbf7d6621a56219cafa9a777fe34347b23c11ad98324d67fbd9303ebe 1176
atris_1.0.7.dfsg.1-8.dsc
b71e0298bec75188880a9571684aea0690e35fab68164615c49f8fb0f0d6ad8f 8082
atris_1.0.7.dfsg.1-8.debian.tar.gz
77aa9b3f3092694abe87afabd289a4a0cf4c8e4a1714b8157a409d376b23ed09 325244
atris_1.0.7.dfsg.1-8_amd64.deb
Files:
6caa1dadaa08d5518337910ee593a647 1176 games optional atris_1.0.7.dfsg.1-8.dsc
d9b81e44c6deb3f614da3573d967fbe6 8082 games optional
atris_1.0.7.dfsg.1-8.debian.tar.gz
01aae33a30fa7330dba3c38ea0afe840 325244 games optional
atris_1.0.7.dfsg.1-8_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAk/rzTQACgkQ1Lfd97FsypVoZQCfQ7aE+h9uxm0y8C39gxQFggcF
i2EAn0deKBt5mR5lDA15Jo0D/S0sGlau
=Gqk9
-----END PGP SIGNATURE-----
--- End Message ---
