Your message dated Tue, 25 Oct 2005 02:47:10 -0700
with message-id <[EMAIL PROTECTED]>
and subject line Bug#289014: fixed in drip 0.8.3.2+0.9.0-rc3-6
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Jan 2005 19:07:29 +0000
>From [EMAIL PROTECTED] Thu Jan 06 11:07:29 2005
Return-path: <[EMAIL PROTECTED]>
Received: from c158183.adsl.hansenet.de (localhost.localdomain)
[213.39.158.183]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Cmcym-0007nA-00; Thu, 06 Jan 2005 11:07:29 -0800
Received: from aj by localhost.localdomain with local (Exim 4.34)
id 1Cmd4S-0003HQ-QG; Thu, 06 Jan 2005 20:13:20 +0100
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
From: Andreas Jochens <[EMAIL PROTECTED]>
Subject: drip: FTBFS (amd64/gcc-4.0): cast from 'void*' to 'int' loses precision
Message-Id: <[EMAIL PROTECTED]>
Date: Thu, 06 Jan 2005 20:13:20 +0100
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: drip
Severity: normal
Tags: patch
When building 'drip' on amd64 with gcc-4.0,
I get the following error:
fast_memcpy.cpp:309:2: warning: #warning Using non accelerated libc memcpy()
fast_memcpy.cpp: In function 'void* _fast_memcpy(void*, const void*, size_t)':
fast_memcpy.cpp:168: error: cast from 'void*' to 'int' loses precision
fast_memcpy.cpp: In function 'void* fast_memcpy(void*, const void*, size_t)':
fast_memcpy.cpp:311: warning: control reaches end of non-void function
make[3]: *** [libencoder_la-fast_memcpy.lo] Error 1
With the attached patch 'drip' can be compiled
on amd64 using gcc-4.0. This patch includes some fixes which were
already necessary for gcc-3.4.
Regards
Andreas Jochens
diff -urN ../tmp-orig/drip-0.8.3.2+0.9.0-rc3/debian/patches/z_gcc-4.0_fix.diff
./debian/patches/z_gcc-4.0_fix.diff
--- ../tmp-orig/drip-0.8.3.2+0.9.0-rc3/debian/patches/z_gcc-4.0_fix.diff
1970-01-01 01:00:00.000000000 +0100
+++ ./debian/patches/z_gcc-4.0_fix.diff 2005-01-06 19:35:39.000000000 +0100
@@ -0,0 +1,124 @@
+diff -urN tmp/encoder/fast_memcpy.cpp drip-0.9.0rc3/encoder/fast_memcpy.cpp
+--- tmp/encoder/fast_memcpy.cpp 2005-01-06 18:12:41.358481000 +0100
++++ drip-0.9.0rc3/encoder/fast_memcpy.cpp 2005-01-06 18:14:09.522078544
+0100
+@@ -165,7 +165,7 @@
+ }
+ #else
+ // Align destination at BLOCK_SIZE boundary
+- for(; ((int)to & (BLOCK_SIZE-1)) && i>0; i--)
++ for(; ((long)to & (BLOCK_SIZE-1)) && i>0; i--)
+ {
+ __asm__ __volatile__ (
+ #ifndef HAVE_MMX1
+@@ -188,8 +188,8 @@
+ MOVNTQ" %%mm6, 48(%1)\n"
+ MOVNTQ" %%mm7, 56(%1)\n"
+ : : "r" (from), "r" (to) : "memory");
+- ((const unsigned char *)from)+=64;
+- ((unsigned char *)to)+=64;
++ from = ((const unsigned char *)from) + 64;
++ to = ((unsigned char *)to) + 64;
+ }
+
+ // printf(" %d %d\n", (int)from&1023, (int)to&1023);
+@@ -277,8 +277,8 @@
+ MOVNTQ" %%mm6, 48(%1)\n"
+ MOVNTQ" %%mm7, 56(%1)\n"
+ : : "r" (from), "r" (to) : "memory");
+- ((const unsigned char *)from)+=64;
+- ((unsigned char *)to)+=64;
++ from = ((const unsigned char *)from) + 64;
++ to = ((unsigned char *)to) + 64;
+ }
+
+ #endif /* Have SSE */
+diff -urN tmp/encoder/encoder.cpp drip-0.9.0rc3/encoder/encoder.cpp
+--- tmp/encoder/encoder.cpp 2003-12-01 00:04:42.000000000 +0100
++++ drip-0.9.0rc3/encoder/encoder.cpp 2004-08-27 16:13:56.391305665 +0200
+@@ -762,7 +762,7 @@
+ framebuffer = (guchar*)malloc(Config.in_width*Config.in_height*3);
+ /* Allocate video buffers */
+ extrabuffer = (guchar*)malloc(Config.in_width*BYTES_PER_COLOUR_OUTPOUT+4);
+- rowptr = new (guchar*)[Config.in_height];
++ rowptr = new guchar*[Config.in_height];
+ for (gint i=0; i<Config.in_height; i++) {
+ if(i==Config.in_height-1) {
+ rowptr[i]=extrabuffer;
+diff -urN tmp/encoder/external.cpp drip-0.9.0rc3/encoder/external.cpp
+--- tmp/encoder/external.cpp 2003-11-29 15:31:04.000000000 +0100
++++ drip-0.9.0rc3/encoder/external.cpp 2004-08-27 16:11:57.960309913 +0200
+@@ -222,7 +222,7 @@
+ list[codec_nr]->cdescription =
g_string_new(list[codec_nr]->ctype->str);
+ list[codec_nr]->cdescription =
g_string_append(list[codec_nr]->cdescription,": ");
+ list[codec_nr]->cdescription =
g_string_append(list[codec_nr]->cdescription,it->GetName());
+- list[codec_nr]->cav = (enum codecT)0;
++ list[codec_nr]->cav = (codecT)0;
+ list[codec_nr]->ci = (gpointer)it;
+ codec_nr++;
+ #ifndef STANDALONE
+@@ -248,7 +248,7 @@
+ list[codec_nr]->ccodec = *ia;
+ list[codec_nr]->cmodule =
g_string_new(it->privatename.c_str());
+ list[codec_nr]->cdescription =
g_string_new(it->GetName());
+- list[codec_nr]->cav = (enum codecT)1;
++ list[codec_nr]->cav = (codecT)1;
+ list[codec_nr]->ci = (gpointer)it;
+ codec_nr++;
+ #ifndef STANDALONE
+
+diff -urN tmp/encoder/demuxer.cpp drip-0.9.0rc3/encoder/demuxer.cpp
+--- tmp/encoder/demuxer.cpp 2005-01-06 18:25:26.274196000 +0100
++++ drip-0.9.0rc3/encoder/demuxer.cpp 2005-01-06 18:32:57.129656136 +0100
+@@ -743,8 +743,8 @@
+ /* Mpeg2 frame ready, feed to Drip frame processor */
+ if (mpeg2info->display_fbuf) {
+ mpeg2buf[0] = mpeg2info->display_fbuf->buf[0];
+- mpeg2buf[1] = (guint8*)((gint)mpeg2info->display_fbuf->buf[0]
+ drip_mpeg_width()*drip_mpeg_height());
+- mpeg2buf[2] = (guint8*)((gint)mpeg2info->display_fbuf->buf[0]
+ drip_mpeg_width()*drip_mpeg_height()*5/4);
++ mpeg2buf[1] = (guint8*)((long)mpeg2info->display_fbuf->buf[0]
+ drip_mpeg_width()*drip_mpeg_height());
++ mpeg2buf[2] = (guint8*)((long)mpeg2info->display_fbuf->buf[0]
+ drip_mpeg_width()*drip_mpeg_height()*5/4);
+ /* Call current processor (autoclipper, frame fifo, etc) */
+ processor(mpeg2buf,(uint32_t)PTSframe,PTSaudio);
+ }
+diff -urN tmp/encoder/autoclipper.cpp drip-0.9.0rc3/encoder/autoclipper.cpp
+--- tmp/encoder/autoclipper.cpp 2003-11-25 00:01:26.000000000 +0100
++++ drip-0.9.0rc3/encoder/autoclipper.cpp 2005-01-06 18:34:00.870965984
+0100
+@@ -38,7 +38,7 @@
+ register guint8* base;
+ register guint8 Y;
+
+- line += (gint)framebuffer; // point to offset in Y color plane
++ line += (long)framebuffer; // point to offset in Y color plane
+
+ for (pixel=0;pixel<height;pixel++) {
+ base = (guint8*)(line+pixel*width);
+diff -urN tmp/plug-ins/magickfilter.cpp drip-0.9.0rc3/plug-ins/magickfilter.cpp
+--- tmp/plug-ins/magickfilter.cpp 2005-01-06 18:25:26.212206000 +0100
++++ drip-0.9.0rc3/plug-ins/magickfilter.cpp 2005-01-06 19:35:31.791860720
+0100
+@@ -1052,7 +1052,7 @@
+ #endif
+ }
+ if (value2 != -1) {
+- result = ContrastImage(ImageBuffer,(MagickBooleanType)value2);
//const unsigned int sharpen);
++ result = ContrastImage(ImageBuffer,(MagickBooleanType)(value2!=0));
//const unsigned int sharpen);
+ #ifdef DEBUG
+ g_log(DRIP_LD,G_LOG_LEVEL_DEBUG,"Plugin: magickfilter Contrast");
+ #endif
+@@ -1099,7 +1099,7 @@
+ #endif
+ }
+ if (value16 != -1) {
+- result = NegateImage(ImageBuffer,(MagickBooleanType)value16); //const
unsigned int grayscale);
++ result = NegateImage(ImageBuffer,(MagickBooleanType)(value16!=0));
//const unsigned int grayscale);
+ #ifdef DEBUG
+ g_log(DRIP_LD,G_LOG_LEVEL_DEBUG,"Plugin: magickfilter Negate");
+ #endif
+@@ -1220,7 +1220,7 @@
+ #endif
+ }
+ if (value33!=0 || value34!=0 || value35!=0) {
+- ImageBuffer2 =
ShadeImage(ImageBuffer,(MagickBooleanType)value33,value34,value35,&exception);
//const unsigned int gray,double azimuth,double elevation
++ ImageBuffer2 =
ShadeImage(ImageBuffer,(MagickBooleanType)(value33!=0),value34,value35,&exception);
//const unsigned int gray,double azimuth,double elevation
+ CatchException(&exception);
+ DestroyImage(ImageBuffer);
+ ImageBuffer = ImageBuffer2;
---------------------------------------
Received: (at 289014-close) by bugs.debian.org; 25 Oct 2005 09:49:05 +0000
>From [EMAIL PROTECTED] Tue Oct 25 02:49:05 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EULOg-0006Xs-00; Tue, 25 Oct 2005 02:47:10 -0700
From: Alastair McKinstry <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#289014: fixed in drip 0.8.3.2+0.9.0-rc3-6
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Tue, 25 Oct 2005 02:47:10 -0700
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2
Source: drip
Source-Version: 0.8.3.2+0.9.0-rc3-6
We believe that the bug you reported is fixed in the latest version of
drip, which is due to be installed in the Debian FTP archive:
drip_0.8.3.2+0.9.0-rc3-6.diff.gz
to pool/main/d/drip/drip_0.8.3.2+0.9.0-rc3-6.diff.gz
drip_0.8.3.2+0.9.0-rc3-6.dsc
to pool/main/d/drip/drip_0.8.3.2+0.9.0-rc3-6.dsc
drip_0.8.3.2+0.9.0-rc3-6_i386.deb
to pool/main/d/drip/drip_0.8.3.2+0.9.0-rc3-6_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Alastair McKinstry <[EMAIL PROTECTED]> (supplier of updated drip package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Mon, 24 Oct 2005 21:43:30 +0100
Source: drip
Binary: drip
Architecture: source i386
Version: 0.8.3.2+0.9.0-rc3-6
Distribution: unstable
Urgency: low
Maintainer: Alastair McKinstry <[EMAIL PROTECTED]>
Changed-By: Alastair McKinstry <[EMAIL PROTECTED]>
Description:
drip - GNOME application for encoding a DivX from a DVD
Closes: 289014 289619 318234
Changes:
drip (0.8.3.2+0.9.0-rc3-6) unstable; urgency=low
.
* New maintainer: Closes: #289619.
* Rebuild against latest libsdl1.2 for slang2 transition.
Closes: #318234.
* Applied patch for amd64 FTBFS from Andreas Jochens. Closes: #289014.
* Build-Depend on libxinerama-dev, libxxf86vm-dev, libxxf86dga-dev
(needed as part of xorg transition?)
* Move to Standards-Version: 3.6.2. No changes required.
Files:
78c2fe099e70e2ef585053158529d65f 1024 graphics extra
drip_0.8.3.2+0.9.0-rc3-6.dsc
b21e53551be6857b55a91a2fe59735ec 7202 graphics extra
drip_0.8.3.2+0.9.0-rc3-6.diff.gz
bb9eb37139f6e2073e3739914536f9a3 424890 graphics extra
drip_0.8.3.2+0.9.0-rc3-6_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDXfunQTK/kCo4XFcRAnSSAJ9JFwzcU/9W34WHI840pt2TzhP86gCfcZff
th2z/g7CzVhuQu7gy4MPGk8=
=VJgy
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]