Package: dancer-ircd
Version: 1.0.36-8
Severity: serious
Tags: patch
Dear Maintainer,
Andreas Beckmann <[email protected]> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.
Lintian detects the problem and warns as follow:
/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.
Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for
details.
Severity: serious, Certainty: possible
Check: files, Type: binary, udeb
which is why I am reporting this bug with severity serious (and there fore,
release critical).
Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.
Cheers,
Thomas Goirand (zigo)
diff -u dancer-ircd-1.0.36/debian/init.d dancer-ircd-1.0.36/debian/init.d
--- dancer-ircd-1.0.36/debian/init.d
+++ dancer-ircd-1.0.36/debian/init.d
@@ -16,11 +16,19 @@
DAEMON=/usr/sbin/dancer-ircd
NAME=dancer-ircd
DESC=dancer-ircd
+RUNDIR=/var/run/dancer-ircd
test -f $DAEMON || exit 0
set -e
+if [ ! -d ${RUNDIR} ] ; then
+ mkdir -p ${RUNDIR} || true
+ if [ -d ${RUNDIR} ] ; then
+ chown dancer:dancer ${RUNDIR}
+ fi
+fi
+
case "$1" in
start)
echo -n "Starting $DESC: "
diff -u dancer-ircd-1.0.36/debian/dancer-ircd.dirs dancer-ircd-1.0.36/debian/dancer-ircd.dirs
--- dancer-ircd-1.0.36/debian/dancer-ircd.dirs
+++ dancer-ircd-1.0.36/debian/dancer-ircd.dirs
@@ -7 +6,0 @@
-var/run/dancer-ircd
diff -u dancer-ircd-1.0.36/debian/dancer-ircd.postinst dancer-ircd-1.0.36/debian/dancer-ircd.postinst
--- dancer-ircd-1.0.36/debian/dancer-ircd.postinst
+++ dancer-ircd-1.0.36/debian/dancer-ircd.postinst
@@ -21,7 +21,6 @@
# limitation. Someday it will be fixed
chown $USER:$USER /var/log/dancer-ircd
- chown $USER:$USER /var/run/dancer-ircd
chown $USER:$USER /var/lib/dancer-ircd
chown $USER:$USER /var/lib/dancer-ircd/dline.conf
chown $USER:$USER /var/lib/dancer-ircd/kline.conf
diff -u dancer-ircd-1.0.36/debian/changelog dancer-ircd-1.0.36/debian/changelog
--- dancer-ircd-1.0.36/debian/changelog
+++ dancer-ircd-1.0.36/debian/changelog
@@ -1,3 +1,10 @@
+dancer-ircd (1.0.36-8.1) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Fixes handling of /var/run/dancer-ircd life cycle (Closes: #XXXXXX).
+
+ -- Thomas Goirand <[email protected]> Sun, 07 Oct 2012 10:42:26 +0000
+
dancer-ircd (1.0.36-8) unstable; urgency=medium
* Bump Standards-Version to 3.7.3.
