On Fri, 2012-12-21 at 12:40 +0100, Dominik George wrote:
> I have looked into the config and postinst script to find some hints on
> why this might happen. Here are some remarks, be they relevant or not:

Thanks for the feedback. Always good to have another set of eyes looking
at the code.

> - Using backticks in shell scripts is incompatible and might break with
>   some shells, POSIX says use $()

I will consider replacing backticks with $() but this requires very
careful testing because backslash handling seems to be different. I
occasionally make shellscripts that also have to work on Solaris
where /bin/sh doesn't have $().

> - postinst, line 93: Just replacing any occurence of nss-ldapd with nslcd
>   in the config file is a bit over the top and might^Wwill break. Simple,
>   and bug-related, example: user has- their cacertfile stored in
>   /etc/ssl/certs/nss-ldapd-cacert.pem or something. A fix would be to use
>   look-around assertions on ^# to only replace matches on lines that are
>   comments.

Thanks, I'll drop the conversion code because that is only useful for
upgrades from before version 0.7 (when upgrading from lenny).

Neither of these things should be a problem for this particular bug and
I don't think these changes should be in the release targeted towards
wheezy (although the second change is simple enough).

> Arno, can you provide the config files of the two systems from
> *before* they got clobbered? When sending them to the BTS as
> attachments, please gzip them beforehand due to #695627 breaking
> plaintext attachments.

I don't think you sent your message to Arno but I've asked again.

Thanks for looking into this,

-- 
-- arthur - adej...@debian.org - http://people.debian.org/~adejong --

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to