Package: gucharmap
Version: 1:3.8.2-1
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)
Building with perl 5.18.0 installed results in:
....
cd gucharmap && ./gen-guch-unicode-tables.pl 6.1.0 /usr/share/unicode
syntax error at ./gen-guch-unicode-tables.pl line 377, near "kTang kKorean
kJapaneseKun kJapaneseOn)"
(Might be a runaway multi-line () string starting on line 376)
Global symbol "$f" requires explicit package name at ./gen-guch-unicode-
tables.p
l line 379.
....
syntax error at ./gen-guch-unicode-tables.pl line 413, near "}"
../gen-guch-unicode-tables.pl has too many errors.
make: *** [debian/stamp-gen-unicode-tables] Error 255
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Command exited with non-zero status 2
Reason are "for" statements (on lines 376 and 426 of gen-guch-unicode-
tables.pl)
that iterate over a qw() list, but omit the parentheses around them.
This drew a deprecation warning in perl 5.16 and is an error in 5.18
(cf.
http://search.cpan.org/~rjbs/perl-5.18.0/pod/perldelta.pod#qw%28...%29_can_no_longer_be_used_as_parentheses).
Patch attached (simply add parentheses).
Cheers, Roderich
-- System Information:
Debian Release: jessie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.9.4 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages gucharmap depends on:
ii dconf-gsettings-backend [gsettings-backend] 0.16.0-1
ii libatk1.0-0 2.8.0-2
ii libc6 2.17-3
ii libcairo2 1.12.14-4
ii libglib2.0-0 2.36.1-2build1
ii libgtk-3-0 3.8.2-1
ii libgucharmap-2-90-7 1:3.8.2-1
ii libpango-1.0-0 1.32.5-5
ii libpangocairo-1.0-0 1.32.5-5
Versions of packages gucharmap recommends:
ii yelp 3.6.1-1
gucharmap suggests no packages.
-- no debconf information
--- gucharmap-3.8.2-ORIG/gucharmap/gen-guch-unicode-tables.pl 2013-05-26 19:29:41.581766325 +0200
+++ gucharmap-3.8.2/gucharmap/gen-guch-unicode-tables.pl 2013-05-26 19:30:15.336999725 +0200
@@ -373,8 +373,8 @@
undef $kJapaneseOn;
}
- for my $f qw(kDefinition kCantonese kMandarin
- kTang kKorean kJapaneseKun kJapaneseOn) {
+ for my $f (qw(kDefinition kCantonese kMandarin
+ kTang kKorean kJapaneseKun kJapaneseOn)) {
if ($field eq $f) {
push @strings, $value;
@@ -423,8 +423,8 @@
print $out "static const Unihan *_get_unihan (gunichar uc)\n;";
- for my $name qw(kDefinition kCantonese kMandarin
- kTang kKorean kJapaneseKun kJapaneseOn) {
+ for my $name (qw(kDefinition kCantonese kMandarin
+ kTang kKorean kJapaneseKun kJapaneseOn)) {
print $out <<EOT;
static inline const char * unihan_get_$name (const Unihan *uh)