Your message dated Wed, 04 Sep 2013 15:48:10 +0000
with message-id <e1vhfjs-0007wt...@franck.debian.org>
and subject line Bug#709012: fixed in cvsgraph 1.7.0-4
has caused the Debian Bug report #709012,
regarding cvsgraph: FTBFS with ld that defaults to --as-needed when 
gdlib-config is present: missing -lm
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
709012: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=709012
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: cvsgraph
Version: 1.7.0-3
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch saucy

cvsgraph fails to build with a linker that defaults to --as-needed when
gdlib-config is present, as shown in this Ubuntu build log:

  
https://launchpadlibrarian.net/140260800/buildlog_ubuntu-saucy-i386.cvsgraph_1.7.0-3build1_FAILEDTOBUILD.txt.gz

When gdlib-config is present, the AX_CHECK_GD macro forgets all previous
entries in LIBS, presumably in an attempt to avoid overlinking.
However, the atan2 function in libm is used independently of libgd, and
therefore must be linked regardless of how libgd is configured.

The following patch should fix this.  I used dh-autoreconf since that's
the easiest and generally most reliable way to apply changes to
autotools input files, but it's worth noting that if you build your
binary package in the same tree where you build your source package (as
opposed to building the binary package with sbuild or similar) then this
may eventually cause the generated configure et al to disappear from
your source package; this is probably OK since despite the use of the
3.0 (native) source format you seem to have an independent upstream.

  * Make configure test for -lm after testing for GD (which may discard
    prior additions to LIBS).  We need -lm for atan2 regardless of whether
    we have gdlib-config.
  * Use dh-autoreconf to help apply this change.

diff -Nru cvsgraph-1.7.0/configure.in cvsgraph-1.7.0/configure.in
--- cvsgraph-1.7.0/configure.in 2008-05-21 13:09:44.000000000 +0100
+++ cvsgraph-1.7.0/configure.in 2013-05-20 10:25:55.000000000 +0100
@@ -73,8 +73,6 @@
 AC_PROG_YACC
 AC_PATH_PROG(ac_prog_pkg_config, pkg-config)
 
-AC_CHECK_LIB(m, sqrt)
-
 AC_CHECK_LIB(freetype, FT_Load_Glyph)
 if test "$ac_cv_lib_freetype_FT_Load_Glyph" != "yes"
 then
@@ -84,6 +82,8 @@
 # find out what the GD library uses
 AX_CHECK_GD
 
+AC_CHECK_LIB(m, atan2)
+
 # Checks for header files.
 AC_HEADER_STDC
 AC_CHECK_HEADERS([getopt.h sys/wait.h gd.h])
diff -Nru cvsgraph-1.7.0/debian/control cvsgraph-1.7.0/debian/control
--- cvsgraph-1.7.0/debian/control       2013-05-03 14:37:13.000000000 +0100
+++ cvsgraph-1.7.0/debian/control       2013-05-20 10:29:28.000000000 +0100
@@ -2,7 +2,7 @@
 Section: devel
 Priority: optional
 Maintainer: Mark Brown <broo...@debian.org>
-Build-Depends: debhelper (>> 9), dpkg-dev (>= 1.16.1), libgd2-noxpm-dev | 
libgd2-xpm-dev, bison | byacc, flex, libfreetype6-dev
+Build-Depends: debhelper (>> 9), dpkg-dev (>= 1.16.1), libgd2-noxpm-dev | 
libgd2-xpm-dev, bison | byacc, flex, libfreetype6-dev, dh-autoreconf
 Standards-Version: 3.9.4
 
 Package: cvsgraph
diff -Nru cvsgraph-1.7.0/debian/rules cvsgraph-1.7.0/debian/rules
--- cvsgraph-1.7.0/debian/rules 2013-05-06 22:30:31.000000000 +0100
+++ cvsgraph-1.7.0/debian/rules 2013-05-20 10:27:37.000000000 +0100
@@ -11,6 +11,7 @@
 configure: configure-stamp
 configure-stamp:
        dh_testdir
+       dh_autoreconf
        # Add here commands to configure the package.
        ./configure --prefix=/usr --mandir=\$${prefix}/share/man 
--infodir=\$${prefix}/share/info --sysconfdir=/etc/cvsgraph
 
@@ -34,6 +35,7 @@
 
        if [ -f Makefile ]; then $(MAKE) distclean ; fi
 
+       dh_autoreconf_clean
        dh_clean
 
 install: build

Cheers,

-- 
Colin Watson                                       [cjwat...@ubuntu.com]

--- End Message ---
--- Begin Message ---
Source: cvsgraph
Source-Version: 1.7.0-4

We believe that the bug you reported is fixed in the latest version of
cvsgraph, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 709...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mark Brown <broo...@debian.org> (supplier of updated cvsgraph package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 04 Sep 2013 16:23:51 +0100
Source: cvsgraph
Binary: cvsgraph
Architecture: source amd64
Version: 1.7.0-4
Distribution: unstable
Urgency: low
Maintainer: Mark Brown <broo...@debian.org>
Changed-By: Mark Brown <broo...@debian.org>
Description: 
 cvsgraph   - Create a tree of revisions/branches from a CVS/RCS file
Closes: 709012
Changes: 
 cvsgraph (1.7.0-4) unstable; urgency=low
 .
   * Make configure test for -lm after testing for GD (which may discard
     prior additions to LIBS).  We need -lm for atan2 regardless of whether
     we have gdlib-config.  Patch from Colin Watson (closes: #709012).
   * Use dh-autoreconf to help apply this change.
Checksums-Sha1: 
 311de116e24c19aac429adccce8eafecb3df5f16 1767 cvsgraph_1.7.0-4.dsc
 5fa3255a0fa6d3b81fd200297969a5a33ea1cb20 9439 cvsgraph_1.7.0-4.debian.tar.gz
 038b1c353f2e41cdc70eaec5c8303ce3f9ec3561 76512 cvsgraph_1.7.0-4_amd64.deb
Checksums-Sha256: 
 cc234343a9de5d4967867f81710f914fea403dba1531db0044f79e13f8f4ff4a 1767 
cvsgraph_1.7.0-4.dsc
 53bfb2e691ecd7e55ceaf85a89772375df524ff0b02b24aefbab77f63e930f38 9439 
cvsgraph_1.7.0-4.debian.tar.gz
 80367b37112ae731c9a8875a8c84bc396517b062b52d328ade27e87bc35353d6 76512 
cvsgraph_1.7.0-4_amd64.deb
Files: 
 0a5859293211cf3645347e696a891cc8 1767 devel optional cvsgraph_1.7.0-4.dsc
 53a96f6c7ec4e1c250484e83ef0f25c6 9439 devel optional 
cvsgraph_1.7.0-4.debian.tar.gz
 305c3e96b2e8660414ac1898239e11f3 76512 devel optional 
cvsgraph_1.7.0-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQIcBAEBAgAGBQJSJ1LmAAoJELSic+t+oim9y1AQAJecMIXX2b8oxEgFKdf8NZxi
deqZ+TnJoiaVS146kFVlkFUz5qVTnJdHHxFMFukwuIsm4jZ6l6XQ0g50Uj89it41
Ucvl8xxVw37jieLbQW+aTkrFGCu9k4HQsVq7BfMe41Z/m450kjVUkKGvrF+zE2l3
AfC9kzeLzqWY8ff/lWXSpAJLJoyp6R5vNlL0HNVQHmEgQf00orOgvwyn18s+S5Wa
QwNxZqvkVc3pXvy6REftHH7AIPzQ/ohxy8Gchw1vyceCyfhf30JpHeKck4/UHdrr
XpPmmAwoePKoz/5eJMwTznt/aBKxG8lwNk7ubY+wRAmb+MAt5PDO+S0yTr77aIRH
Xm0ZVejg5s38nOpkWGi0KNuh2Bcf99jQ+KhtqS/pgEH7o2wfvVHUegMyhRCcjVGF
Ef7PcIVArUf7GPLH/5xnS74wBaouVFQTePcfq/dL6GN3x28r+pNm5ZSdD5vGUN4H
2MqnCb5UwicWU0xddK+nvUQ3Oa0K5u4/6xpGC4lnjeHYdZUo75KLvLKILU5g2ZMn
pf65CmtFdzevxp+DBqt6+435/IR3SbxgndYDExvWi0mLP//tNwUzwY6KX6wSMHpg
UBbJ6XoZXaCuir3VDT/hUQWJMvkUOBb/Z1NDjltkdTXLN9uR4OK9j8emEJSZ8KqI
mIjYGZ+eFMJkPkfwIwUG
=JKbm
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to