On Tue, Jan 14, 2014 at 11:36:08AM +0100, Matthias Klose wrote:

> > I don't think reverse depends will FTBFS. The problem is that the tests
> > (which are only run at build time and are not in any way included in the
> > binary packages) unconditionally #include <emmintr.h>. Could you try
> > removing those #includes from glm-0.9.5.0/test/gtx/*.cpp, and try building
> > again?
> 
> I don't think this would be the correct fix, because the include machinery
> provides several FORCE macros to support those targets as well.

The #include <emmintrin.h> does not #define any macro that changes the
behaviour in GLM. In fact, GLM itself checks for the presence of __SSE2__ and
automatically #includes <emmintrin.h> if possible.

Also, GLM version 0.9.4.6 did not #include <emmintrin.h> in its tests, and only
a few tests have the #include, I think it is just an oversight from the
upstream maintainer.

> Please check with a i386 chroot.

An i386 chroot won't do me any good as I only have processors that support
SSE2. It would be helpful if you could test the patch which I attached to this
email on your i386 system.

-- 
Met vriendelijke groet / with kind regards,
      Guus Sliepen <g...@debian.org>
--- a/test/gtx/gtx_associated_min_max.cpp
+++ b/test/gtx/gtx_associated_min_max.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/associated_min_max.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/associated_min_max.hpp>
--- a/test/gtx/gtx_bit.cpp
+++ b/test/gtx/gtx_bit.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/bit.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/gtx/bit.hpp>
 #include <glm/gtc/type_precision.hpp>
 
--- a/test/gtx/gtx_closest_point.cpp
+++ b/test/gtx/gtx_closest_point.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/associated_min_max.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/associated_min_max.hpp>
--- a/test/gtx/gtx_color_space.cpp
+++ b/test/gtx/gtx_color_space.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/color_space.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/color_space.hpp>
--- a/test/gtx/gtx_color_space_YCoCg.cpp
+++ b/test/gtx/gtx_color_space_YCoCg.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/color_space_YCoCg.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/color_space_YCoCg.hpp>
--- a/test/gtx/gtx_component_wise.cpp
+++ b/test/gtx/gtx_component_wise.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/component_wise.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/component_wise.hpp>
--- a/test/gtx/gtx_extented_min_max.cpp
+++ b/test/gtx/gtx_extented_min_max.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/associated_min_max.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/associated_min_max.hpp>
--- a/test/gtx/gtx_int_10_10_10_2.cpp
+++ b/test/gtx/gtx_int_10_10_10_2.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/associated_min_max.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/associated_min_max.hpp>
--- a/test/gtx/gtx_mixed_product.cpp
+++ b/test/gtx/gtx_mixed_product.cpp
@@ -7,8 +7,6 @@
 // File    : test/gtx/associated_min_max.cpp
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
-#include <emmintrin.h>
-
 #include <glm/glm.hpp>
 #include <glm/gtc/type_precision.hpp>
 #include <glm/gtx/associated_min_max.hpp>

Attachment: signature.asc
Description: Digital signature

Reply via email to