On Tue, Jun 03, 2014 at 10:50:06PM +0100, Deivi San wrote:
> After cleaning up comments and reconsidering all your recommendations
> I've recompiled and tested with versions 2.8 and 3.0 of the library
> (both available in testing) and it works fine. I've attached a new
> patch with comments removed, versions verified and null checks in
> place.
>
> wxWX2MBbuf is not wxString but a dual type macro so I have used
> casting instead of your proposal.
>
> The only doubt I hold is with function wxImage.ConvertAlphaToMask():
> In 2.8 code works well with package included tiles (a bmp without
> Alpha returns true). However, it fails when calling this function in
> 3.0 and previous img.HasAlpha() check is required.
> I guess it's an wxwidgets behavior change.
It is - in 2.8 the code looks like this:
bool wxImage::ConvertAlphaToMask(unsigned char threshold)
{
if ( !HasAlpha() )
return true;
But in 3.0, that same check returns "false" instead.
This is the ticket which motivated that change:
http://trac.wxwidgets.org/ticket/12637
So your change there is good.
> Anyway, now migration to wxwidgets3.0 is a step nearer.
Indeed - thank you very much. If you're interested in working on
patches for wx3 support in other packages, please feel free to.
Luke - I'm intending to NMU with this patch if I don't hear anything
from you shortly as the testing AUTORM is due to happen on June 18th.
If you want me to hold off, just let me know.
Cheers,
Olly
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
