Package: dns323-firmware-tools
Severity: serious
control: tags -1 + patch

The package is broken. With this patch I am able to flash dns-320

Thanks

Bastien
>From 0808621c890d9b7f312dc70f90ac757c9690a0ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastien=20ROUCARI=C3=88S?= <roucaries.bast...@gmail.com>
Date: Sun, 15 Jun 2014 21:09:16 +0200
Subject: [PATCH] Fix a brown paper bag bug

Apply type before any other option and rename an option to correct spelling
---
 dns323fw-tool | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/dns323fw-tool b/dns323fw-tool
index 01a3ec3..7c695fa 100755
--- a/dns323fw-tool
+++ b/dns323fw-tool
@@ -500,43 +500,43 @@ def mkdns323fw(args)
 	devices = {
 		'DNS-325' => {
 			:signature => 'DNS-325',
-			:prod_id   => 0,
+			:product_id   => 0,
 			:custom_id => 8,
 			:model_id  => 5
 		},
 		'DNS-323' => {
 			:signature => 'FrodoII',
-			:prod_id   => 7,
+			:product_id   => 7,
 			:custom_id => 1,
 			:model_id  => 1
 		},
 		'DNS-321' => {
 			:signature => 'Chopper',
-			:prod_id   => 10,
+			:product_id   => 10,
 			:custom_id => 1,
 			:model_id  => 1
 		},
 		'DNS-320' => {
 			:signature => 'DNS323D1',  # No, seriously...
-			:prod_id   => 0,
+			:product_id   => 0,
 			:custom_id => 8,
 			:model_id  => 7
 		},
 		'DNS-320B' => {
 			:signature => 'DNS320B',
-			:prod_id   => 0,
+			:product_id   => 0,
 			:custom_id => 8,
 			:model_id  => 12
 		},
 		'DNS-320L' => {
 			:signature => 'DNS320L',
-			:prod_id   => 0,
+			:product_id   => 0,
 			:custom_id => 8,
 			:model_id  => 11
 		},
 		'CH3SNAS' => {
 			:signature => 'FrodoII',
-			:prod_id   => 7,
+			:product_id   => 7,
 			:custom_id => 2,
 			:model_id  => 1
 		},
@@ -581,13 +581,13 @@ def mkdns323fw(args)
 
 	opts.parse(args)
 
-	opts = optargs
-
-	if optargs[:device]
-		optargs.merge(devices[optargs.delete(:device)])
+        if optargs[:device]
+          optargs = optargs.merge(devices[optargs.delete(:device)])
 	end
 
-	%w{kernel_file initrd_file output prod_id custom_id model_id}.each do |k|
+	opts = optargs
+
+	%w{kernel_file initrd_file output product_id custom_id model_id}.each do |k|
 		if opts[k.to_sym].nil?
 			$stderr.puts "Missing required argument #{k}"
 			exit 1
-- 
2.0.0

  • Bug#751713: [dns323-firmware-tools] Brown paper... bastien ROUCARIES

Reply via email to