Your message dated Sat, 05 Jul 2014 21:35:45 +0000 with message-id <e1x3xcx-0000k4...@franck.debian.org> and subject line Bug#751432: fixed in gdcm 2.4.2-1.1 has caused the Debian Bug report #751432, regarding gdcm: compatibility with poppler 0.26.x to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 751432: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751432 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: gdcm Version: 2.4.2-1 Severity: normal Tags: patch fixed-upstream Control: forwarded -1 http://sourceforge.net/p/gdcm/bugs/312/ Hi, gdcm 2.4.2-1 fails to build with Poppler 0.26.x (currently in experimental). The issue has been reported [1] and fixed upstream (for gdcm 2.4.3); in the meanwhile, would it be possible to backport the two upstream patches (which apply cleanly) for compatibility with Poppler 0.26.x? [1] http://sourceforge.net/p/gdcm/bugs/312/ Thanks, -- Pino>From 096e5b84d9e241b6e5203904846454f7d7058e01 Mon Sep 17 00:00:00 2001 From: Pino Toscano <toscano.p...@tiscali.it> Date: Sun, 6 Apr 2014 06:20:43 +0000 Subject: [PATCH] cmake: proper handle the extra poppler CFLAGS Make sure to join the extra CFLAGS with a space, otherwise they are passed as list to set_source_files_properties; also make sure to quote the string. --- Applications/Cxx/CMakeLists.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Applications/Cxx/CMakeLists.txt b/Applications/Cxx/CMakeLists.txt index 1c83bc3..714f5bc 100644 --- a/Applications/Cxx/CMakeLists.txt +++ b/Applications/Cxx/CMakeLists.txt @@ -79,12 +79,13 @@ if(GDCM_USE_SYSTEM_POPPLER) list(APPEND libpoppler_flags -DLIBPOPPLER_PDFDOC_HAS_PDFVERSION) endif() if(libpoppler_flags) + string(REPLACE ";" " " libpoppler_flags_string "${libpoppler_flags}") set_source_files_properties( ${CMAKE_CURRENT_SOURCE_DIR}/gdcminfo.cxx - PROPERTIES COMPILE_FLAGS ${libpoppler_flags}) + PROPERTIES COMPILE_FLAGS "${libpoppler_flags_string}") set_source_files_properties( ${CMAKE_CURRENT_SOURCE_DIR}/gdcmpdf.cxx - PROPERTIES COMPILE_FLAGS ${libpoppler_flags}) + PROPERTIES COMPILE_FLAGS "${libpoppler_flags_string}") endif() include_directories(${POPPLER_INCLUDE_DIRS}) set(GDCM_EXECUTABLE_NAME -- 2.0.0>From 1da0cab121782f1a63a84a9bcc90da6c337dc2e3 Mon Sep 17 00:00:00 2001 From: Pino Toscano <toscano.p...@tiscali.it> Date: Sun, 6 Apr 2014 06:23:46 +0000 Subject: [PATCH] gdcminfo: support poppler 0.25.1 Check for the new API of StructTreeRoot, adapting the check for a tagged PDF accordingly. Now Catalog::getStructTreeRoot() returns NULL if StructTreeRoot is not a dictionary. --- Applications/Cxx/CMakeLists.txt | 6 ++++++ Applications/Cxx/gdcminfo.cxx | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/Applications/Cxx/CMakeLists.txt b/Applications/Cxx/CMakeLists.txt index 714f5bc..9b4dd0e 100644 --- a/Applications/Cxx/CMakeLists.txt +++ b/Applications/Cxx/CMakeLists.txt @@ -78,6 +78,12 @@ if(GDCM_USE_SYSTEM_POPPLER) if(LIBPOPPLER_PDFDOC_HAS_PDFVERSION) list(APPEND libpoppler_flags -DLIBPOPPLER_PDFDOC_HAS_PDFVERSION) endif() + CHECK_CXX_SOURCE_COMPILES( + "\#include <poppler/PDFDoc.h>\n#include <poppler/StructTreeRoot.h>\nint main() { Catalog c(NULL); c.getStructTreeRoot()->getDoc(); return 0;}" + LIBPOPPLER_CATALOG_HAS_STRUCTTREEROOT) + if(LIBPOPPLER_CATALOG_HAS_STRUCTTREEROOT) + list(APPEND libpoppler_flags -DLIBPOPPLER_CATALOG_HAS_STRUCTTREEROOT) + endif() if(libpoppler_flags) string(REPLACE ";" " " libpoppler_flags_string "${libpoppler_flags}") set_source_files_properties( diff --git a/Applications/Cxx/gdcminfo.cxx b/Applications/Cxx/gdcminfo.cxx index 6f52cd9..9288ea6 100644 --- a/Applications/Cxx/gdcminfo.cxx +++ b/Applications/Cxx/gdcminfo.cxx @@ -471,7 +471,11 @@ static int ProcessOneFile( std::string const & filename, gdcm::Defs const & defs moddate = getInfoDate( info.getDict(), "ModDate" ); info.free(); } +#ifdef LIBPOPPLER_CATALOG_HAS_STRUCTTREEROOT + const char *tagged = doc->getStructTreeRoot() ? "yes" : "no"; +#else const char *tagged = doc->getStructTreeRoot()->isDict() ? "yes" : "no"; +#endif int pages = doc->getNumPages(); const char *encrypted = doc->isEncrypted() ? "yes" : "no"; // printf("yes (print:%s copy:%s change:%s addNotes:%s)\n", -- 2.0.0
--- End Message ---
--- Begin Message ---Source: gdcm Source-Version: 2.4.2-1.1 We believe that the bug you reported is fixed in the latest version of gdcm, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 751...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Pino Toscano <p...@debian.org> (supplier of updated gdcm package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Thu, 03 Jul 2014 22:34:02 +0200 Source: gdcm Binary: libgdcm2.4 libgdcm-tools libgdcm2-dev libgdcm2.4-dbg libgdcm-cil php5-gdcm libgdcm-java python-gdcm libvtkgdcm2.4 libvtkgdcm2-dev libvtkgdcm-cil php5-vtkgdcm libvtkgdcm-java python-vtkgdcm libvtkgdcm-tools gdcm-doc Architecture: source amd64 all Version: 2.4.2-1.1 Distribution: sid Urgency: medium Maintainer: Debian Med Packaging Team <debian-med-packag...@lists.alioth.debian.org> Changed-By: Pino Toscano <p...@debian.org> Description: gdcm-doc - Grassroots DICOM documentation libgdcm-cil - Grassroots DICOM CLI bindings libgdcm-java - Grassroots DICOM Java bindings libgdcm-tools - Grassroots DICOM tools and utilities libgdcm2-dev - Grassroots DICOM development libraries and headers libgdcm2.4 - Grassroots DICOM runtime libraries libgdcm2.4-dbg - Grassroots DICOM runtime libraries, debug version libvtkgdcm-cil - Grassroots DICOM VTK CLI bindings libvtkgdcm-java - Grassroots DICOM VTK Java bindings libvtkgdcm-tools - Grassroots DICOM VTK tools and utilities libvtkgdcm2-dev - Grassroots DICOM VTK development libraries and headers libvtkgdcm2.4 - Grassroots DICOM VTK runtime libraries php5-gdcm - Grassroots DICOM PHP5 bindings php5-vtkgdcm - Grassroots DICOM VTK PHP bindings python-gdcm - Grassroots DICOM Python bindings python-vtkgdcm - Grassroots DICOM VTK/Python bindings Closes: 751432 Changes: gdcm (2.4.2-1.1) sid; urgency=medium . * Non-maintainer upload. * Backport upstream commits 096e5b84d9e241b6e5203904846454f7d7058e01 and 1da0cab121782f1a63a84a9bcc90da6c337dc2e3 to support building with Poppler 0.26.x; patches upstream_cmake-proper-handle-the-extra-poppler-CFLAGS.patch and upstream_gdcminfo-support-poppler-0.25.1.patch. (Closes: #751432) Checksums-Sha1: e48563b7b3751e86293433c87c68912ccf1c33be 3073 gdcm_2.4.2-1.1.dsc 289b5566c9c983305b86a77bf1b90f10e1a03b30 18088 gdcm_2.4.2-1.1.debian.tar.xz 099b5df8284d9b11dc4422303f016c3f0034ae8a 1703214 libgdcm2.4_2.4.2-1.1_amd64.deb b1e9fc81fb682fff50886e5af0b6b8fb8218403a 446862 libgdcm-tools_2.4.2-1.1_amd64.deb 406cf2799eee4de1a20142afc2a18819eb31faad 254786 libgdcm2-dev_2.4.2-1.1_amd64.deb 9a651643a7572a357221eca44fde5eadcc47d4c8 28399694 libgdcm2.4-dbg_2.4.2-1.1_amd64.deb c08836760fe5df3b87b523a7b647900b0d0fb35c 269228 libgdcm-cil_2.4.2-1.1_amd64.deb 3b0079c0ce844424194a6bd05eb60930d30d5157 340208 php5-gdcm_2.4.2-1.1_amd64.deb e685668962041a0a1f4b0ca78e1fc62a8b052808 465654 libgdcm-java_2.4.2-1.1_amd64.deb 6bbce99f39a4a6c65d4868d5d066934c786038f1 587026 python-gdcm_2.4.2-1.1_amd64.deb ddae55aac377140ba44a358d53cd520a162cacad 238222 libvtkgdcm2.4_2.4.2-1.1_amd64.deb dcc3f76d9700b96c9a32449683b03dd14af32604 26106 libvtkgdcm2-dev_2.4.2-1.1_amd64.deb 996443f8b755a132fcdf36599451fbe1ab86bf57 75652 libvtkgdcm-cil_2.4.2-1.1_amd64.deb 9e9524d57b8a4f1b74ec9d496516001af9af5a9b 203868 php5-vtkgdcm_2.4.2-1.1_amd64.deb b3f2e7878abc47551a9f491f79658455dbad520b 73346 libvtkgdcm-java_2.4.2-1.1_amd64.deb 5568c32f4fcf280f4235c992f840f56e1aa726e1 93956 python-vtkgdcm_2.4.2-1.1_amd64.deb 4bab45b43c989c07a56ce0f25890cb0decac9443 44036 libvtkgdcm-tools_2.4.2-1.1_amd64.deb 3a8efc2dd2e0adb651a78f3ef69a8192d75be335 13926322 gdcm-doc_2.4.2-1.1_all.deb Checksums-Sha256: 1cc4934856d6f7e705ae98700684a68aeff093c8830879e82aa5712c0683a2bd 3073 gdcm_2.4.2-1.1.dsc e2e7ecad57dc9e6be816fdaaa54e9eaa057dd742074ffe27ec12e6dffda9d5fd 18088 gdcm_2.4.2-1.1.debian.tar.xz 2859c5ac0c052b39466eee3ecaf3e1d33524db004a7b0a389c47b408a4449b87 1703214 libgdcm2.4_2.4.2-1.1_amd64.deb 1260420e662cfe6fc78b61153baff2e7a22536978f717e6c37753ea1b340cf9f 446862 libgdcm-tools_2.4.2-1.1_amd64.deb 5dcb55d30da7f086e5aa64d1776b6ce64a1a1768270c3c7212d71956701bcb36 254786 libgdcm2-dev_2.4.2-1.1_amd64.deb b6265a761c99a572583d434e9d8e230ad14f6d18d235ad221fcd97cfeb2e2f38 28399694 libgdcm2.4-dbg_2.4.2-1.1_amd64.deb 89f4a0598dac68d613d830de06c238cfc973dc5c4801cc3d9ebdcd44583ecaef 269228 libgdcm-cil_2.4.2-1.1_amd64.deb afce6b6ad242926d5e8017542488855e6569debb1d8dd27f8e030da0a8b770e3 340208 php5-gdcm_2.4.2-1.1_amd64.deb d17174ac11e3807ea5b50a6230d1f791fc0e2ed6a15bfa27c7231912f5ec2949 465654 libgdcm-java_2.4.2-1.1_amd64.deb 1fc5e69e9b87cd66364042066d91c9e06c176cf55d04070252bc12683a1e36a2 587026 python-gdcm_2.4.2-1.1_amd64.deb 193f9a15c350c5598d7f18ba25c92a3e78f88dc79e445a3e3af88e3e38ddd3e9 238222 libvtkgdcm2.4_2.4.2-1.1_amd64.deb 62a0b76b8fef71bf1813a88ef165f152f3d6a50cd171303d263dd0128b6ec7b4 26106 libvtkgdcm2-dev_2.4.2-1.1_amd64.deb 3b9b6963ff86bdb5d441c3d5f11a8bee4ea51e45588928c4fd9189bab24ba6b1 75652 libvtkgdcm-cil_2.4.2-1.1_amd64.deb afd98eb7ae6ec711d681c3efd8c1211404714c82ed3a1b923911202060ee85a5 203868 php5-vtkgdcm_2.4.2-1.1_amd64.deb e26d10f907f7ad4ce57473a1fab899a52909dc10ab391f65aa31d4d26cde08ff 73346 libvtkgdcm-java_2.4.2-1.1_amd64.deb a367fc1be4c7d3713a1eaf59c9d95b46012a884b39b790df6a3e8b366cf9afb7 93956 python-vtkgdcm_2.4.2-1.1_amd64.deb 51ba06e14d78658e5da7057d8ffc1f1b6169b200137fc2ceac479c1a54090a3a 44036 libvtkgdcm-tools_2.4.2-1.1_amd64.deb b9e0f20b8677f04581ed72ed01269042c4349ebe0b1dece15c766e1eb381fde9 13926322 gdcm-doc_2.4.2-1.1_all.deb Files: c28322886b8d021aa54a37dd46820da5 1703214 libs optional libgdcm2.4_2.4.2-1.1_amd64.deb 465ec06f264322a0249c21da84f84287 446862 utils optional libgdcm-tools_2.4.2-1.1_amd64.deb 2ed397f95e52ccba413ce1a7e1b05ff8 254786 libdevel optional libgdcm2-dev_2.4.2-1.1_amd64.deb 484d55f2d3e1bef8823972aeda28faa2 28399694 debug extra libgdcm2.4-dbg_2.4.2-1.1_amd64.deb b04130e0284ac0b9196e088de18acdd3 269228 cli-mono optional libgdcm-cil_2.4.2-1.1_amd64.deb 1bf3d71424bb6e78ba63607adbba514c 340208 php optional php5-gdcm_2.4.2-1.1_amd64.deb 274d026ff3fab51fdf65df4e1df3bbbf 465654 java optional libgdcm-java_2.4.2-1.1_amd64.deb 73beee366e3b416286a2390a9e7d6002 587026 python optional python-gdcm_2.4.2-1.1_amd64.deb a85dc662cb5ab355adc26d5f08001c49 238222 libs optional libvtkgdcm2.4_2.4.2-1.1_amd64.deb f38f3e018c4dde6d0dc7d258e149cca3 26106 libdevel optional libvtkgdcm2-dev_2.4.2-1.1_amd64.deb a0688e06c6a13d69602c7461a8e4f1c0 75652 cli-mono optional libvtkgdcm-cil_2.4.2-1.1_amd64.deb a7d80a2f5b267093c4999ce2e9489069 203868 php optional php5-vtkgdcm_2.4.2-1.1_amd64.deb fa6136000d4a169b698b6c78b9eb2837 73346 java optional libvtkgdcm-java_2.4.2-1.1_amd64.deb 95f48e1abdd104643b541b986fa08306 93956 python optional python-vtkgdcm_2.4.2-1.1_amd64.deb c03fa1dc69cbe3c19047c3ae4f33a2ab 44036 utils optional libvtkgdcm-tools_2.4.2-1.1_amd64.deb a06e909dd3a21d185ec9ac9f5ac70f4b 13926322 doc optional gdcm-doc_2.4.2-1.1_all.deb 7d5908f44f6c19ad2b86f183344c0556 3073 libs optional gdcm_2.4.2-1.1.dsc d10c50c35541bcddccf239b7c4ec99d8 18088 libs optional gdcm_2.4.2-1.1.debian.tar.xz -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iD8DBQFTtcQqTNH2piB/L3oRAkV0AKCZDIy/W0aoG4z1SHaHj/e9eaHkNACgzuAy ur3SP+DKZJ1YuAQo15tziaw= =dFA3 -----END PGP SIGNATURE-----
--- End Message ---
