Package: turnserver
Version: 0.7.3-2
Severity: critical
Tags: patch
At the moment, turnserver doesn't build on ppc64el platform with the following
error:
In file included from tls_peer.c:72:0:
/usr/include/netinet/tcp.h:89:11: error: duplicate member 'th_off'
u_int8_t th_off:4; /* data offset */
^
/usr/include/netinet/tcp.h:90:11: error: duplicate member 'th_x2'
u_int8_t th_x2:4; /* (unused) */
https://buildd.debian.org/status/fetch.php?pkg=turnserver&arch=ppc64el&ver=0.7.3-2&stamp=1410498176
That is because both path of the following are being executed:
# if __BYTE_ORDER == __BIG_ENDIAN
u_int8_t th_off:4; /* data offset */
u_int8_t th_x2:4; /* (unused) */
# endif
# if __BYTE_ORDER == __LITTLE_ENDIAN
u_int8_t th_x2:4; /* (unused) */
u_int8_t th_off:4; /* data offset */
# endif
This is because SVID_SOURCE is being used, and it is deprecated. The proper way
is to use _DEFAULT_SOURCE, which fixes the problem above.
Thanks
Breno
--- turnserver-0.7.3.orig/src/Makefile.am
+++ turnserver-0.7.3/src/Makefile.am
@@ -1,4 +1,4 @@
-AM_CFLAGS = -std=c99 -Wall -Wextra -Werror -Wstrict-prototypes -Wredundant-decls -Wshadow -pedantic -fno-strict-aliasing -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -O2 -D_SVID_SOURCE
+AM_CFLAGS = -std=c99 -Wall -Wextra -Werror -Wstrict-prototypes -Wredundant-decls -Wshadow -pedantic -fno-strict-aliasing -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -O2 -D_DEFAULT_SOURCE
if ENABLE_DEBUG_BUILD
AM_CFLAGS += -g
--- turnserver-0.7.3.orig/src/Makefile.in
+++ turnserver-0.7.3/src/Makefile.in
@@ -288,7 +288,7 @@ top_srcdir = @top_srcdir@
AM_CFLAGS = -std=c99 -Wall -Wextra -Werror -Wstrict-prototypes \
-Wredundant-decls -Wshadow -pedantic -fno-strict-aliasing \
-D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -O2 \
- -D_SVID_SOURCE $(am__append_1) $(am__append_2)
+ -D_DEFAULT_SOURCE $(am__append_1) $(am__append_2)
INCLUDE = -I.
noinst_HEADERS = turnserver.h \
turn.h \
