Your message dated Thu, 27 Nov 2014 05:18:55 +0000 with message-id <[email protected]> and subject line Bug#770174: fixed in salt 2014.1.13+ds-2 has caused the Debian Bug report #770174, regarding salt-common: service module doesn't work for init scripts to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 770174: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770174 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: salt-common Version: 2014.1.13+ds-1 Severity: grave Tags: patch upstream fixed-upstream Justification: renders package unusable Hi, when booting with systemd, the service module is provided by salt/modules/systemd.py, which only considers native systemd units in its get_all function, not services provided by init scripts. This breaks the service state. The fix is in upstream commits 90bece1faa1862465e97f7caf262c65cd84583ff and 968b26f45351d790a9fa2afd9bbd6c5bb31f13d5, so basically: diff --git a/salt/modules/systemd.py b/salt/modules/systemd.py --- a/salt/modules/systemd.py +++ b/salt/modules/systemd.py @@ -72,6 +74,28 @@ def _systemctl_cmd(action, name): return 'systemctl {0} {1}'.format(action, _canonical_unit_name(name)) +def _get_all_units(): + ''' + Get all units and their state. Units ending in .service + are normalized so that they can be referenced without a type suffix. + ''' + rexp = re.compile(r'(?m)^(?P<name>.+)\.(?P<type>' + + '|'.join(VALID_UNIT_TYPES) + + r')\s+loaded\s+(?P<active>[^\s]+)') + + out = __salt__['cmd.run_stdout']( + 'systemctl --all --full --no-legend --no-pager list-units | col -b' + ) + + ret = {} + for match in rexp.finditer(out): + name = match.group('name') + if match.group('type') != 'service': + name += '.' + match.group('type') + ret[name] = match.group('active') + return ret + + def _get_all_unit_files(): ''' Get all unit files and their state. Unit files ending in .service @@ -173,7 +197,7 @@ def get_all(): salt '*' service.get_all ''' - return sorted(_get_all_unit_files().keys()) + return sorted(set(_get_all_units().keys() + _get_all_unit_files().keys())) def available(name): There are a few other fixes in that file that might be worth considering, but at least the above is I think necessary for salt to be in decent shape for jessie. Cheers, Julien -- Julien Cristau <[email protected]> Logilab http://www.logilab.fr/ Informatique scientifique & gestion de connaissances
--- End Message ---
--- Begin Message ---Source: salt Source-Version: 2014.1.13+ds-2 We believe that the bug you reported is fixed in the latest version of salt, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Joe Healy <[email protected]> (supplier of updated salt package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Thu, 27 Nov 2014 15:49:13 +1100 Source: salt Binary: salt-common salt-master salt-minion salt-syndic salt-ssh salt-doc salt-cloud Architecture: source all Version: 2014.1.13+ds-2 Distribution: unstable Urgency: medium Maintainer: Debian Salt Team <[email protected]> Changed-By: Joe Healy <[email protected]> Description: salt-cloud - public cloud VM management system salt-common - shared libraries that salt requires for all packages salt-doc - additional documentation for salt, the distributed remote executi salt-master - remote manager to administer servers via salt salt-minion - client package for salt, the distributed remote execution system salt-ssh - remote manager to administer servers via salt salt-syndic - master-of-masters for salt, the distributed remote execution syst Closes: 770174 770909 Changes: salt (2014.1.13+ds-2) unstable; urgency=medium . * [da66ee3] Addition of patch to ensure systemd service functionality works (Closes: 770174) * [6a17bb9] Added patch to prevent crash when unicode text is output from salt (Closes: 770909) Checksums-Sha1: 662e5ac23e310e4812f99e9ddce2e775deb48513 2440 salt_2014.1.13+ds-2.dsc 87acac8591f3bebcd0ff883b6df9b3a3099cc82a 24064 salt_2014.1.13+ds-2.debian.tar.xz 7e53d056348d8b0cdaa58825fdab3bae600ef00e 1360370 salt-common_2014.1.13+ds-2_all.deb 95c6e656b32c71e45985ebf78a8ce33801e8884e 35430 salt-master_2014.1.13+ds-2_all.deb 8aa43d17e7cfe3a025febf10c0f913ce12908660 26378 salt-minion_2014.1.13+ds-2_all.deb fb92799ba7e665b7af8148414cd13a9f819adf91 19156 salt-syndic_2014.1.13+ds-2_all.deb 0eae486780d4442480539907b2d3ce857c0f511c 18806 salt-ssh_2014.1.13+ds-2_all.deb 918641c326b2f2a1845c8f3ff048f5726c47f636 1517210 salt-doc_2014.1.13+ds-2_all.deb 305eebaf1b271a9bfa37501dae54080252aaa1dd 18590 salt-cloud_2014.1.13+ds-2_all.deb Checksums-Sha256: 3d9e1344acca59e4ea995b18ee271659da2e842d52eff1d353dbec348083cf1c 2440 salt_2014.1.13+ds-2.dsc 18aeacaacdb4f8846c10037dead8854d92524d60ec5287bd764721cddfdec8ac 24064 salt_2014.1.13+ds-2.debian.tar.xz bd6ede57911c0368f75140b3d9747a96889226fb13219bf18125ba6be12fbf50 1360370 salt-common_2014.1.13+ds-2_all.deb 870f19043b85434453f344bc63fc8f44a14037736cd69f4cb235200723a517be 35430 salt-master_2014.1.13+ds-2_all.deb b9a1cf9bee54a1ca455ec1551fec837feba5c68041510f120df8d36c4ee09c0c 26378 salt-minion_2014.1.13+ds-2_all.deb 7d403adf890d41fb74a2a321acd5d2dca9e42b42cc6a4fb8859c566f635c81a3 19156 salt-syndic_2014.1.13+ds-2_all.deb 2cdd9444ab0506572553e05be68a7fea5359e52867b404dbcb0e77f453b243fd 18806 salt-ssh_2014.1.13+ds-2_all.deb 26a6bc4b42ea5c74379fe2263169ec4e37ca621c80bb35b79743414d2b350b0c 1517210 salt-doc_2014.1.13+ds-2_all.deb 1cf63d5d2c6c94b80079971f231a406d32270fae8b8cb40067670eba1340d0d6 18590 salt-cloud_2014.1.13+ds-2_all.deb Files: 769cc188e8c628806ef04f4df74e5904 2440 admin extra salt_2014.1.13+ds-2.dsc ed0a053543cbea3c438a3348b522ccc7 24064 admin extra salt_2014.1.13+ds-2.debian.tar.xz 0d6aa8fa15d20a3eda13497fb91c99e7 1360370 admin extra salt-common_2014.1.13+ds-2_all.deb 2c15faeeda863774cb2535f52631aef6 35430 admin extra salt-master_2014.1.13+ds-2_all.deb 0d4784667ef254cb0ec8816cc3fa20dd 26378 admin extra salt-minion_2014.1.13+ds-2_all.deb 2664e80830a611b5621480d63a29a809 19156 admin extra salt-syndic_2014.1.13+ds-2_all.deb 266561715a3bbf4be275c6af41c2736f 18806 admin extra salt-ssh_2014.1.13+ds-2_all.deb 7c4151b3cc9f9f8efb96d5c4867d1e4d 1517210 doc extra salt-doc_2014.1.13+ds-2_all.deb d14900ef56838e7e2c9e089c72a8045e 18590 admin extra salt-cloud_2014.1.13+ds-2_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJUdrJjAAoJELCeQLDyrmq5+UgQAJvd9S/kRxhFYeciXD8lJief k4pUGF0VSVjiuZeAs2gby9K5KCnC+Rvohj0WD6PdokI74Aieuxseb3WgTcJGL/8y v6rNZFLsqCDLWICyJk9/ewntW/PMU3+Wo90vL2mNeW+aFICzFeilDHz0869Q0xem POT8WmH2n0Z0RjWjem9sWzYA3rUzDx0JlIGjYf358EgeRuxrZZnGgBd0Rvc7RDaG sMdfvzuR7VIt9Xt3iYEPxfZjTNRrHSJEdeqA5jXVclwUd258xK4IdaX4EcFQVlxi vvLFfcIwCB/DL32UAynCaGfLSv6+jUSQM9O+4fuGCBR8NnW7vzGO10gRhJe5bMcb g3itC0lXcQf7sLbHnrqYVQqliZx0FcqVlwJH9H7B0ReLbhSO4RLwZf4rnxFo4a+S rgEjhwXZVDnM+PfdLl0obCKX0CNmewHtaA8IyS/qg3iU4Vp06P6lNqhF7zaT5gDb nwj4h+hRjt9tZmbVVU69tE21L4ySuWuClJuMr88f8cdE6b7YnZdXUFlNj5rbckqt JoFdQnBX6amlhBXQ96XVqkTe7JzNhEG56dgC9McLQpo1NbAzT4YAPNw1unWfY/nR q/uEfxVkJ0MzeiF9N/OleB5P9ZhzaxH7Mh6j6D/SngStb5udW68R1tteFrwouebs yaUu29ogIQJy8YAsIYQl =+3xF -----END PGP SIGNATURE-----
--- End Message ---
