Package: simpleburn
Severity: serious
Version: 1.7.0-1
User: debian-rele...@lists.debian.org
Usertags: goal-dash
Hi,
I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".
checkbashisms' output:
> possible bashism in ./usr/bin/simpleburn.sh line 3 ('function' is
useless):
> function printusage() {
> possible bashism in ./usr/bin/simpleburn.sh line 8 (echo -e):
> echo -e "usage: $0 [CD/DVD device] extract
> /path/to/audio_dir\n\t[format(wav|flac|ogg|mp3)\n\t\t[tracks(1,2,4-6,...)]\
> n\t]"
> possible bashism in ./usr/bin/simpleburn.sh line 9 (echo -e):
> echo -e "usage: $0 [CD/DVD device] extract /path/to/video_file
> title\n\t[quality(high|normal)\n\t\t[language(country-
code/aid)\n\t\t\t[sub
> titles(-1|country-
code/sid)\n\t\t\t\t[cropinfos(W:H:X:Y)]\n\t\t\t]\n\t\t]\n
> \t]"
> possible bashism in ./usr/bin/simpleburn.sh line 11 (echo -e):
> echo -e "usage: $0 [CD/DVD device] burn /path/to/audio_dir"
> possible bashism in ./usr/bin/simpleburn.sh line 20 ('function' is
> useless):
> function extractiso() {
> possible bashism in ./usr/bin/simpleburn.sh line 24 (let ...):
> let blockscount=mediasize/2048
> possible bashism in ./usr/bin/simpleburn.sh line 25 (let ...):
> let tracksize=mediasize/1024
> possible bashism in ./usr/bin/simpleburn.sh line 29 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then { sleep 5; simpleburn-gauges.sh dd
> $tracksize $LOCKFILE "$destination"; } & fi
> possible bashism in ./usr/bin/simpleburn.sh line 37 ('function' is
> useless):
> function expandtracks() {
> possible bashism in ./usr/bin/simpleburn.sh line 46 ('((' should be
'$(('):
> for ((i=firsttrack; i<=lasttrack; i++)); do
> possible bashism in ./usr/bin/simpleburn.sh line 62 ('function' is
> useless):
> function extractaudio() {
> possible bashism in ./usr/bin/simpleburn.sh line 69 (echo -e):
> tracklength=`echo -e $mediainfos | grep "^$track;" | cut
> -f3 -d';'`
> possible bashism in ./usr/bin/simpleburn.sh line 72 (let ...):
> let seconds=minutes*60+seconds
> possible bashism in ./usr/bin/simpleburn.sh line 74 (let ...):
> let total=total+seconds
> possible bashism in ./usr/bin/simpleburn.sh line 78 (let ...):
> let totaldone=0
> possible bashism in ./usr/bin/simpleburn.sh line 80 (let ...):
> let previouspercent=totaldone*100/total
> possible bashism in ./usr/bin/simpleburn.sh line 81 (let ...):
> let trackpercent=lengths[$track]*100/total
> possible bashism in ./usr/bin/simpleburn.sh line 82 (echo -e):
> title="$track-"`echo -e $mediainfos | grep "^$track;" | cut
> -f2 -d';' | sed 's@/@-@g'`
> possible bashism in ./usr/bin/simpleburn.sh line 83 ('((' should be
'$(('):
> if (( $track < 10 )); then title="0$title"; fi
> possible bashism in ./usr/bin/simpleburn.sh line 85 (should be 'b = a'):
> "wav") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 88 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 88 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 94 (should be 'b = a'):
> "flac") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 97 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 97 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 100 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 100 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 103 (should be 'b = a'):
> "ogg") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 106 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 106 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 109 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 109 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 112 (should be 'b = a'):
> "mp3") if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 115 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 115 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 118 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 118 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 122 (let ...):
> let totaldone=totaldone+lengths[$track]
> possible bashism in ./usr/bin/simpleburn.sh line 130 ('function' is
> useless):
> function extractvideo() {
> possible bashism in ./usr/bin/simpleburn.sh line 147 (echo -e):
> titleinfos=`echo -e $mediainfos | grep "^$title;"`
> possible bashism in ./usr/bin/simpleburn.sh line 152 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 156 (should be 'b = a'):
> if [ "$subtitles" == "-1" ]
> possible bashism in ./usr/bin/simpleburn.sh line 161 (should be 'b = a'):
> if [ "$quality" == "normal" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 168 (let ...):
> let totalrate=(audiorate+videorate)*1000/8 #kbits -> bytes
> possible bashism in ./usr/bin/simpleburn.sh line 169 (let ...):
> let totalsize=length*totalrate
> possible bashism in ./usr/bin/simpleburn.sh line 175 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then { sleep 5; simpleburn-gauges.sh
> mencoder $totalsize 1 $LOCKFILE-1 "$destination"; } & fi
> possible bashism in ./usr/bin/simpleburn.sh line 183 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then { sleep 5; simpleburn-gauges.sh
> mencoder $totalsize 2 $LOCKFILE-2 "$destination"; } & fi
> possible bashism in ./usr/bin/simpleburn.sh line 190 (should be 'b = a'):
> if [ "$subtitles" == "-1" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 191 (brace expansion):
> rm -f nosubs.{idx,sub}
> possible bashism in ./usr/bin/simpleburn.sh line 199 ('function' is
> useless):
> function burniso() {
> possible bashism in ./usr/bin/simpleburn.sh line 204 (let ...):
> let tracksize=tracksize/1048576 #MB
> possible bashism in ./usr/bin/simpleburn.sh line 205 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 207 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 207 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 216 ('function' is
> useless):
> function burnaudio() {
> possible bashism in ./usr/bin/simpleburn.sh line 240 (let ...):
> let audiosize=audiosize/1048576
> possible bashism in ./usr/bin/simpleburn.sh line 242 (let ...):
> let totalsize=totalsize+audiosize
> possible bashism in ./usr/bin/simpleburn.sh line 244 (let ...):
> let totalsize=totalsize*913046 #1024x1024x2048/2352
> possible bashism in ./usr/bin/simpleburn.sh line 245 ('((' should be
> '$(('):
> if (( $totalsize > $mediacapacity )); then #final check due to
> conversion
> possible bashism in ./usr/bin/simpleburn.sh line 253 ($PIPESTATUS):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 253 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}
> possible bashism in ./usr/bin/simpleburn.sh line 259 ('function' is
> useless):
> function burndata() {
> possible bashism in ./usr/bin/simpleburn.sh line 265 (let ...):
> let tracksize=tsize/512 #blocks => MB
> possible bashism in ./usr/bin/simpleburn.sh line 266 (should be 'b = a'):
> if [ "$opt" == "-cr" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 268 ($PIPESTATUS):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 268 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 271 ($PIPESTATUS):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 271 (bash arrays,
> ${name[0|*|@]}):
> status=${PIPESTATUS[0]}&&${PIPESTATUS[1]}
> possible bashism in ./usr/bin/simpleburn.sh line 286 (should be 'b = a'):
> if [ "$1" == "--help" ] || [ "$1" == "-h" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 291 (should be 'b = a'):
> if [ "$1" == "-cr" ]; then opt="-cr"; shift; fi
> possible bashism in ./usr/bin/simpleburn.sh line 298 (should be '.', not
> 'source'):
> source simpleburn-detect.sh $device
> possible bashism in ./usr/bin/simpleburn.sh line 319 (should be 'b = a'):
> if [ "$mediatype" == "none" ] || [ "$mediacontent" ==
> "blank" ] || [ "$mediacontent" == "udf" ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 327 (should be 'b = a'):
> if [ -z "$audio" ]; then if [ "$LANG" ==
> "C" ]; then audio="en"; else audio=`echo $LANG | cut -c1-2`; fi; fi
> possible bashism in ./usr/bin/simpleburn.sh line 333 (echo -e):
> titleinfos=`echo -e $mediainfos | grep
> "^$title;"`
> possible bashism in ./usr/bin/simpleburn.sh line 359 ('((' should be
> '$(('):
> if (( $track < 1 )) || (( $track >
> $trackscount )); then echo "error: track '$track' not available"; exit 3;
> fi
> possible bashism in ./usr/bin/simpleburn.sh line 377 ('((' should be
> '$(('):
> if [ "$mediacontent" != "blank" ] && (( rewritablemedia ==
> 0 )); then
> possible bashism in ./usr/bin/simpleburn.sh line 391 ('((' should be
> '$(('):
> if [ "$mediatype" != "dvd" ] && (( `ls -l
> "$source"/*.wav 2>/dev/null | wc -l` != 0 )); then
> possible bashism in ./usr/bin/simpleburn.sh line 392 (let ...):
> let datasize=datasize*2048/2352
> possible bashism in ./usr/bin/simpleburn.sh line 395 ('((' should be
> '$(('):
> if (( $datasize > $mediacapacity )); then
> possible bashism in ./usr/bin/simpleburn.sh line 405 (should be 'b = a'):
> if [ "$mediacontent" != "blank" ] && [ "$mediatype" == "cd"
> ]; then
> possible bashism in ./usr/bin/simpleburn.sh line 411 ('((' should be
> '$(('):
> if [ "$mediatype" == "dvd" ] || (( `ls -l
> "$source"/*.wav 2>/dev/null | wc -l` == 0 ))
> possible bashism in ./usr/bin/simpleburn.sh line 411 (should be 'b = a'):
> if [ "$mediatype" == "dvd" ] || (( `ls -l
> "$source"/*.wav 2>/dev/null | wc -l` == 0 ))
> possible bashism in ./usr/bin/simpleburn.sh line 429 ('function' is
> useless):
> function listps () {
> possible bashism in ./usr/bin/simpleburn-detect.sh line 3 ('function' is
> useless):
> function detect() {
> possible bashism in ./usr/bin/simpleburn-detect.sh line 25 (let ...):
> let mediacapacity=mediacapacity*2048
> possible bashism in ./usr/bin/simpleburn-detect.sh line 34 (let ...):
> let minutes=titlelenght/60
> possible bashism in ./usr/bin/simpleburn-detect.sh line 35 ('((' should be
> '$(('):
> if (( minutes > 3 )); then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 36 ('((' should be
> '$(('):
> if (( $titlenum != 1 ));
> then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 40 (let ...):
> let
> trackscount=trackscount+1
> possible bashism in ./usr/bin/simpleburn-detect.sh line 61 (should be 'b =
> a'):
> if [ "$id"
> == "ID_AID" ]
> possible bashism in ./usr/bin/simpleburn-detect.sh line 79 (let ...):
> let
> mediacapacity=mediacapacity*2048
> possible bashism in ./usr/bin/simpleburn-detect.sh line 84 (let ...):
> let mediasize=mediasize*2048
> possible bashism in ./usr/bin/simpleburn-detect.sh line 88 ('((' should be
> '$(('):
> for (( i=1; i<=$n; i++ )); do
> possible bashism in ./usr/bin/simpleburn-detect.sh line 108 (let ...):
> let mediasize_=mediasize/1048576
> possible bashism in ./usr/bin/simpleburn-detect.sh line 109 (let ...):
> let mediacapacity_=mediacapacity/1048576
> possible bashism in ./usr/bin/simpleburn-detect.sh line 125 (should be 'b
=
> a'):
> if [ "$1" == "--help" ] || [ "$1" == "-h" ]; then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 130 (should be 'b
=
> a'):
> if [ "$1" == "-cr" ]; then opt="-cr"; shift; fi
> possible bashism in ./usr/bin/simpleburn-detect.sh line 148 (should be 'b
=
> a'):
> if [ `basename "'$0"` == "simpleburn-detect.sh" ]; then
> possible bashism in ./usr/bin/simpleburn-detect.sh line 150 (should be 'b
=
> a'):
> if [ "$opt" == "-cr" ]
> possible bashism in ./usr/bin/simpleburn-detect.sh line 152 (echo -e):
> echo -e $mediainfos
> possible bashism in ./usr/bin/simpleburn-detect.sh line 155 (echo -e):
> echo -e $detailedinfos
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 3 ('function' is
> useless):
> function mencodergauge () {
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 9 ('((' should be
> '$(('):
> if (( $pass == 0 ))
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 13 ('((' should be
> '$(('):
> if (( $pass == 1 ))
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 21 (let ...):
> let percent=(currentsize*passpercent/totalsize)+cumul
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 28 ('function' is
> useless):
> function ddgauge() {
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 35 (let ...):
> let filesize=filesize/1024
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 36 (let ...):
> let percent=(filesize*100)/totalsize
> possible bashism in ./usr/bin/simpleburn-gauges.sh line 37 (let ...):
> let percent=percent%100
Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.
Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.
Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh
Thanks in advance,
Raphael Geissert
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
