Your message dated Sat, 13 Dec 2014 09:45:05 +0100
with message-id <548bfc91.20...@thykier.net>
and subject line Re: Bug#772692: tau: More bashisms
has caused the Debian Bug report #772692,
regarding tau: More bashisms
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
772692: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772692
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: tau
Version: 2.17.3.1.dfsg-4
Severity: serious
Hi,
I saw you uploaded a new version of tau to fix bashisms. Unfortunately,
there are still some left.
E.g. in echoIfVerbose (tools/src/tau_compiler.sh)
"""
+ if [ $isDebug == $TRUE ] || [ $isVerbose == $TRUE ]; then
"""
Which should have been using only one "=" in each of the [ ].
I think the safe choice for Jessie would be to mark any remaining
scripts with bashisms as bash scripts. You can always properly fix them
in Stretch.
~Niels
--- End Message ---
--- Begin Message ---
On 2014-12-13 09:25, Yann Dirson wrote:
> On Wed, Dec 10, 2014 at 06:50:07AM +0100, Niels Thykier wrote:
>> Package: tau
>> Version: 2.17.3.1.dfsg-4
>> Severity: serious
>>
>> Hi,
>>
>>[...]
>
> I'm a bit confused here: tools/src/tau_compiler.sh has been using bash
> upstream since ages, and checkbashisms accordingly does not complain
> on that file. I've been touching it in the "Replace 'echo -e'" patch
> solely because I let sed do the work and did not bother checking that
> it was absolutely necessary in all of the impacted scripts. I could
> possibly remove that useless part of the patch to be on the extra-safe
> side, but that seems unnecessary.
>
> OK to close this bug ?
>
>[...]
> Best regards,
> --
> Yann
>
Hi Yann,
Sounds like I made a mistake then - sorry for the inconvenience. :)
I based my report on the debdiff between the previous and the current
version. It does not include the #!-header of the scripts and I assumed
you had only changed /bin/sh scripts (which turned out to be a flawed
assumption).
Apologies,
~Niels
--- End Message ---
