Your message dated Mon, 23 Feb 2015 19:33:52 +0000
with message-id <[email protected]>
and subject line Bug#776145: fixed in gtk-sharp2 2.12.10-5.1
has caused the Debian Bug report #776145,
regarding GLib-CRITICAL spam on STDERR
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
776145: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776145
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libglib2.0-cil
Severity: serious
[this is a shortened version of my original report that was eaten by
reportbug which deserves a critical bugreport for the data loss]
Since a change in glib warnings are printed to STDERR for /each/
g_source_remove call if the item wasn't in the list. This can lead to
serious hardware resource usage (see below), thus severity set to
serious.
Example of such message:
(smuxi-frontend-gnome:4942): GLib-CRITICAL **: Source ID 3462469 was
not found when attempting to remove it
meebey@redhorse:~$ ls -lh ~/.cache/gdm/session.log
-rw------- 1 meebey meebey 130M 2015-01-24 12:16
/home/meebey/.cache/gdm/session.log
meebey@redhorse:~$ grep -c -F 'GLib-CRITICAL **: Source ID'
/home/meebey/.cache/gdm/session.log
1194536
--
Best regards,
Mirco 'meebey' Bauer
FOSS Developer [email protected] https://www.meebey.net/
Debian Developer [email protected] http://www.debian.org/
GNOME Foundation Member [email protected] http://www.gnome.org/
PGP-Key ID 0xEEF946C8 https://meebey.net/pubkey.asc
commit 3a01260d87c738361f1b72673f73135b4d7545e7
Author: Bertrand Lorentz <[email protected]>
Date: Sat Jul 5 15:52:56 2014 +0200
glib: Fix native GLib warnings when disposing SourceProxy objects
When an instance of SourceProxy was finalized, we would try to remove
the corresponding source, even if it was already removed. This now
causes native GLib to print out warnings because it can't find the
source ID.
Now Source.Remove only calls g_source_remove if we really had a handler
registered for the ID we're removing.
diff --git a/glib/Source.cs b/glib/Source.cs
index b62c3c5..89e691f 100644
--- a/glib/Source.cs
+++ b/glib/Source.cs
@@ -54,9 +54,15 @@ namespace GLib {
public static bool Remove (uint tag)
{
- lock (Source.source_handlers)
- source_handlers.Remove (tag);
- return g_source_remove (tag);
+ // g_source_remove always returns true, so we follow that
+ bool ret = true;
+
+ lock (Source.source_handlers) {
+ if (source_handlers.Remove (tag)) {
+ ret = g_source_remove (tag);
+ }
+ }
+ return ret;
}
}
}
commit 9c78f7019c8622a3fc7a10c3d3dc8dcb5f44a289
Author: Cody Russell <[email protected]>
Date: Fri Jul 11 09:51:53 2014 -0500
Check that source_handlers contains the tag.
diff --git a/glib/Source.cs b/glib/Source.cs
index 89e691f..cf9f4ba 100644
--- a/glib/Source.cs
+++ b/glib/Source.cs
@@ -58,7 +58,8 @@ namespace GLib {
bool ret = true;
lock (Source.source_handlers) {
- if (source_handlers.Remove (tag)) {
+ if (source_handlers.Contains (tag)) {
+ source_handlers.Remove (tag);
ret = g_source_remove (tag);
}
}
--- End Message ---
--- Begin Message ---
Source: gtk-sharp2
Source-Version: 2.12.10-5.1
We believe that the bug you reported is fixed in the latest version of
gtk-sharp2, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Simon McVittie <[email protected]> (supplier of updated gtk-sharp2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 21 Feb 2015 11:52:55 +0000
Source: gtk-sharp2
Binary: gtk-sharp2 gtk-sharp2-examples gtk-sharp2-gapi libglib2.0-cil
libglib2.0-cil-dev libgtk2.0-cil libgtk2.0-cil-dev libglade2.0-cil
libglade2.0-cil-dev monodoc-gtk2.0-manual
Architecture: all source
Version: 2.12.10-5.1
Distribution: unstable
Urgency: medium
Maintainer: Debian CLI Libraries Team
<[email protected]>
Changed-By: Simon McVittie <[email protected]>
Closes: 776145
Description:
gtk-sharp2-examples - sample applications for the GTK# 2.10 toolkit
gtk-sharp2-gapi - C source parser and C# code generator for GObject based APIs
gtk-sharp2 - GTK# 2.10 suite, CLI bindings for GTK+
libglade2.0-cil - CLI binding for the Glade libraries 2.6
libglade2.0-cil-dev - CLI binding for the Glade libraries 2.6
libglib2.0-cil - CLI binding for the GLib utility library 2.12
libglib2.0-cil-dev - CLI binding for the GLib utility library 2.12
libgtk2.0-cil - CLI binding for the GTK+ toolkit 2.12
libgtk2.0-cil-dev - CLI binding for the GTK+ toolkit 2.12
monodoc-gtk2.0-manual - compiled XML documentation for GTK# 2.10
Changes:
gtk-sharp2 (2.12.10-5.1) unstable; urgency=medium
.
* Non-maintainer upload.
* debian/patches: add upstream commits
0001-glib-Fix-native-GLib-warnings-when-disposing-SourceP,
0002-Check-that-source_handlers-contains-the-tag from version 2.12.26,
fixing warning spam from removing nonexistent event sources with
recent GLib. This was filed as RC, since it can consume significant
disk space in long-running Gtk# apps. (Closes: #776145)
Checksums-Sha1:
4f06d2a5a495ce2b4285defcb36953460f9ee4de 141230 gtk-sharp2_2.12.10-5.1_all.deb
f0c73e566788a519d0474214f2124ebc62059fd1 338418
gtk-sharp2-examples_2.12.10-5.1_all.deb
42b82a4095379850aa298af883b7a957a3224b4b 2161170
monodoc-gtk2.0-manual_2.12.10-5.1_all.deb
66cb0c9c7fecb2f64d2039ade13370074cbc0fc7 2779 gtk-sharp2_2.12.10-5.1.dsc
b6f163c8dde1c7cfe14f1e7d63358beefc88e7f6 16524
gtk-sharp2_2.12.10-5.1.debian.tar.xz
Checksums-Sha256:
90499d717b592f03edfe9bb3b25ebd5ab93d6b7a703f5aed19229b2616f489b9 141230
gtk-sharp2_2.12.10-5.1_all.deb
29c1c3325913551cb42126e58c3b5f2aac6f58a30cc167c52569ce9493fc6755 338418
gtk-sharp2-examples_2.12.10-5.1_all.deb
39528fe66a96902fb514eefedb2493d58a7052ef983aa1ed2bf72c9dd0b169a1 2161170
monodoc-gtk2.0-manual_2.12.10-5.1_all.deb
fa7ead12b412c3e1e98614587326350cd701cc9123218746c36a1d0537a07702 2779
gtk-sharp2_2.12.10-5.1.dsc
c5e1cc6ec9d7be40ebb201e182fe7798a5c59064db37df4307ff625412ab456d 16524
gtk-sharp2_2.12.10-5.1.debian.tar.xz
Files:
6b67738f1514bbcf834108fa563824ec 141230 libs optional
gtk-sharp2_2.12.10-5.1_all.deb
debf3925523d104d76ed42e162f1d687 338418 libs optional
gtk-sharp2-examples_2.12.10-5.1_all.deb
9444df0fc8cedffd5d123bf355fabab7 2161170 doc extra
monodoc-gtk2.0-manual_2.12.10-5.1_all.deb
5435e812ad86c931a86b92a0c3600018 2779 libs optional gtk-sharp2_2.12.10-5.1.dsc
0027fe3faf2720c364318c02f25cc224 16524 libs optional
gtk-sharp2_2.12.10-5.1.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIVAwUBVOik8E3o/ypjx8yQAQgODw/9FFOaTPEl9aKMuqJvJE8kB/46tCc7STzl
4jZU3wCOMfQR0BCs6bbzfV2JW8WoE3LdIboT9DZ50rzJQeBwjoZxMJAMHxgzjAOI
dcB3K1td4K6WITaabsPpCoFZmZVQteMXaE+66CVhpi796MvL7sazqE2N7PJtytRH
08+sxBNn4fg/v9ayAKccL4rlY4UmMzVixtWmN9GGtNaCXUPgHE7jnqTBelZXTmRY
pwmE41YjTwaHxQvDwMSJvn6V5gyO59fD/w1z6IL4AnkF8ruHBjafAQmG+deMWk1h
mG3yWf7DQcNdbj+LQMlWvjmCCM2EF2MeMWwg3da4UTyc7OJD62LfaUj7dMHYOiJV
uII+SrXYSZooQ/u8si8gUU7JmFuNSX4+SvkNIWUF4gmLO7z6GVNixN92kFoGF3md
JrFBmtGXa0yPdBuGNl9m3lGUauHPIU5wNzPUatisIQ5q0N0bhmTkRp79LP+oF/ua
3Xj9GQWFoe3bYkHSuam/NHFvbQh1WMos4aHPH4e6C/IkS/mPOphnvbvQC9Fj1VLX
DiPLsO2e9bSwq288yHNdfbC0b5JEURmQKDv82excNcyh7w7vVxrEHc2dXn5BFCf1
PlaxB8srHlqfdoVD7sQJhlzR9CC9jVW0fRkBQYOniuLhUVJyH5aH7lu9Eejt5dCR
lTGAopDGj0Y=
=jAwf
-----END PGP SIGNATURE-----
--- End Message ---
