László Böszörményi (GCS) wrote:
>  Please see Makefile.am:
> -- cut --
> $(top_srcdir)/configure.ac: $(top_srcdir)/configure.proto
>         $(am__cd) $(srcdir) && $(SHELL) autogen.sh
> -- cut --
> 
> As such, for configure.ac autogen.sh is used, which contains this:
> -- cut --
>         if test x"$configure_needs_ac" = "xyes"; then
>                 sed s/AM_CONFIG_HEADER/AC_CONFIG_HEADERS/g
> <configure.proto >configure.ac
>         else
>                 cp configure.proto configure.ac
>         fi
> -- cut --
> 
> This means configure.proto just copied over configure.ac or 'sed' is
> used for substitution to generate configure.ac from the former. This
> means any patching of configure.ac will be lost and thus not needed.

I wish you could see the horror and anguish in my facial expressions.
Why did it become so convoluted!?  There are three copies of configure
in the upstream source... plus there are warnings referring to a
configure.in also.

> That's correct and previously it worked. Please see that 2.4.26 built
> on kfreebsd-i386 and on kfreebsd-amd64 already. Only when it was
> binNMUed failed on kfreebsd-i386.

I think it was only an accident that it worked before.  See in
https://buildd.debian.org/status/fetch.php?pkg=vice&arch=amd64&ver=2.4.dfsg%2B2.4.26-1%2Bb1&stamp=1460051005
the first time that configure ran, it was based on the unpatched
configure.ac (which generates a lot of warnings about AC_* macros) :

| checking for unistd.h... (cached) yes
| checking sys/io.h usability... yes
| checking sys/io.h presence... yes
| checking for sys/io.h... yes
| checking machine/pio.h usability... no
| checking machine/pio.h presence... no
| checking for machine/pio.h... no
| checking machine/cpufunc.h usability... yes
| checking machine/cpufunc.h presence... yes
| checking for machine/cpufunc.h... yes
| checking for ieee1284_find_ports in -lieee1284... yes

and the second time it ran, it used the patched configure.proto,
not checking for machine/cpufunc.h any more:

| checking for unistd.h... (cached) yes
| checking sys/io.h usability... yes
| checking sys/io.h presence... yes
| checking for sys/io.h... yes
| checking machine/pio.h usability... no
| checking machine/pio.h presence... no
| checking for machine/pio.h... no
| checking for ieee1284_find_ports in -lieee1284... yes

And now of course the build only runs configure once, so it uses only
the unpatched configure.ac

Thanks,
Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org

Attachment: signature.asc
Description: Digital signature

Reply via email to