Your message dated Sun, 22 May 2016 07:19:04 +0000
with message-id <[email protected]>
and subject line Bug#823432: fixed in lincity 1.13.1-13
has caused the Debian Bug report #823432,
regarding lincity: FTBFS, please fix implicit declaration of function warnings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
823432: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823432
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: lincity
Version: 1.13.1-12
Severity: serious
Justification: fails to build from source
Tags: patch

Dear Maintainer,

This package failed to be built from source. Also, lincity cannot be
play on amd64. It crashed.

(gdb) run
Starting program: /tmp/d1/lincity-1.13.1/debian/lincity/usr/games/lincity
PNG Header: 1360 x 1600, bd=8, ct=3

Program received signal SIGSEGV, Segmentation fault.
0x0000000000419edd in load_png_graphic (type=0, group=0, id=0x453677
"green",
    txt_fp=0x721510, row_pointers=0x72daf0, width=1360, height=1600)
    at readpng.c:576
576             if (!fnp || *fnp == '#') continue;
(gdb) print fnp
$1 = 0xffffffffffffbc00 <error: Cannot access memory at address
0xffffffffffffbc00>
(gdb) print buf
$2 = "##\000size 1
buildings\n\000\000\000\000@\027r\000\000\000\000\000@\027r\000\000\000\000\000\000\023\275`\210\257\000\246@\027r\000\000\000\000\000\001\000\000\000\377\177\000\000\000\000\000\000\000\000\000\000\347\317f\367\000\000\000\000\060j\236\366\377\177\000\000\340\022r",
'\000' <repeats 13 times>,
"\020*@\000\000\000\000\000p\336\377\377\377\177\000\000\000\000\000\000\000\000\000"
(gdb)


This is basically because there are many implicit declaration of
function warnings and must be fixed.

I've attached a patch to fix this bug. Please review it.

Many Thanks,
Paul



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.5.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored:
LC_ALL  set to zh_TW.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lincity depends on:
ii  libc6        2.22-7
ii  libice6      2:1.0.9-1+b1
ii  libpng16-16  1.6.21-4
ii  libsm6       2:1.2.2-1+b1
ii  libx11-6     2:1.6.3-1
ii  libxext6     2:1.3.3-1
ii  zlib1g       1:1.2.8.dfsg-2+b1

lincity recommends no packages.

lincity suggests no packages.

-- no debconf information


-- 
                                PaulLiu (劉穎駿)
E-mail: Ying-Chun Liu (PaulLiu) <[email protected]>
Description: Fix implicit declaration of function warnings
 This patch fixes the FTBFS bug. Also fixes a crash bug on 64-bits systems.
Author: Ying-Chun Liu (PaulLiu) <[email protected]>
Last-Update: 2016-05-05
Index: lincity-1.13.1/main.c
===================================================================
--- lincity-1.13.1.orig/main.c
+++ lincity-1.13.1/main.c
@@ -41,6 +41,10 @@
 #include <lcx11.h>
 #endif
 
+#if !defined(WIN32)
+#include <locale.h>
+#endif
+
 #include "lctypes.h"
 #include "lin-city.h"
 #include "cliglobs.h"
Index: lincity-1.13.1/readpng.c
===================================================================
--- lincity-1.13.1.orig/readpng.c
+++ lincity-1.13.1/readpng.c
@@ -3,6 +3,7 @@
  * This file is part of lincity (see COPYRIGHT for copyright information).
  * ---------------------------------------------------------------------- */
 #include <stdlib.h>
+#include <string.h>
 #include "png.h"
 #include "malloc.h"
 #include "lin-city.h"

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Source: lincity
Source-Version: 1.13.1-13

We believe that the bug you reported is fixed in the latest version of
lincity, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Kari Pahula <[email protected]> (supplier of updated lincity package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 22 May 2016 09:29:18 +0300
Source: lincity
Binary: lincity
Architecture: source amd64
Version: 1.13.1-13
Distribution: unstable
Urgency: medium
Maintainer: Kari Pahula <[email protected]>
Changed-By: Kari Pahula <[email protected]>
Description:
 lincity    - build & maintain a city/country
Closes: 823432
Changes:
 lincity (1.13.1-13) unstable; urgency=medium
 .
   * Standards-Version to 3.9.8, remove menu entry.
   * Fix implicit declarations to avoid FTBFS (Thanks to
     [email protected]) (Closes: #823432)
   * Add --bindir=/usr/games to configure parameters.
Checksums-Sha1:
 127cbd5d87489f16c0e5251c0965714043c3291b 1781 lincity_1.13.1-13.dsc
 08faef110fe5b5a722b678caeced79b7ff71b3bc 25892 lincity_1.13.1-13.debian.tar.xz
 596a94cfac44a76e2e8a055c6687974a12d115f8 203632 
lincity-dbgsym_1.13.1-13_amd64.deb
 83cfab4f582b454ce681af52479baaeae7de3aa4 471460 lincity_1.13.1-13_amd64.deb
Checksums-Sha256:
 ee5172f4e63a51ee8ee87479e58f8cca00d0384e83bd8db67acbaa59f881c1cf 1781 
lincity_1.13.1-13.dsc
 618faf140325c03715ae2c29d040a24381693475a54e7bc9b6a18c4d9870170b 25892 
lincity_1.13.1-13.debian.tar.xz
 a7e64baadf725e2763b915c1693454daa6753c32beece3905feea75c5b1e35a4 203632 
lincity-dbgsym_1.13.1-13_amd64.deb
 1f818b804adc2365e8e5598f5c641cca3fb4e88f53d122b461b9019a713a97d4 471460 
lincity_1.13.1-13_amd64.deb
Files:
 03abcf85b9369b1a0ef176c779330c93 1781 games extra lincity_1.13.1-13.dsc
 490255b6871623d5c56fe961990a283e 25892 games extra 
lincity_1.13.1-13.debian.tar.xz
 8e45027c96942128af731e5fbc6c21e2 203632 debug extra 
lincity-dbgsym_1.13.1-13_amd64.deb
 03e9f8b549d4ae8f1256a1a0b6333026 471460 games extra lincity_1.13.1-13_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXQVevAAoJEIQIZ+6djyZcCVAP/2k0qr+eXubsHys29EDBi8I7
gKIMozYkTJ4WsUrhj0zGM89+z3cL+zddRwkK59gHC3w500Ryzn48c9SWA7uorNJY
wNEoCkZiUkrikOhcz2u5HYJZ2xIZ+jjHL9yliXQ1Bmxnb7iCzC3oLeZNrG5Fu4Zm
fC9GUMKzE2cwQx16LlMHf5q6SM9fM3OevAIciVUPPV6Mu0uAqbZfjWtwIUN9JB7S
a9a4HAq9lBsVinrLU5Aa78L4fVvr7F8WTdGB5tOcMqoCeexEKd0V2lKUfdGgaVau
7xnRZ/KQwRYbS67k2+KycE7HPHQ6QTeJOh/6W3/KnSSvs2ObUkc9+NmDwktLY66w
HGvzauhYrFtiZtEL8HVtpk7U05/y5CsCSJ9iq08pLGjyYgAFnJwAM9gjjdY7257l
NTNzfnlmIkwb6+cen3/BIjRDHiH8vIZIOqyhMt4eKf4o2SxC3F/IeSa8luPly9ON
QexfbxZ2RJQVH+czgc7d93pL8NXmmk/bTtfyhkEtpB5II+fsXRiMFtap6ytXLaJk
+4ga2wia6BRwtUD5LwXyUqrXbomx+shKFvuss/eGoRJ9G3K85jx6VXLpL08dgJZr
WDL53bnLHxKlVClcD/vcSXO1lVIEJ/QqyUX/XY3Y5eiOurMfHMNmEjj0D820hEMV
5keLfJimjtoe+j5pi257
=0B2k
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to