Source: protobuf
Version: 2.6.1-2
Severity: serious
Justification: fails to build from source (but built successfully in the past)

Builds of protobuf with GCC 6 fail due to nominal misleading
indentation in generated code:

  google/protobuf/unittest_lite.pb.cc:8544:3: error: this ‘if’ clause does not 
guard... [-Werror=misleading-indentation]
     if (!_extensions_.IsInitialized()) return false;  return true;
     ^~
  google/protobuf/unittest_lite.pb.cc:8544:53: note: ...this statement, but the 
latter is misleadingly indented as if it is guarded by the ‘if’
     if (!_extensions_.IsInitialized()) return false;  return true;
                                                       ^~~~~~
  [...]

Please fix the generator to either simplify this code to

  return _extensions_.IsInitialized();

or to put the final "return true;" on its own line.

Thanks!

Reply via email to