Hi Andi, hi Wolfgang, On Fr 12 Aug 2016 10:02:53 CEST, Andreas B. Mundt wrote:
Control: tags -1 patch Hi Wolfgang, thanks for your quick answer and the patch! On Thu, Aug 11, 2016 at 11:53:58PM +0200, Wolfgang Schweer wrote:looks like a misleading error message. […] The fix might be as simple as below, but maybe it requires more investigation. The related file is located in /usr/share/gosa/setup/. --- a/class_setupStep_Checks.inc 2016-08-11 23:38:41.461895899 +0200 +++ b/class_setupStep_Checks.inc 2016-08-11 23:37:37.000000000 +0200 @@ -138,7 +138,7 @@ $N = msgPool::checkingFor(_("MySQL"));$D = _("GOsa requires this module to communicate with several supported databases.");$S = msgPool::installPhpModule("MySQL"); - $R = is_callable("mysql_query"); + $R = is_callable("mysqli_query"); $M = True;$this->basic_checks[] = array("NAME" => $N , "DESC" => $D , "RESULT" => $R , "SOLUTION" => $S , "MUST" => $M );Please test if this patch works.This patch works fine here. The error is gone, the setup continues as expected. I tag the bug report accordingly. Best regards, Andi
Do you think that this minimal patch is sufficient? I grep through gosa's code and find various locations, where mysql_query is used (and probably mysqli_query should be used).
/me thinks that we need to patch all occurences of mysql_* and replace by mysqli_* function calls.
Does anyone of you know if mysql_* PHP module functions can be transparently replaced by mysqli_* function calls?
/me will see to upstreaming this patch, once we have it in Debian (and once it works). The other way round, of course.
Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: [email protected], http://das-netzwerkteam.de
pgpu6llmJYQlE.pgp
Description: Digitale PGP-Signatur
