Your message dated Tue, 10 Jan 2017 17:04:32 +0000
with message-id <[email protected]>
and subject line Bug#847526: fixed in stimfit 0.15.4-1
has caused the Debian Bug report #847526,
regarding stimfit FTBFS on architectures where char is unsigned.
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
847526: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847526
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: stimfit
Version: 0.15.3-1
Severity: serious
Tags: patch
From the armhf build log for the hdf5 binnmu
In file included from biosig4c++/t210/scp-decode.cpp:113:0:
biosig4c++/t210/codes.h:25:37: error: narrowing conversion of '-1' from 'int'
to 'char' inside { } [-Wnarrowing]
arm64, armel, ppc64el, powerpc and ppc64 have the same problem.
I believe this was triggered by the move to gcc-6. At least on armhf the
previous successful build was performed with gcc 5.
Adding an explicit typecast makes the package build. I took a quick look
at the code to try to determine if this fix was correct but I was unable
to determine what exactly the value in question was actually used for.
I uploaded the fix to raspbian and have attatched a debdiff.
No intent to NMU in debian.
diff -Nru stimfit-0.15.3/debian/changelog stimfit-0.15.3/debian/changelog
--- stimfit-0.15.3/debian/changelog 2016-07-14 10:12:45.000000000 +0000
+++ stimfit-0.15.3/debian/changelog 2016-12-09 00:34:10.000000000 +0000
@@ -1,3 +1,9 @@
+stimfit (0.15.3-1+rpi1) stretch-staging; urgency=medium
+
+ * Add typecast to fix build failure on architectures where char is unsigned..
+
+ -- Peter Michael Green <[email protected]> Fri, 09 Dec 2016 00:34:10
+0000
+
stimfit (0.15.3-1) unstable; urgency=low
* Fix building with gcc-6 (Closes: #811904)
diff -Nru stimfit-0.15.3/debian/patches/fix-char-signedness.patch
stimfit-0.15.3/debian/patches/fix-char-signedness.patch
--- stimfit-0.15.3/debian/patches/fix-char-signedness.patch 1970-01-01
00:00:00.000000000 +0000
+++ stimfit-0.15.3/debian/patches/fix-char-signedness.patch 2016-12-09
00:34:10.000000000 +0000
@@ -0,0 +1,14 @@
+Description: Add typecast to fix build failure on architectures where char is
unsigned..
+Author: Peter Michael Green <[email protected]>
+
+--- stimfit-0.15.3.orig/src/libbiosiglite/biosig4c++/t210/codes.h
++++ stimfit-0.15.3/src/libbiosiglite/biosig4c++/t210/codes.h
+@@ -22,7 +22,7 @@ Foundation, Inc., 59 Temple Place - Suit
+ #ifndef __CODES_H__
+ #define __CODES_H__
+
+-static const char STR_END[]={-1,'\0'};
++static const char STR_END[]={(char)-1,'\0'};
+ static char STR_NULL[]=" unspecified/unknown ";
+
+ static alfabetic _special[]={
diff -Nru stimfit-0.15.3/debian/patches/series
stimfit-0.15.3/debian/patches/series
--- stimfit-0.15.3/debian/patches/series 1970-01-01 00:00:00.000000000
+0000
+++ stimfit-0.15.3/debian/patches/series 2016-12-09 00:34:10.000000000
+0000
@@ -0,0 +1 @@
+fix-char-signedness.patch
--- End Message ---
--- Begin Message ---
Source: stimfit
Source-Version: 0.15.4-1
We believe that the bug you reported is fixed in the latest version of
stimfit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christoph Schmidt-Hieber <[email protected]> (supplier of updated stimfit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 10 Dec 2016 16:55:51 +0000
Source: stimfit
Binary: stimfit stimfit-dbg python-stfio
Architecture: source amd64
Version: 0.15.4-1
Distribution: unstable
Urgency: low
Maintainer: Christoph Schmidt-Hieber <[email protected]>
Changed-By: Christoph Schmidt-Hieber <[email protected]>
Description:
python-stfio - Python module to read common electrophysiology file formats.
stimfit - Program for viewing and analyzing electrophysiological data
stimfit-dbg - Debug symbols for stimfit
Closes: 847526
Changes:
stimfit (0.15.4-1) unstable; urgency=low
.
* Fix building with gcc-6 on armhf (Closes: #847526)
* Add channel scrolling
* Upgrade libbiosiglite to 1.8.4
Checksums-Sha1:
d481f6f858a82e8a1916b30e59385c9e83da2faa 2206 stimfit_0.15.4-1.dsc
2b5577cf40cdef7ab2a975071f58ebad75f9b1d7 2599578 stimfit_0.15.4.orig.tar.gz
a22ad19e71871513b617b8d317625f14163e6144 8324 stimfit_0.15.4-1.debian.tar.xz
803c321593ff166e47bc7c32867a1490960c64c9 475068 python-stfio_0.15.4-1_amd64.deb
0804feb158bbd4eec91ac0b6a3ce3d02f488302f 6989348 stimfit-dbg_0.15.4-1_amd64.deb
9e3611a053c4d5ca9d65b0a30cb1f1a6e72935d4 10973 stimfit_0.15.4-1_amd64.buildinfo
502bacdc9dc50b5b5c63cd0b5a617628ab1acb45 895960 stimfit_0.15.4-1_amd64.deb
Checksums-Sha256:
2118caec138f9e40b5ac805f897d9738ffa3df0ed6bf57a6a794cf68d4a7f64b 2206
stimfit_0.15.4-1.dsc
7801d1f68a3ace0baf316bc30a558a3471b7d1ac21b98a32b541a93fd8c6c749 2599578
stimfit_0.15.4.orig.tar.gz
49c5a302beab9787b8ed823025698c525f6414ba6520608b77b96fce67a10d1d 8324
stimfit_0.15.4-1.debian.tar.xz
e866a2abcbda345df821e28b0414f967700299e974c64cc18db5bb71aefe671d 475068
python-stfio_0.15.4-1_amd64.deb
fce2047d3b97248b3a74bbb270109499a6d5cb8bff62d1a696d148b3fc9bda25 6989348
stimfit-dbg_0.15.4-1_amd64.deb
57d20084a9e542434b7df34cf896912f39d3b186fa3ef92d17dba77fadd62b12 10973
stimfit_0.15.4-1_amd64.buildinfo
1167785f6e1566ad7e1f7b8551b2892288ba5fe954a79390de58a73c1c0dc022 895960
stimfit_0.15.4-1_amd64.deb
Files:
5d73d338419171904c0021a6184446ae 2206 science optional stimfit_0.15.4-1.dsc
f1a23938df91038e1cad5e0a396482a1 2599578 science optional
stimfit_0.15.4.orig.tar.gz
8f06a6ce8e441f5a8dadee71924a71da 8324 science optional
stimfit_0.15.4-1.debian.tar.xz
4fb57315da3dd80d419179f0ba9ec4cc 475068 python optional
python-stfio_0.15.4-1_amd64.deb
d77bbcefeaabcb2652057b9fd6e89745 6989348 debug extra
stimfit-dbg_0.15.4-1_amd64.deb
48fcd8f79d1cb74eb2e26b40f04b6c4e 10973 science optional
stimfit_0.15.4-1_amd64.buildinfo
6e91b9abe6fda23d0b78840e5eb071ab 895960 science optional
stimfit_0.15.4-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEExbkF8OjZ/ZZo/zZvot4jUGLaM/oFAlh1DuMACgkQot4jUGLa
M/qRaRAAiQXW7rwH6ubTXhyGSlDfoTCmg7zoPIbkSmUSEKMO8r+WBFG+J6C8lahi
bB9tBza6Ealn3jcobobVb5YUgq+3qlsLufdPP3j2DQdSEkVDkQ85htKVDQrEM8vl
jYhyybYfmsMYUoqzySNemmJJz5cL1c2uXCu9z/YOXryIwV1hhY4KkpMlzh8lyG+Q
e3ggOvqj7kHaKrNjvsxuyquyzle1QmIRsaJNbGj/5xjiLnkTAlEjxUxmGeD7BDu1
YDX5CGW6cMBOm4VjiAl3JBrplXjvwBSlxQrqdxE4+0ZxclS/zNfRLb5D6WTMIB6v
2EVrBaS6Y1qfUb+bKbO6u2I7CTc4EoYFHVXZQFRnWkNFksrc+C9phtxDr6Ciokh2
djV151X7btSeCFLMELvv7lyonq9sovLHsqo0ZzKNMscY8F2KRJa/Ma1vSaEvJsIH
0E8Q8EknPDWO07yvGTDkndQEZ91cu6I7hGlrXJjptEl++GgkMtzsPse9IbIzrYxN
9SXK/Z/a9E6Nwhrk2Fn939d8tOYxYiXrFR3oSNfmSEu8qCtLdP8L/5khrs1VdbNy
bCUDWEjSnLA+/V68k0A5MTvDD5DyOZ1C7IK1x8CMLQ135Bbft55q3B0sH5EZlpT+
By8859Gvpl+jDmfWo9TXtRIxqjwikUYuKKoju9dFtC11k7/Nf/Q=
=7fCw
-----END PGP SIGNATURE-----
--- End Message ---
