tags 354339 - patch tags 354339 - pending thanks I have looked at the coding and I'm not happy with it for the release. Although I agree that the patch by Geert will solve the problem seen by Christian, I think it only helps to hide some more basic problems with the whole implementation of dhcp preseeding.
For one thing, my dhcp server setup [1] already uses 'filename' for PXE
netbooting. So it seems that the chosen solution is incompatible with
netbooting which I doubt was the intention. Maybe it would be better to
use something like 'preseed-url' instead [2].
Having the dual use of 'filename' also makes the isinstallable check less
than ideal as it will currently also make network-preseed installable for
my PXE netboot setup while I have not set that up for dhcp preseeding.
I think the current test
if [ -n "$FN" -a -z "${FN##*://*}" ]; then
is intended to check that $FN actually contains an URL.
However, this is not very obvious from the code. It is probably better to
replace this test with something like
if echo "$FN" | grep -q "\(http\|ftp\)://" ; then
IMO all this needs some thought and changes in the implementation. I have
therefore uploaded a version of preseed without support for dhcp pre-
seeding but with the fixes needed for existing preseeding functionality.
[1]
My dhcp server setup contains:
group {
filename "/i386/pxelinux.0";
next-server 10.19.66.2;
host <hostname> {
hardware ethernet <MAC address>;
fixed-address <address>;
option host-name "<hostname>";
}
}
This results in a lease file which contains (even if I do not actually PXE
boot):
lease {
interface "eth0";
fixed-address <address>;
filename "/i386/pxelinux.0";
option [...]
[...]
}
[2] Note that this would also need to be changed in the manual.
pgpdMnfdBG2OL.pgp
Description: PGP signature
