Hi Chris, On 12.04.2017 22:43, Chris Lamb wrote: > I just ACCEPTed starjava-topcat from NEW but noticed it was missing > attribution in debian/copyright for at least > debian/patches/Remove-edu.jhu.htm-reference.patch, src/docs (possibly?) > and src/main/uk/ac/starlink/topcat/contrib/gavo/GavoCSVTableParser.java.
I think they are correctly attributed: GavoCSVTableParser.java [1] is copyrighted 2003-2004 German Astrophysical Virtual Observatory (GAVO), which is already mentioned in debian/copyright [2] (main section). And Remove-edu.jhu.htm-reference.patch [3] is copyrighted by me, which is also mentioned there. Remove-edu.jhu.htm-reference.patch just removes the link to a package that has a non-free license. For reference, this license is given in the patch, but it is *not* the license of the patch. The patch is licensed along with the main license of the package (LGPL-2.1). Would you disagree here? Otherwise I would like to just close the bug. Best regards Ole [1] https://sources.debian.net/src/starjava-topcat/4.4-1/src/main/uk/ac/starlink/topcat/contrib/gavo/GavoCSVTableParser.java/#L8 [2] https://sources.debian.net/src/starjava-topcat/4.4-1/debian/patches/Remove-edu.jhu.htm-reference.patch/#L7-L13 [3] https://sources.debian.net/src/starjava-topcat/4.4-1/debian/copyright/#L8-L9
