Your message dated Mon, 06 Mar 2006 18:32:33 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#286475: fixed in irssi-plugin-icq 0.2-3
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: irssi-plugin-icq
Severity: normal
Tags: patch

When building 'irssi-plugin-icq' on amd64 with gcc-4.0,
I get the following error:

icq-protocol.c:242: error: invalid lvalue in increment
icq-protocol.c:243: error: invalid lvalue in increment
icq-protocol.c:258: error: invalid lvalue in increment
icq-protocol.c:261: error: invalid lvalue in increment
icq-protocol.c: In function 'decode_msg':
icq-protocol.c:277: error: invalid lvalue in increment
icq-protocol.c:278: error: invalid lvalue in increment
icq-protocol.c:279: error: invalid lvalue in increment
icq-protocol.c: In function 'process_packet':
icq-protocol.c:568: warning: pointer targets in passing argument 4 of 
'decode_msg' differ in signedness
icq-protocol.c:600: warning: pointer targets in passing argument 4 of 
'extract_user_info' differ in signedness
make[4]: *** [icq-protocol.lo] Error 1
make[4]: Leaving directory `/irssi-plugin-icq-0.2/src/core'

With the attached patch 'irssi-plugin-icq' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/irssi-plugin-icq-0.2/src/core/icq-protocol.c 
./src/core/icq-protocol.c
--- ../tmp-orig/irssi-plugin-icq-0.2/src/core/icq-protocol.c    2002-11-24 
13:07:55.000000000 +0100
+++ ./src/core/icq-protocol.c   2004-12-20 14:08:14.976650704 +0100
@@ -49,9 +49,9 @@
 
 #define writeb(buf, value) (*(buf) = (value), (buf)+1)
 static inline char *writew(char *buf, guint16 value)
-       { *((guint16*)buf)++ = htons(value); return buf; }
+       { *((guint16*)buf) = htons(value); return buf = ((guint16*)buf) + 1; }
 static inline char *writel(char *buf, guint32 value)
-       { *((guint32*)buf)++ = htonl(value); return buf; }
+       { *((guint32*)buf) = htonl(value); return buf =  ((guint32*)buf) + 1; }
 static inline char *writes(char *buf, const char *data, int len)
        { memcpy(buf,data,len); return buf+len; }
 
@@ -70,9 +70,9 @@
        return writes(buf, data, len);
 }
 
-#define readb(buf) (*((guint8*)buf)++)
-#define readw(buf) __extension__(({ guint16 ret = ntohs(*(guint16*)buf); 
((guint16*)buf)++; ret; }))
-#define readl(buf) __extension__(({ guint32 ret = ntohl(*(guint32*)buf); 
((guint32*)buf)++; ret; }))
+#define readb(buf) *((guint8*)buf); buf = ((guint8*)buf) + 1;
+#define readw(buf) __extension__(({ guint16 ret = ntohs(*(guint16*)buf); buf = 
((guint16*)buf) + 1; ret; }))
+#define readl(buf) __extension__(({ guint32 ret = ntohl(*(guint32*)buf); buf = 
((guint32*)buf) + 1; ret; }))
 
 static char *read_tlv(char *buf, char *end, int *type, char **data, int *len)
 {


--- End Message ---
--- Begin Message ---
Source: irssi-plugin-icq
Source-Version: 0.2-3

We believe that the bug you reported is fixed in the latest version of
irssi-plugin-icq, which is due to be installed in the Debian FTP archive:

irssi-plugin-icq_0.2-3.diff.gz
  to pool/main/i/irssi-plugin-icq/irssi-plugin-icq_0.2-3.diff.gz
irssi-plugin-icq_0.2-3.dsc
  to pool/main/i/irssi-plugin-icq/irssi-plugin-icq_0.2-3.dsc
irssi-plugin-icq_0.2-3_i386.deb
  to pool/main/i/irssi-plugin-icq/irssi-plugin-icq_0.2-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Banck <[EMAIL PROTECTED]> (supplier of updated irssi-plugin-icq package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  7 Mar 2006 02:22:48 +0100
Source: irssi-plugin-icq
Binary: irssi-plugin-icq
Architecture: source i386
Version: 0.2-3
Distribution: unstable
Urgency: low
Maintainer: Michael Banck <[EMAIL PROTECTED]>
Changed-By: Michael Banck <[EMAIL PROTECTED]>
Description: 
 irssi-plugin-icq - ICQ plugin for irssi
Closes: 232702 286475
Changes: 
 irssi-plugin-icq (0.2-3) unstable; urgency=low
 .
   * Rebuilt against latest irssi; closes: #232702.
   * debian/control (Build-Depends): Replaced irssi-snapshot-dev by
     irssi-dev.
   * debian/control (Depends): Depend on irssi only.
   * src/core/icq-protocol.c: Applied patch by Andreas Jochens to fix
     build on amd64; closes: #286475.
   * autogen.sh: Invoke automake with --foreign rather than --gnu.
Files: 
 fe8e9c113ead25a6f8e7389c94cd6732 646 net optional irssi-plugin-icq_0.2-3.dsc
 7779949897423630e394d81e5cd3b954 2428 net optional 
irssi-plugin-icq_0.2-3.diff.gz
 4516300d29a89e5d02e5162270d4fd59 16020 net optional 
irssi-plugin-icq_0.2-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFEDOuEmHaJYZ7RAb8RAhZXAJwKfDR88fw9VQk0Z5tRwt4nS+tRvQCghKA2
FmJdiksU/xswTdW+n2Y0ZcA=
=Bf4C
-----END PGP SIGNATURE-----


--- End Message ---

Reply via email to