Control: tag -1 + patch

On Mon, 24 Jul 2017 14:26:20 +0200, gregor herrmann wrote:

> libdigest-whirlpool-perl was given back on s390x but failed 2 times.
> This needs more investigation ...

Running the tests in a loop on zelenka shows random failures in
different tests indeed.

Niko found https://rt.cpan.org/Public/Bug/Display.html?id=84143 which
leads to 
https://github.com/avar/digest-whirlpool/commit/66405ec9ca44492a38a82c2d7fa98c291d46eef1
and with this patch, the tests happily run in a loop on zelenka right
now.

Debdiff attached.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Funny Van Dannen: Weinende Piratenbraut
diff -u libdigest-whirlpool-perl-1.09/debian/changelog libdigest-whirlpool-perl-1.09/debian/changelog
--- libdigest-whirlpool-perl-1.09/debian/changelog
+++ libdigest-whirlpool-perl-1.09/debian/changelog
@@ -1,3 +1,13 @@
+libdigest-whirlpool-perl (1.09-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix "libdigest-whirlpool-perl FTBFS on s390x: test failure":
+    cherry-pick 66405ec from upstream git:
+    https://github.com/avar/digest-whirlpool/commit/66405ec9ca44492a38a82c2d7fa98c291d46eef1
+    (Closes: #869357)
+
+ -- gregor herrmann <gre...@debian.org>  Mon, 24 Jul 2017 17:08:08 +0200
+
 libdigest-whirlpool-perl (1.09-1) unstable; urgency=low
 
   * New upstream release. Closes: #626628.
only in patch2:
unchanged:
--- libdigest-whirlpool-perl-1.09.orig/Whirlpool.xs
+++ libdigest-whirlpool-perl-1.09/Whirlpool.xs
@@ -15,7 +15,6 @@
 new(SV * class)
 CODE:
     Digest__Whirlpool self;
-    SV * self_ref;
     const char * pkg;
 
     /* Figure out what class we're supposed to bless into, handle
@@ -34,7 +33,6 @@
        containing its memory location */
     Newz(0, self, 1, struct whirlpool);
     NESSIEinit(&self->state);
-    self_ref = newRV_noinc((SV *) self);
 
     RETVAL = newSV(0); /* This gets mortalized automagically */
     sv_setref_pv(RETVAL, pkg, (void*)self);

Attachment: signature.asc
Description: Digital Signature

Reply via email to