Your message dated Sun, 12 Nov 2017 09:34:45 +0000
with message-id <[email protected]>
and subject line Bug#876306: fixed in gnucash 1:2.6.18-1
has caused the Debian Bug report #876306,
regarding gnucash FTBFS: object class 'Transaction' has no property named
'bogus'
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
876306: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876306
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gnucash
Version: 1:2.6.17-1
Severity: serious
Tags: patch
User: [email protected]
Usertags: origin-ubuntu artful ubuntu-patch
Hi Dmitry,
The gnucash package has been failing to build in Ubuntu with a test failure,
and I have reproduced this failure in Debian unstable:
/engine/Transaction/xaccTransScrubGainsDate_gains_dirty: **
ERROR:utest-Transaction.c:452:test_gnc_transaction_set_get_property: assertion
failed (check1->hits == 1): (0 == 1)
<INFO> (gnc.engine) [xaccSplitEqualCheckBal] balances differ: 100000/1000 vs
200000/1000
<FATAL WARNING> (GLib-GObject) g_object_set_is_valid_property: object class
'Transaction' has no property named 'bogus'
<FATAL WARNING> (GLib-GObject) g_object_set_is_valid_property: object class
'Transaction' has no property named 'bogus'
OK
/engine/Transaction/gnc transaction set/get property: FAIL
GTester: last random seed: R02Sa8a1794f6622116b0a513984cbbbcc0f
Makefile:1926: recipe for target 'test-nonrecursive' failed
make[7]: *** [test-nonrecursive] Terminated
https://launchpad.net/ubuntu/+source/gnucash/1:2.6.17-1/+build/13058180
This looks like a brittle test that has broken as a result of implementation
details in gobject; I don't see any reason why the gnucash test suite should
be testing the specific text of the error message returned by gobject when
performing a disallowed operation. The gnucash implementation never relies
on the contents of this error string anywhere else, and it's not the
business of the gnucash testsuite to be testing the behavior of gobject
instead of its own.
So I think this particular test (or this aspect of the test) should be
dropped. But in the meantime, here is a patch that fixes the test failure
on Debian and Ubuntu.
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru gnucash-2.6.17/debian/patches/fix-test-for-gobject-messages.patch
gnucash-2.6.17/debian/patches/fix-test-for-gobject-messages.patch
--- gnucash-2.6.17/debian/patches/fix-test-for-gobject-messages.patch
1969-12-31 16:00:00.000000000 -0800
+++ gnucash-2.6.17/debian/patches/fix-test-for-gobject-messages.patch
2017-09-20 11:43:37.000000000 -0700
@@ -0,0 +1,31 @@
+Description: fix test case to work with newer gobject
+ glib 2.54 changes the error string returned by a particular wrong call
+ to g_object_set(). gnucash's testsuite relies on matching the exact
+ text of this error string. This is a wrong thing for the testsuite to do
+ - nothing in gnucash outside of the testsuite relies on this behavior, and
+ it's testing behavior of glib not of gnucash - but for the moment, here is
+ a patch that updates the expected string to match current glib.
+Author: Steve Langasek <[email protected]>
+
+Index: gnucash-2.6.17/src/engine/test/utest-Transaction.c
+===================================================================
+--- gnucash-2.6.17.orig/src/engine/test/utest-Transaction.c
++++ gnucash-2.6.17/src/engine/test/utest-Transaction.c
+@@ -412,7 +412,7 @@
+ "GNR", "", 240), *t_curr = NULL;
+ Timespec now = timespec_now (), *t_entered = NULL, *t_posted = NULL;
+ time_t secs = (time_t)now.tv_sec;
+- gchar *msg1 = "g_object_set_valist: object class " _Q "Transaction' has
no property named " _Q "bogus'";
++ gchar *msg1 = "g_object_set_is_valid_property: object class " _Q
"Transaction' has no property named " _Q "bogus'";
+ gchar *msg2 = g_strdup_printf ("[xaccTransSetDateInternal] addr=%p set
date to %" G_GUINT64_FORMAT ".%09ld %s",
+ txn, now.tv_sec, now.tv_nsec, ctime
(&secs));
+ GLogLevelFlags loglevel1 = G_LOG_LEVEL_WARNING | G_LOG_FLAG_FATAL;
+@@ -453,7 +453,7 @@
+ g_assert_cmpint (check2->hits, ==, 2);
+
+ g_free (check1->msg);
+- check1->msg = g_strdup ("g_object_get_valist: object class " _Q
"Transaction' has no property named " _Q "bogus'");
++ check1->msg = g_strdup ("g_object_get_is_valid_property: object class "
_Q "Transaction' has no property named " _Q "bogus'");
+ g_object_get (G_OBJECT (txn),
+ "num", &t_num,
+ "description", &t_desc,
diff -Nru gnucash-2.6.17/debian/patches/series
gnucash-2.6.17/debian/patches/series
--- gnucash-2.6.17/debian/patches/series 2016-12-21 13:24:42.000000000
-0800
+++ gnucash-2.6.17/debian/patches/series 2017-09-20 11:19:43.000000000
-0700
@@ -1 +1,2 @@
hardening-fortify.patch
+fix-test-for-gobject-messages.patch
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: gnucash
Source-Version: 1:2.6.18-1
We believe that the bug you reported is fixed in the latest version of
gnucash, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dmitry Smirnov <[email protected]> (supplier of updated gnucash package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 12 Nov 2017 19:34:34 +1100
Source: gnucash
Binary: gnucash gnucash-common python-gnucash
Architecture: source all amd64
Version: 1:2.6.18-1
Distribution: unstable
Urgency: medium
Maintainer: Dmitry Smirnov <[email protected]>
Changed-By: Dmitry Smirnov <[email protected]>
Description:
gnucash - personal and small-business financial-accounting software
gnucash-common - common files for the financial-accounting software Gnucash
python-gnucash - Gnucash interface for Python
Closes: 867932 876306
Changes:
gnucash (1:2.6.18-1) unstable; urgency=medium
.
* New upstream release [September 2017].
* New patch to fix FTBFS "no property named 'bogus'" (Closes: #876306).
Thanks, Steve Langasek, Micha Lenk.
* Standards-Version: 4.1.1.
* control: removed "dh-autoreconf" from Build-Depends.
* Switch from "libgnome-keyring-dev" to "libsecret-1-dev" (Closes: #867932)
Thanks to Michael Biebl, Laurent Bigonville.
* New upstream patch to fix FTBFS with libdbi_0.9.0-5.
* rules: removed call to `dpkg-parsechangelog`.
Checksums-Sha1:
4b6fa3dab3f296a4e1d2fe28024700d1bc8c6cb4 2360 gnucash_2.6.18-1.dsc
41b2580ba1fe586fbdb4629f2b36b12e9161b546 13583327 gnucash_2.6.18.orig.tar.bz2
c22464edac3d0bd93fd5cf2fd457caf53b71fd8f 36052 gnucash_2.6.18-1.debian.tar.xz
f253e0e344cb5b7e9a2c4a83013ea08ca119015d 4968120
gnucash-common_2.6.18-1_all.deb
5fde01d13552ac02c0c23cbac5ed4e45ba0971f4 7023024
gnucash-dbgsym_2.6.18-1_amd64.deb
fb532015037ed0bb362c89235da4d9288f4bb7ca 17526 gnucash_2.6.18-1_amd64.buildinfo
aeac5ee62aefe6021a55efbebf338e5cc62b2bed 3253908 gnucash_2.6.18-1_amd64.deb
54f04978c081ce321df35a72d98b102ce038ce35 510820
python-gnucash-dbgsym_2.6.18-1_amd64.deb
0c8482a1528deaa37fa2f069eeb29b10f5efa5d8 243372
python-gnucash_2.6.18-1_amd64.deb
Checksums-Sha256:
5c078662e446c58ea1192b2d82f4efe53f361742ed81743c7d3582bcfc8382f0 2360
gnucash_2.6.18-1.dsc
68730bcfcead7485011eb43d3b2c5df032c714571c81f9a15d33d8494fc4249d 13583327
gnucash_2.6.18.orig.tar.bz2
85ba5252f5de063870446a639c43cd75f98b8cef2e5ba2328ebb530cb3b63ea8 36052
gnucash_2.6.18-1.debian.tar.xz
4b9ba8ee3484625befa37d6cf4a7db078179f316eb59a4cf072a05e41fb84ed3 4968120
gnucash-common_2.6.18-1_all.deb
f2a9fc0895ac7d7b9ae5bd60890b7246dd45aee207eb5abd7352c702839d1b6e 7023024
gnucash-dbgsym_2.6.18-1_amd64.deb
9b6ef97b4768bef0737ee16fdce7ca0f49b3af8c6f1764a4e50e623d06e1d295 17526
gnucash_2.6.18-1_amd64.buildinfo
dbace15527cfb21278709f9a760824915c7bb3624c200ee5564b79f492859a72 3253908
gnucash_2.6.18-1_amd64.deb
cf9a7635754082d412af832f4d710cbf967b9eebc140306a1c94228199b9cb23 510820
python-gnucash-dbgsym_2.6.18-1_amd64.deb
a6158df2962564fea5d172673ef510e531d2e79f7282481de0c139e1f8dffc65 243372
python-gnucash_2.6.18-1_amd64.deb
Files:
089b59faa7d2042ff64cdd432bb37f00 2360 gnome optional gnucash_2.6.18-1.dsc
f77795b5d833d133243a9b05c89a45d5 13583327 gnome optional
gnucash_2.6.18.orig.tar.bz2
e376fa7bf8a34ce5449ccf6346e4ce8d 36052 gnome optional
gnucash_2.6.18-1.debian.tar.xz
fee5ede91d1c3959b794fdea656349ce 4968120 gnome optional
gnucash-common_2.6.18-1_all.deb
a0d7cf3e3002e297aaff97571839d66d 7023024 debug optional
gnucash-dbgsym_2.6.18-1_amd64.deb
05fceed5e433ea7ef9d71b7bd24139f7 17526 gnome optional
gnucash_2.6.18-1_amd64.buildinfo
7c4cb1a7befe761195456989b4389101 3253908 gnome optional
gnucash_2.6.18-1_amd64.deb
e048fbfd905c59788aed822ab89c923e 510820 debug optional
python-gnucash-dbgsym_2.6.18-1_amd64.deb
ccfd3af898a2a75d5fc14544c5e90966 243372 python optional
python-gnucash_2.6.18-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEULx8+TnSDCcqawZWUra72VOWjRsFAloICiQACgkQUra72VOW
jRtglw//dgvpXFpK9tkejF6MJO65DU/SGGgWMaoSrzsFUqtpRdBlCfz6dl0+Cvsy
buWK9OBHJkL/IvE65cUroiXF+eFG1SX30tCsHcainG1q8ZPUfs10kc+CCNW7PErx
LGbPMj0N87cymzJwXGENzHIYv/OPXTPq0l0eLOU+Z/mAkAiuGIwsc1NBD0XYyK2Y
Qc8IH2T1pip3hAb+WmeWscQO+ouk5+tVwYGFPDavadcCQekZvU5hAY/T/w9YEugt
8VQ1T0Ag9AJIYbGq2awX5syR42oY4v6D8ne/zM4mb7JLw8dqAaXfMt07x5CfRTdt
e18c8NoJg7NpnqvVpn2pA5tkArmU7zgNVnz2600n+nUpOZeWhO9qk0L7y25jJ6v4
Elmvs6eegBKb8ntg1oUuqBAVwM+9XaUXr2hLtYR7CS2vQnJXvikRlobLCmY3vOWq
A1amvQVEYQi/nAkaAkRLHduLS5rGbky0eLusMJg+7I6ltXpWv6KBIh5XwBYds9Dc
9MQy9r3QRj7dt/OLNH09Mkk4BBWFEKYRAfyCNEVdlRO32xK9MAQ9+OBFrbuTf4PD
PAGX8r/1fSDbVUrAxAU+b7xrNsOSmVXWsHhd9CtPcEfRMRYjszv5lpOhh+fwlCP2
x0PtmYNOaZsm4ledZcFeNtx0B8IPZ30vkVexXOAm4cMSpWfpB5Q=
=aC02
-----END PGP SIGNATURE-----
--- End Message ---
