On Mon, Jan 15, 2018 at 10:33:01AM +0530, Vasudev Kamath wrote: > Adam Borowski <kilob...@angband.pl> writes: > > >> Yeah. Since you mentioned its random can we reduce the severity of the > >> bug?. > > > > Bad idea, as it fails a lot: on my armhf box, 17/20 times, on my amd64, 6/12 > > times. > > > > Turn out, the problem is not that sometimes it fails. The wrongness it that > > it doesn't fail when it should. > > > > Did you notice these syntax errors from dot that are found in your log as > > well? They didn't happen on official buildds five months ago. I dismissed > > them as they _usually_ are ignored, but it turns out that sometimes, with a > > low probability, they do cause FTBFS. There's quite a bunch of those syntax > > errors, though, so even though every one is unlikely to cause a failure, the > > overall chance is high. > > Thing is this package is never updated for quite long time. May be > things changed in Doxygen ?
Looks so. > > So, the real bug is dot ignoring these errors. Not only this causes problem > > like intermittent failures here, it's also against the Policy (which > > requires errors to be detected as a "must" clause), and common sense -- as > > the docs get corrupted in random ways. > > > > > > As for the errors themselves, an example: > > Node12 > > [label="CTPP::CTPP2JSONParser\l::IsString",height=0.2,width=0.4,color="black", > > fillcolor="white", > > style="filled",URL="$a01311.xhtml#a9a4c251b78ce957f7e6cd9bc12ecbb6a",tooltip="JSON > > string \"blah-blah \\" clah-clah \" | 'blah-blah \' clah-clah > > '. "]; > > note ｢\\"｣ -- ie, an unescaped quotation mark. > > > > > > I don't know graphviz enough to point the blame either at it or the way > > ctpp2's build system calls it, I suspect the former, though. Which would > > mean reassigning to graphviz. Not sure what's the cause and severity of the > > unescaped quote; ignoring errors is definitely RC, though. > > Same here. I see 2 possibility, as you said re-assign bug to graphviz or > I drop building ctpp2-doc package itself. ctpp2 is only used by one > package related kiwix and no one else. So dropping doc package should > not cause any problem. What do you think?. Dropping the doc package would get the issue out of your land, but so would reassigning it to doxygen -- if I get it correctly, it's doxygen that produced these ill-escaped dot files, and graphviz merely consumes them, right? The other issue, errors being usually ignored, also deserves to be fixed, but if you care only about the problem going away, it'd ensure you have the build failure every time :) Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ Imagine there are bandits in your house, your kid is bleeding out, ⢿⡄⠘⠷⠚⠋⠀ the house is on fire, and seven big-ass trumpets are playing in the ⠈⠳⣄⠀⠀⠀⠀ sky. Your cat demands food. The priority should be obvious...
