On Sun, 28 Jan 2018 at 17:35:05 +0200, Adrian Bunk wrote:
> On Sun, Jan 28, 2018 at 02:20:19PM +0000, Simon McVittie wrote:
> > I think the canonical way to
> > fix this class of bug is to ensure that dh-autoreconf runs gtkdocize,
> > either by running upstream's autogen.sh (if it's in the tarball):
> >
> > https://salsa.debian.org/gnome-team/gtk3/commit/490e3220dfc976d181aab3e89c34e7a75080d94a
> >
> > or by providing a simplified version ourselves:
> >
> > https://salsa.debian.org/debian/flatpak/commit/d8004c50ffb6c99e20a77873e8cf48967afddfe8
> > https://salsa.debian.org/debian/flatpak/commit/8686daaf43a6d5674d1d545435f19b89773790b4
> >
> > That doesn't seem like something that would justify a re-upload, though.
>
> Without testing it, all this looks as if it would break
> dpkg-buildpackage && dpkg-buildpackage
dh_autoreconf avoids that by hooking dh_autoreconf_clean into
the clean target, which is the same way that it avoids breaking the
build-twice-in-a-row use-case with its changes to Makefile.in, configure,
or other Autotools-generated files in the orig tarball.
There have been bugs in this in the past, some of which were fixed as
recently as dh-autoreconf/16, but in general it works. In particular,
I've checked that flatpak can build twice in a row on today's unstable.
smcv
